From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED60CC4829E for ; Thu, 15 Feb 2024 07:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5mL+Is/EiHWT8yTX3NqWf3PBMmta+9jeRLO3O5S1Etc=; b=GwR8DAWwm70nOK fHlSLTY04pbWfzrekzM2MWQDKzvqmafUjNtIrBh+o6RBaYnAxf19KCJP6zB21cWF45swhfzVkHXWA N3yGb17Pi8AjHOR9LTyJYMBv+MeMuHSMu88fxjdyCT8/cnTx5fjZ6LdJCAc+/+wT6rcMkfLKNp6cS DqssMStciIcmjbY5FXBNAIfWrlNRtJO7WCnWuoncFMy7OqQXLspHcW+HQn/plTh10K6dMuEPK0Qex lbNR2C3GwDm7lSQJj7QwJMGZpBozDjDjEZjPMlRZNC6G27yy4CFb+dUwMNxgNvEw0Iuv/AX0GQ11g YHWKst+Spyda94OKedqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raW2C-0000000FDGF-2lS5; Thu, 15 Feb 2024 07:19:52 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raW29-0000000FDFW-1MZW for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 07:19:51 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id B02D61C0005; Thu, 15 Feb 2024 07:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707981584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qieT2V8qh8j5k3DSAaJeE/xzPVOTH5+a2qFckHpBsi0=; b=PlrBizhFKr9GmYlg/RJutFVOSydG0cdSZgtPSHCFs+RN1pslgbfi80oFHcWMUCPZqn8fdF HlA1V9dBWl8ix+45xjJQzdwknFsTWhG7w+Eg18N+WWXDsVu6TkRG+FCv2+OCpEe/9erJel Gi6Vb+37cespGAogm091ZaKtZ2cNEWlKIBOJ/7V7w7MPPP61KMR4KbjoWPkSJff3B+gBJw ccYlUHVgEr23GVTD6d25QsdkM4wL89AyI9WEroVoE5h1QHVUXzXYwvhUXZGG8YivukJVD6 vZRzxyhk+ZzBRsrDAHjVTE3ejT/Mkf7YnNmiDAo0HM/LxQd/F/YmXPoBX+jcuQ== Date: Thu, 15 Feb 2024 08:19:39 +0100 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking Message-ID: <20240215081939.1df19818@device-28.home> In-Reply-To: <20240214165902.55bf3a04@kernel.org> References: <20240213150431.1796171-1-maxime.chevallier@bootlin.com> <20240214165902.55bf3a04@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_231949_560766_555E3689 X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jakub, On Wed, 14 Feb 2024 16:59:02 -0800 Jakub Kicinski wrote: > On Tue, 13 Feb 2024 16:04:17 +0100 Maxime Chevallier wrote: > > This is V7 for the link topology addition, allowing to track all PHYs > > that are linked to netdevices. > > > > The main change in V7 is the protection of the main internal API > > entrypoints (link_topo_init/cleanup, link_topo_add/del_phy) by > > IS_REACHABLE(CONFIG_PHYLIB). > > > > That's restrictive, but it looks difficult to do otherwise while still keep the > > data structure opaque and not add dependency clutter with PHYLIB. > > > > As you can tell, I'm unsure about this, so please don't hesitate to > > comment on that part :) > > > > The other changes are very minor, the only one is a call to netdev_put > > in the .done() netlink callback. > > > > As a remainder, here's what the PHY listings would look like : > > - eth0 has a 88x3310 acting as media converter, and an SFP module with > > an embedded 88e1111 PHY > > - eth2 has a 88e1510 PHY > > Needs a rebase, core has been busy lately: Arg, I'll send a rebased version, sorry about that Best regards, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel