From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1588DC4829E for ; Thu, 15 Feb 2024 11:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YHPTxKQgg1do15beMoyUZR7B2wt5caIYcZPySl8rkvg=; b=1X2UYnE/4h1ZI/ jJxwG9H+5VEon5CVihNlX+RqbUVzNKueIVfSZuurraa4xxp+uY1ljbgV2XgkyURIz4X3vh1UDcVPa vOnjtSFTG9Hxtl9nXNeJaHWOV9ATGly2yHr3SZkLYVT2zSr4L2DZANj+oRs0Q8ejQeiwqyfaztrBm QKLjLSLl/rbSuFQ0i3PpB+Cz8CNzy0MKaOyel5Z8n+RulsY+TkWWLuQ+g4geDd28Y/2uk1PnrrgM0 +xst7BjJxStN/sBLlkSataTIsYBnzbtWNv8MUDMzJ0GoKWBI5YNkG2RAvHFM9jBzor4a0L/IlbD9w uhBhi34jEVKAx6YsEZEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raZVI-0000000FvOE-3vud; Thu, 15 Feb 2024 11:02:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raZVF-0000000FvNY-3vYv for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 11:02:07 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E488E183; Thu, 15 Feb 2024 12:01:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1707994919; bh=Nj1yulrL/F/3NFHpUqtTgULAH+4SIsqHUM2uketxzIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MBk8zBOQqbJHfWopb+XTymwf/ByBbxflk6s44hkpi/zBcKTZ0AY0fdVB946vnkz7B KfSy8pfE1x61XO0G3WZ1ABUngH0T3DTyU+frXdHobiApQRM8LmcZJ0mYCPGhrhoaY+ mLruYonaTmhAzT4n24Z2wWzPwmxq9zgBTjlPfdRM= Date: Thu, 15 Feb 2024 13:02:05 +0200 From: Laurent Pinchart To: Conor Dooley Cc: Daniel Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240215110205.GD7873@pendragon.ideasonboard.com> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> <20240214-velcro-pushy-0cbd18b23361@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240214-velcro-pushy-0cbd18b23361@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_030206_140887_72332690 X-CRM114-Status: GOOD ( 29.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 14, 2024 at 05:37:17PM +0000, Conor Dooley wrote: > On Wed, Feb 14, 2024 at 04:28:25PM +0200, Laurent Pinchart wrote: > > On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: > > > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > > > > > > Acked-by: Nayden Kanchev > > > Signed-off-by: Daniel Scally > > > --- > > > Changes in v2: > > > > > > - Added clocks information > > > - Fixed the warnings raised by Rob > > > > > > .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ > > > 1 file changed, 77 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > new file mode 100644 > > > index 000000000000..30038cfec3a4 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > @@ -0,0 +1,77 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: ARM Mali-C55 Image Signal Processor > > > + > > > +maintainers: > > > + - Daniel Scally > > > + - Jacopo Mondi > > > + > > > +properties: > > > + compatible: > > > + const: arm,mali-c55 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: ISP video clock > > > > I wonder if we need this clock. Granted, it's an input clock to the ISP, > > but it's part of the input video bus. I don't expect anyone would ever > > need to control it manually, it should be provided by the video source > > automatically. > > I'd say that if there's a clock controller providing this clock, even if > it is implicit in the video feed it's good to have here. Being able to > increment the refcount on that clock would be good, even if you don't > actually control it manually? I don't expect there would be a clock controller to directly reference in most cases. It depends a bit on where the clock domain crossing between the source (often a CSI-2 receiver) and the ISP is. If it's implemented in glue logic bundled with the ISP, which wouldn't be described in DT as a separate node, then there's a higher chance we'll have a clock controller for vclk. If it's implemented in the source, vclk will just come from the source, which won't be listed as a clock controller. One option would be to make this clock optional, by moving it to the end of the clocks list, and setting minItems: 2 maxItems: 3 > > > + - description: ISP AXI clock > > > + - description: ISP AHB-lite clock > > > > These two other clocks look good to me. > > > > > + > > > + clock-names: > > > + items: > > > + - const: vclk > > > + - const: aclk > > > + - const: hclk > > Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the > tree clock names you've provided - they're all clocks, so having "clk" > in them is just noise :) As far as I understand, the names proposed by Dan come directly from the IP core documentation. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel