From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FF3EC48BC4 for ; Fri, 16 Feb 2024 19:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KDTmmeY1QnwIvOEAMIN6kyLNKMaCYaD271fiRGa3kWA=; b=SZ8p1q0RTplAlwjTYhNps4yJRx Pr3daGTQMGuNnNkjnu3i9jpYfZWQ81sfBv0rpzwPV3j9teqKBnyHFVwS+daxTN7qHw8IKtkHAC1mB d3LgXzGkFrc7lNwi/gTFIJs1JT8tV+wkq9ofAVH4BoWAttGknWgS5EQX3a3DXYAxA0DaGKTCEB/WM rz3H7Ljxn/vEfKsio7ETq4hs8GIPOnJD0gFkwcupqYrd+xMu3Zzd23WT6bRByaSDtLWA/H3HfXQ7t E5x6/s7PKemaVIXhr7oKFEtWwv6e1tKZ31n1JOMmPkaxSIb/8ujgZSfUPkWC7qORT4BULlf2FlVPV Fco1x0UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb3ZA-00000003SaZ-1tLV; Fri, 16 Feb 2024 19:08:08 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb3Z7-00000003SZk-2HEf for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 19:08:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E5C37CE2CDB; Fri, 16 Feb 2024 19:08:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD61C433C7; Fri, 16 Feb 2024 19:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708110483; bh=japET/leIP47UNLN6OC2SEbuPJH4MNioCZrfy5PbCok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AugAa9GC2/T89VLJj71TRRt8u5SkQn/eFM4J3NtjVQk6RKptQjS/CbCZTPaSbWr7x SpKow+1LV2NRD9NVjX5aWmmbReIDntaiqdaLxsa+/hDsJkwUlflpqvPAYApCZiNRGo p6rlwPz4BdjkptjZzAjgNHVfytDMd9YxkNLL1yQCppJDL5fCCTtOCCGxMgfD0Lz01V y63x4RZIZKutHrYy3I5gQUtR6idObP6mzqamD+b2yTAk3pKuEgVer312G4LwMcwGLP n92rzlE0EC4M3MOoGMKz0oMNfQ1lO+bketbgMbInOUYA5pwm2QGYlTjA9S3i71wvr8 xqGWVeY+sgFqg== Date: Fri, 16 Feb 2024 19:07:58 +0000 From: Conor Dooley To: Dan Scally Cc: Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240216-caboose-poison-3052a4bb9eaf@spud> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> <20240214-velcro-pushy-0cbd18b23361@spud> <20240215110205.GD7873@pendragon.ideasonboard.com> <20240216132755.GA20376@pendragon.ideasonboard.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_110805_763218_346836FC X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5676295200010638592==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5676295200010638592== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sfDhR62w4u8OGMHn" Content-Disposition: inline --sfDhR62w4u8OGMHn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 02:45:31PM +0000, Dan Scally wrote: > > > > > > > + - description: ISP AXI clock > > > > > > > + - description: ISP AHB-lite clock > > > > > > These two other clocks look good to me. > > > > > >=20 > > > > > > > + > > > > > > > + clock-names: > > > > > > > + items: > > > > > > > + - const: vclk > > > > > > > + - const: aclk > > > > > > > + - const: hclk > > > > > Why not "video" "axi" "ahb-lite"? There's 3 useful letters betwee= n the > > > > > tree clock names you've provided - they're all clocks, so having = "clk" > > > > > in them is just noise :) > > > > As far as I understand, the names proposed by Dan come directly fro= m the > > > > IP core documentation. > > > This is the case, but I do take Conor's point that more descriptive n= ames might be nicer - if I'm > > > honest I just didn't think about it particularly given "Xclk" is such= a common name for them > > > already, but having been poked into thinking about it I do agree. > > Isn't the usual practice in DT bindings is to name GPIOs, clocks and re= set > > signals based on the hardware documentation ? >=20 >=20 > Ah - I don't know honestly. If that's so then yeah - these are the names = the documentation prescribes. If a direct doc match is what you're going for, then sure, keep it. --sfDhR62w4u8OGMHn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc+yjgAKCRB4tDGHoIJi 0olJAQD1XeyYvq7eUU1kc3RWmEQqYgrVam7innpr+WsdCIWbVwEA0W2MtdXieAk/ YdhMBAB4FxEYyjLNPi8cV6v57dDMdA8= =7cwN -----END PGP SIGNATURE----- --sfDhR62w4u8OGMHn-- --===============5676295200010638592== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5676295200010638592==--