From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5444CC48BEB for ; Fri, 16 Feb 2024 09:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A3klkJ9gR5F/1yfm3wgFsBQhCqwIVC6V93REyvmmW/4=; b=LPuUMp+rPMvn6ERXtVJoa0hPPa NCFk7wOPIyExKE9woMRSAbT+HGok53C6jQjOYDPRkqTl4K/t95dmcfuIinwxHjFozzqfvxzvoK4Dn NECnlpyHJtxCr+w5mrcQaE6H3MRDcbWsj2wDlO14Wa/nf3WZDwD7IkC5xOJbaJy4vjvB9SASPP90P 4hJ0RtQtzSK43F0AosNapVrQFCqv98eBv9hwu97Cwxnjj5Kbou3rmF/yF/xCYmanHYTyM77kYN7ab yIJTg+ZtDFCiogHJfImCfwgOIonF3Oa0bxaDHYgbodDXytjP40RTqJ5W2evGwFycpt3O6mk007OyG GTwabz4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raue4-00000001kf1-0m2A; Fri, 16 Feb 2024 09:36:36 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raue1-00000001keW-2mqF for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 09:36:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1708076193; x=1739612193; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tr1J8WOC+2p8ubr8+eCJujXILeG2ySFEIqEf0ShF1JM=; b=QJInWPvZbA7F/n0mSKUzDB3BMO4VnBR1bD/yD4Tma0gkTMc057JFyy1J worEv1oAiJTcMpd7xcQs3/SNX+U1piMCsOQHZUrcMSreSehcMY14E72ch hfAUYAM+idiMWdLTtCLo76M6j0fQttaXceC9GCUqNjWsMtydn+ZGM7M5u mE+/1SDMW+vxIoac0PbU49uHrfOMucZC9zD+tMwHMLVoWYUS9cU0w6+rt r+T7YKYrY5K8ZjrCE1dpYFFp9lvj6O7MReHkqMFvXZ63vLyGgmpsNxWJ3 oLM9eg6XHz5cgApbVjqoOUGyKuRICJs/k0nHOGA4NoEgUIZqXoSHQ81mj A==; X-CSE-ConnectionGUID: pJWeZjTqROyJuezpZWgBKQ== X-CSE-MsgGUID: UNF4OwJ9RUK/tyZzz1Kpmw== X-IronPort-AV: E=Sophos;i="6.06,164,1705388400"; d="asc'?scan'208";a="247085294" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2024 02:36:30 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 16 Feb 2024 02:36:25 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 16 Feb 2024 02:36:22 -0700 Date: Fri, 16 Feb 2024 09:35:42 +0000 From: Conor Dooley To: claudiu beznea Subject: Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node Message-ID: <20240216-eleven-exposure-dde558e63aaf@wendy> References: <20240215091524.14732-1-mihai.sain@microchip.com> <20240215091524.14732-3-mihai.sain@microchip.com> <20240215-lustily-flick-69cb48b123c3@spud> <20240216075609e58aeee4@mail.local> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_013633_851387_D18FD72F X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, andre.przywara@arm.com, conor+dt@kernel.org, conor@kernel.org, Mihai.Sain@microchip.com, robh+dt@kernel.org, Cristian.Birsan@microchip.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7517048456938982926==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7517048456938982926== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sduO+pYooNnUEhXl" Content-Disposition: inline --sduO+pYooNnUEhXl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 10:24:13AM +0200, claudiu beznea wrote: > On 16.02.2024 09:56, Alexandre Belloni wrote: > > On 16/02/2024 06:58:10+0000, Mihai.Sain@microchip.com wrote: > >>> diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot= /dts/microchip/sama7g5.dtsi > >>> index 269e0a3ca269..c030b318985a 100644 > >>> --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi > >>> +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi > >>> @@ -958,6 +958,30 @@ i2c9: i2c@600 { > >>> }; > >>> }; > >>> =20 > >>> + flx10: flexcom@e2820000 { > >>> + compatible =3D "atmel,sama5d2-flexcom"; > >> > >> My comment here was ignored: > >> https://lore.kernel.org/all/20240214-robe-pregnancy-a1b056c9fe14@spud/ > >> > >> The SAMA7G5 has the same flexcom controller as SAMA5D2 MPU. > >> > >=20 > > Still, it needs its own compatible plus a fallback to > > atmel,sama5d2-flexcom >=20 > I agree with this. Though, flexcom documentation is subject to YAML > conversion (a patch has been re-posted these days [1] and *maybe* it will > be integrated this time). And there are multiple SoC DTs that need to be > updated with their own flexcom compatible (lan966x, sam9x60, sama7g5). >=20 > To avoid conflicting with the work at [1] and postponing this series we m= ay > do the update after the [1] is done. >=20 > Let me know your thoughts. Either way is fine by me. I'd be inclined to say that if we are gonna take a shortcut here, then this patch should add a specific compatible so that when the yaml conversion goes through you'll get a warning about this being undocumented rather than silence. A resend on the flexcom patch is required though, the rebase was not done correctly, so maybe Balakrishnan could "atmel,sama7g5-flexcom" add with a fallback to "atmel,sama5d2-flexcom" while they're fixing it up? Cheers, Conor. --sduO+pYooNnUEhXl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZc8sbgAKCRB4tDGHoIJi 0vQ+AP4oW1fosffEhtquR/gVVNyOSQhkI7iXCEoFlMivSaXXeAD/ZK1WNHbDzFWQ IbUslS4h6+t6778C+cxayxDTTfVIpAk= =nBtH -----END PGP SIGNATURE----- --sduO+pYooNnUEhXl-- --===============7517048456938982926== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7517048456938982926==--