Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node

Alexandre Belloni
2024-02-16T07:56:28Z

On 16/02/2024 06:58:10+0000, Mihai.Sain@microchip.com wrote:
> > diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > index 269e0a3ca269..c030b318985a 100644
> > --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > @@ -958,6 +958,30 @@ i2c9: i2c@600 {
> > };
> > };
> >
> > + flx10: flexcom@e2820000 {
> > + compatible = "atmel,sama5d2-flexcom";
>
> My comment here was ignored:
> https://lore.kernel.org/all/20240214-robe-pregnancy-a1b056c9fe14@spud/
>
> The SAMA7G5 has the same flexcom controller as SAMA5D2 MPU.
>

Still, it needs its own compatible plus a fallback to
atmel,sama5d2-flexcom

> https://github.com/torvalds/linux/blob/master/drivers/mfd/atmel-flexcom.c#L83
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt#L8

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering