From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D3B3C4829E for ; Fri, 16 Feb 2024 02:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chdI1Yd0HOXAyvdUFcxU7ZmHZGmZ8vzNQ+B8lDdxKzM=; b=0f2Er7o+EQuFrn GeMPl2fUogLOt38ptVn+ImqeQAodh3jCxbXg+095ZdWXvpnwMZap5X54t5NMe6rMhUHKAhUqENFwL h2h7kazBh1qBdGA0/mJrSnFlNwg0Z/pVWIoabAx6ipVHxv1UMtNey5JysPgMIvRzA4OSRglMtSzwL r4z6mnmXguXTnfLSGBBKv9vEENMq5wzgBMGUOf09+qhHxsk/yQ3FNN+8jlY603ij70fzzclydFDzt 7kTBbvMCGkiMcm35R1Z53Dq/HOT4m3ncJUgmUQEqtwTUop/ipacj0UKTSDsm+Pjky6ghYB+sComCC QwoHJQZyxeJpavnBBPVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rans1-00000000pWn-393f; Fri, 16 Feb 2024 02:22:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ranry-00000000pWL-3yTQ for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 02:22:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5EBAD61E02; Fri, 16 Feb 2024 02:22:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1DA0C433C7; Fri, 16 Feb 2024 02:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708050150; bh=zg+Z3Wah5eTVPItwO6FJ2RVvEQEJ1NRiUkZF3MelZyk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uiTloFP9XrJcN+hTsBncpqBBToqTcyRkpfQGYFEb7jX0T6QhJLr7dhhforheQ1OnY hOKsoQYD15EtK1JanYTgt3QHZ66GXGMFVjaodGoA+hVZTDB8i3cDm50tn4rDrRDbuq bsbTV5XbS0NnZDxIeXvN8ozdK2TvKfgaVor2pNNmJ9ccHVKtkxKhdz5D0/3mgLs3cA +wWfH/4Vhm6XSxA6YKT5gqvXUsDBc1JsWvAZOA7PxsYYUZrvPIe908+NGC8JCQ3dDj H2dBs4ws3mEIEtEN4VLkciePiNEhwKKHP7zmoADBNVWac1UEnNZjWtCwfyzP7O7D3q tx3uV9IaevnjA== Date: Thu, 15 Feb 2024 20:22:27 -0600 From: Rob Herring To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Linus Walleij , Andi Shyti , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH 02/13] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example Message-ID: <20240216022227.GA850600-robh@kernel.org> References: <20240215-mbly-i2c-v1-0-19a336e91dca@bootlin.com> <20240215-mbly-i2c-v1-2-19a336e91dca@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240215-mbly-i2c-v1-2-19a336e91dca@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_182231_090958_BD37059E X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 05:52:09PM +0100, Th=E9o Lebrun wrote: > Add EyeQ5 bindings to the existing Nomadik I2C dt-bindings. Add the two > EyeQ5-specific properties behind a conditional. Add an example for this > compatible. > = > Signed-off-by: Th=E9o Lebrun > --- > .../devicetree/bindings/i2c/st,nomadik-i2c.yaml | 44 ++++++++++++++++= ++++-- > 1 file changed, 40 insertions(+), 4 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml b/= Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > index e6b95e3765ac..eaade14b6d4c 100644 > --- a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > @@ -14,9 +14,6 @@ description: The Nomadik I2C host controller began its = life in the ST > maintainers: > - Linus Walleij > = > -allOf: > - - $ref: /schemas/i2c/i2c-controller.yaml# > - > # Need a custom select here or 'arm,primecell' will match on lots of nod= es > select: > properties: > @@ -24,6 +21,7 @@ select: > contains: > enum: > - st,nomadik-i2c > + - mobileye,eyeq5-i2c > required: > - compatible > = > @@ -39,6 +37,10 @@ properties: > - const: stericsson,db8500-i2c > - const: st,nomadik-i2c > - const: arm,primecell > + # The variant found on Mobileye EyeQ5 > + - items: > + - const: mobileye,eyeq5-i2c > + - const: arm,primecell > = > reg: > maxItems: 1 > @@ -55,7 +57,7 @@ properties: > - items: > - const: mclk > - const: apb_pclk > - # Clock name in DB8500 > + # Clock name in DB8500 or EyeQ5 > - items: > - const: i2cclk > - const: apb_pclk > @@ -83,6 +85,25 @@ required: > = > unevaluatedProperties: false > = > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: mobileye,eyeq5-i2c > + then: > + properties: > + mobileye,olb: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: A phandle to the OLB syscon. Define properties at the top-level and then restrict them in if/then = schemas. > + mobileye,id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Platform-wide controller ID (integer starting fro= m zero). instance indexes are a NAK. You can use i2cN aliases if you must. Why do you need it? To access OLB? If so, add cell args to the OLB = phandle instead. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel