linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mihai.Sain@microchip.com
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, andre.przywara@arm.com,
	claudiu.beznea@tuxon.dev, conor@kernel.org, robh+dt@kernel.org,
	Cristian.Birsan@microchip.com, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node
Date: Fri, 16 Feb 2024 08:56:09 +0100	[thread overview]
Message-ID: <20240216075609e58aeee4@mail.local> (raw)
In-Reply-To: <PH8PR11MB6804E9353A8EEBD2B829D8B3824C2@PH8PR11MB6804.namprd11.prod.outlook.com>

On 16/02/2024 06:58:10+0000, Mihai.Sain@microchip.com wrote:
> > diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > index 269e0a3ca269..c030b318985a 100644
> > --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> > @@ -958,6 +958,30 @@ i2c9: i2c@600 {
> >  			};
> >  		};
> >  
> > +		flx10: flexcom@e2820000 {
> > +			compatible = "atmel,sama5d2-flexcom";
> 
> My comment here was ignored:
> https://lore.kernel.org/all/20240214-robe-pregnancy-a1b056c9fe14@spud/
> 
> The SAMA7G5 has the same flexcom controller as SAMA5D2 MPU.
> 

Still, it needs its own compatible plus a fallback to
atmel,sama5d2-flexcom

> https://github.com/torvalds/linux/blob/master/drivers/mfd/atmel-flexcom.c#L83
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt#L8

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-16  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15  9:15 [PATCH v3 0/3] Add initial support for Microchip SAMA7G54 Curiosity board Mihai Sain
2024-02-15  9:15 ` [PATCH v3 1/3] dt-bindings: ARM: at91: Document Microchip SAMA7G54 Curiosity Mihai Sain
2024-02-15  9:15 ` [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node Mihai Sain
2024-02-15 17:03   ` Conor Dooley
2024-02-16  6:58     ` Mihai.Sain
2024-02-16  7:56       ` Alexandre Belloni [this message]
2024-02-16  8:24         ` claudiu beznea
2024-02-16  9:35           ` Conor Dooley
2024-02-19 18:45             ` claudiu beznea
2024-02-20 19:25               ` Conor Dooley
2024-02-15  9:15 ` [PATCH v3 3/3] ARM: dts: microchip: sama7g54_curiosity: Add initial device tree of the board Mihai Sain
2024-02-23 20:26 ` [PATCH v3 0/3] Add initial support for Microchip SAMA7G54 Curiosity board claudiu beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240216075609e58aeee4@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=Cristian.Birsan@microchip.com \
    --cc=Mihai.Sain@microchip.com \
    --cc=andre.przywara@arm.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).