From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0239BC48260 for ; Fri, 16 Feb 2024 13:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wk6gqJGti9rSp7xQWjcfFv6mvq+1ucDKCreCHibRxqE=; b=S6jvfplbkf+1mI QFQwRFS3kh1XpL73G/uhhxCLt/t1LIt/YsgEzrnsvkvS0xporASAEdYugUQMoTh9DePvr26sryvWK fl4JNVTdXsXgArUpKeVtWvZMs6G7scd1T2OhSGuXK4EL1dCfJGZ5suQHCouZX0hPS7HQvSci0gaQT q8gr8+0ZU4sP1oadmYhXvViJvgUy0I6dO9GHwpU3Fa0nfSv4OaSNm1+ItF21x/tgP9jobsGoJEs02 kE2Xo9S1mUa36l2xzuXnqfqKJ/E5h+c541V8FgJq79gcBAKTX7TUp9/fKba0NjPNGpHfP1faIy51U Q8/qe67NReUn7IxgkIWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rayFy-00000002Qwj-0EC5; Fri, 16 Feb 2024 13:27:58 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rayFu-00000002Qw6-1ofg for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2024 13:27:55 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 16E466B3; Fri, 16 Feb 2024 14:27:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708090067; bh=DVNKQM8UzoLFRwHdVCvWTrQftXuPdsVrLp5GhIq1hdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IZaZNlZ6uiKdIj0R95tBupynQmY8FIWAbLHlo37wQgSUDaQgV6elZgQ/tEsDjElLS LsOgSP8OXEdc1zxzT5VhDuPbp6EPb9eBVUSbisUmUMQ66uJnn0Tqj4fRM0WQT8tfUn tSXsPqNvEKzXRwIqlfGmCrz9s3hGRfP4RkkL1K1Q= Date: Fri, 16 Feb 2024 15:27:55 +0200 From: Laurent Pinchart To: Dan Scally Cc: Conor Dooley , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240216132755.GA20376@pendragon.ideasonboard.com> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> <20240214-velcro-pushy-0cbd18b23361@spud> <20240215110205.GD7873@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_052754_637837_525B2E12 X-CRM114-Status: GOOD ( 33.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 16, 2024 at 01:09:15PM +0000, Daniel Scally wrote: > On 15/02/2024 11:02, Laurent Pinchart wrote: > > On Wed, Feb 14, 2024 at 05:37:17PM +0000, Conor Dooley wrote: > >> On Wed, Feb 14, 2024 at 04:28:25PM +0200, Laurent Pinchart wrote: > >>> On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: > >>>> Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > >>>> > >>>> Acked-by: Nayden Kanchev > >>>> Signed-off-by: Daniel Scally > >>>> --- > >>>> Changes in v2: > >>>> > >>>> - Added clocks information > >>>> - Fixed the warnings raised by Rob > >>>> > >>>> .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ > >>>> 1 file changed, 77 insertions(+) > >>>> create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > >>>> new file mode 100644 > >>>> index 000000000000..30038cfec3a4 > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > >>>> @@ -0,0 +1,77 @@ > >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>> +%YAML 1.2 > >>>> +--- > >>>> +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>> + > >>>> +title: ARM Mali-C55 Image Signal Processor > >>>> + > >>>> +maintainers: > >>>> + - Daniel Scally > >>>> + - Jacopo Mondi > >>>> + > >>>> +properties: > >>>> + compatible: > >>>> + const: arm,mali-c55 > >>>> + > >>>> + reg: > >>>> + maxItems: 1 > >>>> + > >>>> + interrupts: > >>>> + maxItems: 1 > >>>> + > >>>> + clocks: > >>>> + items: > >>>> + - description: ISP video clock > >>> > >>> I wonder if we need this clock. Granted, it's an input clock to the ISP, > >>> but it's part of the input video bus. I don't expect anyone would ever > >>> need to control it manually, it should be provided by the video source > >>> automatically. > >> > >> I'd say that if there's a clock controller providing this clock, even if > >> it is implicit in the video feed it's good to have here. Being able to > >> increment the refcount on that clock would be good, even if you don't > >> actually control it manually? > > > > I don't expect there would be a clock controller to directly reference > > in most cases. It depends a bit on where the clock domain crossing > > between the source (often a CSI-2 receiver) and the ISP is. If it's > > implemented in glue logic bundled with the ISP, which wouldn't be > > described in DT as a separate node, then there's a higher chance we'll > > have a clock controller for vclk. If it's implemented in the source, > > vclk will just come from the source, which won't be listed as a clock > > controller. > > > > One option would be to make this clock optional, by moving it to the end > > of the clocks list, and setting > > > > minItems: 2 > > maxItems: 3 > > > >>>> + - description: ISP AXI clock > >>>> + - description: ISP AHB-lite clock > >>> > >>> These two other clocks look good to me. > >>> > >>>> + > >>>> + clock-names: > >>>> + items: > >>>> + - const: vclk > >>>> + - const: aclk > >>>> + - const: hclk > >> > >> Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the > >> tree clock names you've provided - they're all clocks, so having "clk" > >> in them is just noise :) > > > > As far as I understand, the names proposed by Dan come directly from the > > IP core documentation. > > This is the case, but I do take Conor's point that more descriptive names might be nicer - if I'm > honest I just didn't think about it particularly given "Xclk" is such a common name for them > already, but having been poked into thinking about it I do agree. Isn't the usual practice in DT bindings is to name GPIOs, clocks and reset signals based on the hardware documentation ? -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel