Re: [PATCH] Staging: vc04_services: bcm2835-camera: fixed several brace coding style checks

Moritz Christian Weber
2024-02-19T07:04:12Z

Hi Dan,
thank for highlighting this. I have redone, split and resubmitted the
whole patch yesterday due to the issues Gregs patch bot raised. The
patches build, are checkpatched and also survive a last look. The two
issues that I introduced and which you raised have been not reproduced
in the new submission.

Best regards,
Moritz

On Mon, Feb 19, 2024 at 7:39 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> On Thu, Feb 15, 2024 at 11:06:47PM +0100, Moritz C. Weber wrote:
> > @@ -406,12 +405,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance,
> > is_capturing(dev)) {
> > v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
> > "Grab another frame as buffer has EOS");
> > - vchiq_mmal_port_parameter_set(
> > - instance,
> > - dev->capture.camera_port,
> > - MMAL_PARAMETER_CAPTURE,
> > - &dev->capture.frame_count,
> > - sizeof(dev->capture.frame_count));
> > + vchiq_mmal_port_parameter_set(instance,
> > + dev->capture.camera_port,
> > + MMAL_PARAMETER_CAPTURE,
> > + #N(#O(#O(#O(#O(&dev->capture.frame_count,
> ^^^^^^^^^^^^^^^^
>
> Wut?
>
> > + sizeof(dev->capture.frame_count));
> > }
> > }
> >
> > @@ -420,11 +418,11 @@ static int enable_camera(struct bcm2835_mmal_dev *dev)
> > int ret;
> >
> > if (!dev->camera_use_count) {
> > - ret = vchiq_mmal_port_parameter_set(
> > - dev->instance,
> > - &dev->component[COMP_CAMERA]->control,
> > - MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num,
> > - sizeof(dev->camera_num));
> > + ret = vchiq_mmal_port_parameter_set(dev->instance,
> > + &dev->component[COMP_CAMERA]->control,
> > + MMAL_PARAMETER_CAMERA_NUM,
> > + &dev->camera_num,
> > + **sizeof(dev->camera_num));
>
> Also Wut???
>
>
> regards,
> dan carpenter