From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: linux-kernel@vger.kernel.org,
Dafna Hirschfeld <dafna@fastmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:ROCKCHIP ISP V1 DRIVER" <linux-media@vger.kernel.org>,
"open list:ROCKCHIP ISP V1 DRIVER"
<linux-rockchip@lists.infradead.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
Paul Elder <paul.elder@ideasonboard.com>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: Re: [PATCH] media: rkisp1: Allow higher input resolution
Date: Sun, 18 Feb 2024 22:59:08 +0200 [thread overview]
Message-ID: <20240218205908.GA12766@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240217185202.1754750-1-megi@xff.cz>
Hi Ondrej,
(CC'ing Paul and Umang)
Thank you for the patch.
On Sat, Feb 17, 2024 at 07:51:58PM +0100, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
>
> In BSP driver, it is allowed, and it works in practice. Tested on
> Pinephone Pro/RK3399 with IMX258 at full res.
Paul, Umang, do I recall correctly that you have a similar change ?
Could you review and test this (especially on the i.MX8MP) ?
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> index 4b6b28c05b89..74098ddbeeb3 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> @@ -33,8 +33,8 @@ struct dentry;
> #define RKISP1_ISP_SD_SINK BIT(1)
>
> /* min and max values for the widths and heights of the entities */
> -#define RKISP1_ISP_MAX_WIDTH 4032
> -#define RKISP1_ISP_MAX_HEIGHT 3024
> +#define RKISP1_ISP_MAX_WIDTH 4416
> +#define RKISP1_ISP_MAX_HEIGHT 3312
> #define RKISP1_ISP_MIN_WIDTH 32
> #define RKISP1_ISP_MIN_HEIGHT 32
>
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-18 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 18:51 [PATCH] media: rkisp1: Allow higher input resolution Ondřej Jirman
2024-02-18 20:59 ` Laurent Pinchart [this message]
2024-02-18 21:01 ` Ondřej Jirman
2024-02-19 2:09 ` Adam Ford
2024-02-19 9:03 ` Umang Jain
2024-02-19 10:11 ` Paul Elder
2024-02-19 11:54 ` Laurent Pinchart
2024-02-20 23:59 ` Ondřej Jirman
2024-02-20 23:56 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218205908.GA12766@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=megi@xff.cz \
--cc=paul.elder@ideasonboard.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).