From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B60D8C48BC3 for ; Mon, 19 Feb 2024 11:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YfTJcK/yG+tmQznaqorBFWKgSHDn4Un7T6Vcklo85l0=; b=fXpgz/1s6kPugO RTufUM6nDU+Dj20h/8WUw1m9whc6FelDJtmqquHTWAjgQbRptfLq1RHicHdpMSUM7ncEseMgdRu1g FU6DuYqUGXNTSNlD+L/1AC8sXN14Tnnv0WIrSJYa6NgPeVXSu3oCkq7JyZDnoRKTXCjd8OgWPtznk ZHqL+malunVVcqj03iA/Yi7LW+hrhG9rD97rVFP8QU0bq3wLrkg8KCUOEOLOsbDMHfWfmo13S6p5V HTjONl0k2LBiZN4ac4yDfRUDFTLBKaNUvY9b605HqT8c3Re82cz4DqovCArGrawXIKYk8s/C9gjgV IbB8vOkb9bdAuzbUeHdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc1kE-0000000ABXi-2erA; Mon, 19 Feb 2024 11:23:34 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc1ju-0000000ABKA-2Bdq; Mon, 19 Feb 2024 11:23:16 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-564a59f879aso363809a12.3; Mon, 19 Feb 2024 03:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708341793; x=1708946593; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YuW0tA1+gOLBqnUIoohkzCyIMBvVnloNgoNFu8SX/5U=; b=PssBnQZXRv/lS+2H2xQpSTfhsCErNMbZ7EBlPxZSOk46pzZkrX2xlP5KAcJEUNvTbM ySt8V0rQTyg5rANleAIb15QQsOhK1Kv+KLLokp7DP2ODOrC5ir8c8LHmNAnZ3BRT6yX3 7kO/aicv03VxgOf69bAH8MzI++tso4wLVvJAgjnz/R+YUB77OWcm6HS87Mx6KwL3dPvf jXOirZFDlVdK27LVf5etiM2PLGT2TnRQnxwZ6a7TIYdP169Bd1hdrd+fLOJoSGGvrL28 ecTZOyEvz1SbHsJg/0wdq70Lnjpnx/cZqNb0F3Gamy+lAbGi5/vhdEny7HyrsciE8moK 8jGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708341793; x=1708946593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YuW0tA1+gOLBqnUIoohkzCyIMBvVnloNgoNFu8SX/5U=; b=kWLKzWC9LxrCnpySigEgbeWoNe1YRx8Qgvpk443jNpqKh2tFdSOibc6wkZT7RVttOg JL40wa81bzNncoz6MhWmvktMAOIR62WqOFHRSpEd3RgM57psy39+Khq8U4SAYC5OOK/b 9iJnCrMC5e1bV4LjeYx4+WA0P20d2edNDaUef2CafAzqKWzcHjqXUoeDWNumsAhj8M47 zf83enhH7kxN9HmzYe0yZvx9S3+bUSBTBGEMR82ot7ux29Zhlw8/tRFOCgwiIqJyjHiG pWDTFrTAteaCoeyu91YRUtO79wWCT1+FSSfq+0YGZXgLgbelPPk/btiUsIt6xjMEYJB6 C93w== X-Forwarded-Encrypted: i=1; AJvYcCUZRwROXspT5XZu0XoNEaYZJ/mAvo8sc2YR0jULOcUNt3vymK6CrzJrpmuZlEnHpbOWmeKJksjS8MTbH3oE2l8FUCOx3G2RpqZ92lN0alKcpALNIV11KOGX5V1mmnMypHOy2btYrz2J9UdyCqFwRAtc6P/3Zu5uoNJTnA== X-Gm-Message-State: AOJu0YwlrF7IJ5DFw4DlwPpkdlLzvASDmgEJSHKTr+8svFvZnwA5o6yS Ok8SiWdXBIhaG1o34Eq+zqNz9CCrWkV9x+TtKeQK8i5DMZJVtE4GQnqhZLKD X-Google-Smtp-Source: AGHT+IGSD3jTvmpSu9lWqJy92v3b8wbBP8Kn6inBcfLvx/7Fp4KrXtljJvlVnzhlgszKc5IkdfBLKg== X-Received: by 2002:a17:906:a1cd:b0:a3d:6eb4:9768 with SMTP id bx13-20020a170906a1cd00b00a3d6eb49768mr7088156ejb.46.1708341793096; Mon, 19 Feb 2024 03:23:13 -0800 (PST) Received: from pinguine.lan (ip-176-198-146-182.um43.pools.vodafone-ip.de. [176.198.146.182]) by smtp.gmail.com with ESMTPSA id ti12-20020a170907c20c00b00a3d581658bfsm2826495ejc.24.2024.02.19.03.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:23:12 -0800 (PST) From: "Moritz C. Weber" To: florian.fainelli@broadcom.com Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Moritz C. Weber" Subject: [PATCH v3 2/2] Staging: vc04_services: bcm2835-camera: fix brace code style check Date: Mon, 19 Feb 2024 12:22:34 +0100 Message-Id: <20240219112234.8673-3-mo.c.weber@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240219112234.8673-1-mo.c.weber@gmail.com> References: <236d985c-1835-410f-b0b5-cacbd5fbf930@moroto.mountain> <20240219112234.8673-1-mo.c.weber@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_032314_596348_189DE43F X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reformat function parameters to fix checkpatch check: Increase readability and consistency Signed-off-by: Moritz C. Weber --- .../bcm2835-camera/bcm2835-camera.c | 60 +++++++++---------- 1 file changed, 28 insertions(+), 32 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index e6ff5ea04..c3ba490e5 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -350,12 +350,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, if (is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, - MMAL_PARAMETER_CAPTURE, - &dev->capture.frame_count, - sizeof(dev->capture.frame_count)); + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, + MMAL_PARAMETER_CAPTURE, + &dev->capture.frame_count, + sizeof(dev->capture.frame_count)); } if (vchiq_mmal_submit_buffer(instance, port, &buf->mmal)) @@ -406,12 +405,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance, is_capturing(dev)) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Grab another frame as buffer has EOS"); - vchiq_mmal_port_parameter_set( - instance, - dev->capture.camera_port, - MMAL_PARAMETER_CAPTURE, - &dev->capture.frame_count, - sizeof(dev->capture.frame_count)); + vchiq_mmal_port_parameter_set(instance, + dev->capture.camera_port, + MMAL_PARAMETER_CAPTURE, + &dev->capture.frame_count, + sizeof(dev->capture.frame_count)); } } @@ -420,11 +418,10 @@ static int enable_camera(struct bcm2835_mmal_dev *dev) int ret; if (!dev->camera_use_count) { - ret = vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_CAMERA]->control, - MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num, - sizeof(dev->camera_num)); + ret = vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_CAMERA]->control, + MMAL_PARAMETER_CAMERA_NUM, &dev->camera_num, + sizeof(dev->camera_num)); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "Failed setting camera num, ret %d\n", ret); @@ -468,11 +465,11 @@ static int disable_camera(struct bcm2835_mmal_dev *dev) "Failed disabling camera, ret %d\n", ret); return -EINVAL; } - vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_CAMERA]->control, - MMAL_PARAMETER_CAMERA_NUM, &i, - sizeof(i)); + vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_CAMERA]->control, + MMAL_PARAMETER_CAMERA_NUM, + &i, + sizeof(i)); } v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "Camera refcount now %d\n", dev->camera_use_count); @@ -786,9 +783,8 @@ static int vidioc_overlay(struct file *file, void *f, unsigned int on) ret = vchiq_mmal_port_connect_tunnel(dev->instance, src, NULL); if (ret >= 0) - ret = vchiq_mmal_component_disable( - dev->instance, - dev->component[COMP_PREVIEW]); + ret = vchiq_mmal_component_disable(dev->instance, + dev->component[COMP_PREVIEW]); disable_camera(dev); return ret; @@ -1041,8 +1037,8 @@ static int mmal_setup_video_component(struct bcm2835_mmal_dev *dev, if (overlay_enabled) { ret = vchiq_mmal_port_connect_tunnel(dev->instance, - preview_port, - &dev->component[COMP_PREVIEW]->input[0]); + preview_port, + &dev->component[COMP_PREVIEW]->input[0]); if (ret) return ret; @@ -1719,11 +1715,11 @@ static int mmal_init(struct bcm2835_mmal_dev *dev) { unsigned int enable = 1; - vchiq_mmal_port_parameter_set( - dev->instance, - &dev->component[COMP_VIDEO_ENCODE]->control, - MMAL_PARAMETER_VIDEO_IMMUTABLE_INPUT, - &enable, sizeof(enable)); + vchiq_mmal_port_parameter_set(dev->instance, + &dev->component[COMP_VIDEO_ENCODE]->control, + MMAL_PARAMETER_VIDEO_IMMUTABLE_INPUT, + &enable, + sizeof(enable)); vchiq_mmal_port_parameter_set(dev->instance, &dev->component[COMP_VIDEO_ENCODE]->control, -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel