From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A228EC48BC3 for ; Tue, 20 Feb 2024 19:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=67OTA2SxZevfyqNqOXW+mR2n+QyzacfLPABtA5oWW/w=; b=fyHtiW2Zfbm8RO4qQMHHu+VM8M 4I422OaDOsgXrwJC7vatnDvyThqhVtO4Ow4TDRAV+gZcentmqeqPjvoGcDW8V5rWgQ215bYyavQom idyn0cOGKBafbW0x7vCasQtOoVwn7Gl81eEDRx//AhLUnvA2UYrom0fiNxvEB9OUcJo8FIDKGDk4H 9N9PqO8CiXuJjwV5v2HVA5ijLf0LbAedn0xSA7LyNLTvJMBPAXfkBzKQSwil9WiB4zOR7avcJfwUA VHyek66R6FjOeeDMMnngiElKSnqHNB2FbNuY5lDbEAhxlY7KazUJh6nFHmVYY+ft9SjFURq/OHX87 XEmOhxbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcVkG-0000000FwYR-496D; Tue, 20 Feb 2024 19:25:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcVkF-0000000FwY3-02lk for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 19:25:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 67672612BF; Tue, 20 Feb 2024 19:25:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37A64C433F1; Tue, 20 Feb 2024 19:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708457134; bh=M8gLGSCh+fPBDyoAw2lavmpyPpuGrjXLbQcD1/p22+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S2OpNVNHpMC+QaZwwoQ+eHzY+O7HnU4GcR/O/ztTR85zJyrwRg5LgAO4sLd3OFaU7 ZO2lOALpkoFqgK2z2kY2pPG4gPrl3qCzY6YxF/sP8dGDE9ySMY66LyTr51/VvixaXL 5S7IFHSqwSk1SwUi7TFjWJzmpQMc1muHVU1/37uXSWf8xMC0hAgLAskJG5jD3wmNtF YGJ1G9wHjR2Y749I/kqBRE216WWa9PKiO324R2GXFRk55gImceAcPyKyCrnDfrUOjA pfD6LFJ6ScA7bHUpub4GG6Cl1AQC+mc/poBBSXmCoSz7j6PbyyZr7p0XmVrlIIqWnW D/d2yZ+FFGpWg== Date: Tue, 20 Feb 2024 19:25:28 +0000 From: Conor Dooley To: claudiu beznea Subject: Re: [PATCH v3 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node Message-ID: <20240220-lapel-diaper-0914f6da3beb@spud> References: <20240215091524.14732-1-mihai.sain@microchip.com> <20240215091524.14732-3-mihai.sain@microchip.com> <20240215-lustily-flick-69cb48b123c3@spud> <20240216075609e58aeee4@mail.local> <20240216-eleven-exposure-dde558e63aaf@wendy> <0798f21e-1ab6-4fd2-b7e3-18f35163fad1@tuxon.dev> MIME-Version: 1.0 In-Reply-To: <0798f21e-1ab6-4fd2-b7e3-18f35163fad1@tuxon.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_112535_163801_2ADB9DB5 X-CRM114-Status: GOOD ( 30.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Balakrishnan Sambath , devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, andre.przywara@arm.com, conor+dt@kernel.org, Mihai.Sain@microchip.com, Conor Dooley , robh+dt@kernel.org, Cristian.Birsan@microchip.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3138930297183473674==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3138930297183473674== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yzTjB1umydcFT1/o" Content-Disposition: inline --yzTjB1umydcFT1/o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 19, 2024 at 08:45:45PM +0200, claudiu beznea wrote: >=20 >=20 > On 16.02.2024 11:35, Conor Dooley wrote: > > On Fri, Feb 16, 2024 at 10:24:13AM +0200, claudiu beznea wrote: > >> On 16.02.2024 09:56, Alexandre Belloni wrote: > >>> On 16/02/2024 06:58:10+0000, Mihai.Sain@microchip.com wrote: > >>>>> diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/bo= ot/dts/microchip/sama7g5.dtsi > >>>>> index 269e0a3ca269..c030b318985a 100644 > >>>>> --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi > >>>>> +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi > >>>>> @@ -958,6 +958,30 @@ i2c9: i2c@600 { > >>>>> }; > >>>>> }; > >>>>> =20 > >>>>> + flx10: flexcom@e2820000 { > >>>>> + compatible =3D "atmel,sama5d2-flexcom"; > >>>> > >>>> My comment here was ignored: > >>>> https://lore.kernel.org/all/20240214-robe-pregnancy-a1b056c9fe14@spu= d/ > >>>> > >>>> The SAMA7G5 has the same flexcom controller as SAMA5D2 MPU. > >>>> > >>> > >>> Still, it needs its own compatible plus a fallback to > >>> atmel,sama5d2-flexcom > >> > >> I agree with this. Though, flexcom documentation is subject to YAML > >> conversion (a patch has been re-posted these days [1] and *maybe* it w= ill > >> be integrated this time). And there are multiple SoC DTs that need to = be > >> updated with their own flexcom compatible (lan966x, sam9x60, sama7g5). > >> > >> To avoid conflicting with the work at [1] and postponing this series w= e may > >> do the update after the [1] is done. > >> > >> Let me know your thoughts. Either way is fine by me. > >=20 > > I'd be inclined to say that if we are gonna take a shortcut here, then > > this patch should add a specific compatible so that when the yaml > > conversion goes through you'll get a warning about this being > > undocumented rather than silence. >=20 > All the flexcom nodes from all flexcom capable SoCs (including SAMA7G5) > have the same compatible introduced by Mihai. >=20 > I don't like the idea of updating only the DTSes, either update all DTSes > and documentation or do it as it is already done (with sama5d2 compatible= ). >=20 > >=20 > > A resend on the flexcom patch is required though, the rebase was not > > done correctly, so maybe Balakrishnan could "atmel,sama7g5-flexcom" > > add with a fallback to "atmel,sama5d2-flexcom" while they're fixing > > it up? >=20 > I agree, and DTSes should also be updated along with documentation. I'm biased, I'll almost never disagree with updating things to use soc-specific compatibles... > With this we can go forward with this patch and avoid conflicting with wo= rk > that is currently in progress for flexcom. I forgot to actually CC Balakrishnan, but Nicolas fortunately forwarded it to them. They're added now though to make sure they see this. --yzTjB1umydcFT1/o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdT8qAAKCRB4tDGHoIJi 0uYYAQCNNsmFlZfOvfTXCNDKZbuo0f1s3OpLcxwZv3bxHuakpwD/Q395wy39LoTo OfiPp3KJWQDtXxuRp23mobPwznUIswQ= =5pi2 -----END PGP SIGNATURE----- --yzTjB1umydcFT1/o-- --===============3138930297183473674== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3138930297183473674==--