From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7717AC48BF8 for ; Tue, 20 Feb 2024 03:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TEVwrPnt9Ru1T8Bs6k/nWAWsUIhL9imw4TCQ2n9WozQ=; b=rYsavGex95sfZ9 Bh69TlN6BNt1zhQhDOZCkd7x3ZC0baxVnAnqey7cufo45sD5t2BJVSWRx9t8VDgV007XTTKl2NZzC j6n+zm1c07Rga3X5c3fsHBUAiTiJZw7VimbiUwpATHGo7E4+N6Hvup9OpasCrKLrn4W7D53t8hiWk nWDvhYR3Yq3MqTFnSWFjdM2mmgQhhm2BKQaAUSrQIYFs7BqDdETaaaMkjzXXKdkPLQ+MFSf6iHdSo xXZjRp0ojgDHPn4kO3v+PG9bZBmeCc15yGk+k5fXaqgGUFLAzSZ8D07AESWd2RXbsLjmCpn3aYOgd KXHKNTK/j0GWg5LmXjXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcGNZ-0000000CvUm-1I9Y; Tue, 20 Feb 2024 03:01:09 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcGNW-0000000CvRr-1FQr; Tue, 20 Feb 2024 03:01:07 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EBD8899; Tue, 20 Feb 2024 04:00:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708398053; bh=fi2kbSyA3ZrfR3cC3WHLondtm0nGs7rJi1ZFqm0U/vY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHXdhSVJxQZjDv+YBnDEYoRoVutXWunp+mModsjWczVP65wmvKlAR8aTm4elJJbMF k3SG61DqOjVt48p8aQ9GfHoOMCsJMuvporwwtxk195PMwDfpHBFzg9vGIrVJ2sp1Y8 kYNDbfewAb1oofhURcdvbnjzbzj8MzPVBDJIzJeo= Date: Tue, 20 Feb 2024 05:01:04 +0200 From: Laurent Pinchart To: Zhi Mao =?utf-8?B?KOavm+aZuik=?= Cc: "heiko@sntech.de" , "tomi.valkeinen@ideasonboard.com" , "robh+dt@kernel.org" , "yunkec@chromium.org" , "linux-kernel@vger.kernel.org" , "dan.scally@ideasonboard.com" , "gerald.loacker@wolfvision.net" , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= , "hdegoede@redhat.com" , "linux-media@vger.kernel.org" , "linus.walleij@linaro.org" , "andy.shevchenko@gmail.com" , Yaya Chang =?utf-8?B?KOW8tembhea4hSk=?= , "mchehab@kernel.org" , "jacopo.mondi@ideasonboard.com" , "jernej.skrabec@gmail.com" , "linux-mediatek@lists.infradead.org" , "bingbu.cao@intel.com" , "sakari.ailus@linux.intel.com" , Project_Global_Chrome_Upstream_Group , "10572168@qq.com" <10572168@qq.com>, "conor+dt@kernel.org" , "hverkuil-cisco@xs4all.nl" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" , "macromorgan@hotmail.com" Subject: Re: [PATCH v4 2/2] media: i2c: Add GC08A3 image sensor driver Message-ID: <20240220030104.GF20376@pendragon.ideasonboard.com> References: <20240204061538.2105-1-zhi.mao@mediatek.com> <20240204061538.2105-3-zhi.mao@mediatek.com> <20240206184542.GE2827@pendragon.ideasonboard.com> <598f62bbb55157eec1e23dd1dbc307fea3851b21.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <598f62bbb55157eec1e23dd1dbc307fea3851b21.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_190106_529800_1FA5B01B X-CRM114-Status: GOOD ( 28.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWmhpLAoKT24gVHVlLCBGZWIgMjAsIDIwMjQgYXQgMDI6MTI6MjZBTSArMDAwMCwgWmhpIE1h byAo5q+b5pm6KSB3cm90ZToKPiBPbiBUdWUsIDIwMjQtMDItMDYgYXQgMjA6NDUgKzAyMDAsIExh dXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBTdW4sIEZlYiAwNCwgMjAyNCBhdCAwMjoxNToz OFBNICswODAwLCBaaGkgTWFvIHdyb3RlOgo+ID4gPiBBZGQgYSBWNEwyIHN1Yi1kZXZpY2UgZHJp dmVyIGZvciBHYWxheHljb3JlIEdDMDhBMyBpbWFnZSBzZW5zb3IuCj4gPiA+Cj4gPiA+IFNpZ25l ZC1vZmYtYnk6IFpoaSBNYW8gPHpoaS5tYW9AbWVkaWF0ZWsuY29tPgo+ID4gPiAtLS0KPiA+ID4g IGRyaXZlcnMvbWVkaWEvaTJjL0tjb25maWcgIHwgICAxMCArCj4gPiA+ICBkcml2ZXJzL21lZGlh L2kyYy9NYWtlZmlsZSB8ICAgIDEgKwo+ID4gPiAgZHJpdmVycy9tZWRpYS9pMmMvZ2MwOGEzLmMg fCAxNDQ4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMyBmaWxl cyBjaGFuZ2VkLCAxNDU5IGluc2VydGlvbnMoKykKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL21lZGlhL2kyYy9nYzA4YTMuYwoKW3NuaXBdCgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tZWRpYS9pMmMvZ2MwOGEzLmMgYi9kcml2ZXJzL21lZGlhL2kyYy9nYzA4YTMuYwo+ID4g PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjNmYzdmZmZi ODE1Ywo+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvaTJjL2dj MDhhMy5jCj4gPiA+IEBAIC0wLDAgKzEsMTQ0OCBAQAoKW3NuaXBdCgo+ID4gPiArc3RhdGljIGlu dCBnYzA4YTNfcG93ZXJfb24oc3RydWN0IGRldmljZSAqZGV2KQo+ID4gPiArewo+ID4gPiArCXN0 cnVjdCBpMmNfY2xpZW50ICpjbGllbnQgPSB0b19pMmNfY2xpZW50KGRldik7Cj4gPiA+ICsJc3Ry dWN0IHY0bDJfc3ViZGV2ICpzZCA9IGkyY19nZXRfY2xpZW50ZGF0YShjbGllbnQpOwo+ID4gPiAr CXN0cnVjdCBnYzA4YTMgKmdjMDhhMyA9IHRvX2djMDhhMyhzZCk7Cj4gPiA+ICsJaW50IHJldDsK PiA+ID4gKwo+ID4gPiArCXJldCA9IHJlZ3VsYXRvcl9idWxrX2VuYWJsZShBUlJBWV9TSVpFKGdj MDhhM19zdXBwbHlfbmFtZSksCj4gPiA+ICsJCQkJICAgIGdjMDhhMy0+c3VwcGxpZXMpOwo+ID4g PiArCWlmIChyZXQgPCAwKSB7Cj4gPiA+ICsJCWRldl9lcnIoZ2MwOGEzLT5kZXYsICJmYWlsZWQg dG8gZW5hYmxlIHJlZ3VsYXRvcnM6ICVkXG4iLCByZXQpOwo+ID4gPiArCQlyZXR1cm4gcmV0Owo+ ID4gPiArCX0KPiA+ID4gKwo+ID4gPiArCXJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShnYzA4YTMt PnhjbGspOwo+ID4gPiArCWlmIChyZXQgPCAwKSB7Cj4gPiA+ICsJCXJlZ3VsYXRvcl9idWxrX2Rp c2FibGUoQVJSQVlfU0laRShnYzA4YTNfc3VwcGx5X25hbWUpLAo+ID4gPiArCQkJCSAgICAgICBn YzA4YTMtPnN1cHBsaWVzKTsKPiA+ID4gKwkJZGV2X2VycihnYzA4YTMtPmRldiwgImNsayBwcmVw YXJlIGVuYWJsZSBmYWlsZWRcbiIpOwo+ID4gPiArCQlyZXR1cm4gcmV0Owo+ID4gPiArCX0KPiA+ ID4gKwo+ID4gPiArCXVzbGVlcF9yYW5nZShHQzA4QTNfTUlOX1NMRUVQX1VTLCBHQzA4QTNfTUFY X1NMRUVQX1VTKTsKPiA+ID4gKwo+ID4gPiArCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChnYzA4 YTMtPnJlc2V0X2dwaW8sIDEpOwo+ID4KPiA+IEFyZSB5b3UgYXNzZXJ0aW5nIHJlc2V0IHdoZW4g cG93ZXJpbmcgb24gPyBUaGF0IHNvdW5kcyB3cm9uZywgeW91IHNob3VsZAo+ID4gZGUtYXNzZXJ0 IHJlc2V0IGhlcmUgKGFuZCBhY3F1aXJlIHRoZSByZXNldCBncGlvIGluIHByb2JlKCkgd2l0aAo+ ID4gR1BJT0RfT1VUX0hJR0gpLiBEcml2ZXJzIHNob3VsZCB1c2UgbG9naWNhbCBsZXZlbHMgZm9y IEdQSU9zLCBzZXR0aW5nIGEKPiA+IEdQSU8gbmFtZWQgInJlc2V0IiB0byAxIHNob3VsZCBhc3Nl cnQgdGhlIHJlc2V0IHNpZ25hbCwgZXZlbiBpZiB0aGUKPiA+IHBoeXNpY2FsIHNpZ25hbCBpcyBh Y3RpdmUgbG93LiBZb3UgbWF5IGhhdmUgdGhlIHdyb25nIHBvbGFyaXR5IGluIHRoZQo+ID4gZGV2 aWNlIHRyZWUuCj4KPiBBY2NvcmRpbmcgdG8gdGhlIHNlbnNvciBwb3dlciBzZXF1ZW5jZSBzZXBj LCAicmVzZXQiIHBpbiBzaG91bGQgYmUgcHVsbAo+IGZyb20gbG93IHRvIGhpZ2ggYWZ0ZXIgImRv dmRkL2R2ZGQvYXZkZCIgcG93ZXIgb24sIHNvIEkgZm9sbG93IHRoaXMKPiBwb3dlciBzZXF1ZWNl IHRvIHB1bGwgInJlc2V0IiBwaW4gaGlnaCBpbiBzb2Z0d2FyZSBmbG93LgoKRnJvbSBhIGhhcmR3 YXJlIHBvaW50IG9mIHZpZXcgdGhhdCdzIHJpZ2h0LCBidXQgdGhlIExpbnV4IGtlcm5lbCBoYW5k bGVzCmxvZ2ljYWwgbGV2ZWwgb2YgR1BJT3MuIElmIGEgR1BJTyBpcyBuYW1lZCAicmVzZXQiLCBp dCBpcyBleHBlY3RlZCB0aGF0CmNhbGxpbmcKCglncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXAoZ2Mw OGEzLT5yZXNldF9ncGlvLCAxKTsKCndpbGwgImFzc2VydCIgdGhlIHJlc2V0IHNpZ25hbCwgc2V0 dGluZyBpdCB0byBhIGxvZ2ljYWwgInJlc2V0ID0gdHJ1ZSIKbGV2ZWwuIFRoaXMgbWFwcyB0byB0 aGUgaGFyZHdhcmUgMFYgb3V0cHV0IGxldmVsLCBhcyB0aGUgc2lnbmFsIGlzCmFjdGl2ZS1sb3cu IFRvIGFjaGlldmUgdGhpcywgZGVmaW5lIHRoZSByZXNldCBHUElPIGFzIGFjdGl2ZSBsb3cgaW4g RFQsCmFuZCB0aGUgR1BJTyBmcmFtZXdvcmsgd2lsbCBpbnZlcnQgdGhlIHNpZ25hbCBmb3IgeW91 LiBZb3Ugc2hvdWxkIHRoZW4KY2FsbAoKCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChnYzA4YTMt PnJlc2V0X2dwaW8sIDEpOwoKaW4gdGhlIGRyaXZlciB3aGVuIHlvdSB3YW50IHRvIGFzc2VydCBy ZXNldCAoc2V0IGl0IHRvIDBWKSwgYW5kCgoJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKGdjMDhh My0+cmVzZXRfZ3BpbywgMCk7Cgp3aGVuIHlvdSB3YW50IHRvIGRlYXNzZXJ0IGl0IChzZXQgaXQg dG8gMy4zViwgb3Igd2hhdGV2ZXIgdGhlIEkvTwp2b2x0YWdlIGZvciB0aGUgc2lnbmFsIGlzKS4K ClRoaXMgd2F5IGFsbCBkcml2ZXIgdXNlIGxvZ2ljYWwgc3RhdGVzLCBhbmQgdGhlIGludmVyc2lv biBpcyBoYW5kbGVkIGluCkRULgoKPiA+ID4gKwl1c2xlZXBfcmFuZ2UoR0MwOEEzX01JTl9TTEVF UF9VUywgR0MwOEEzX01BWF9TTEVFUF9VUyk7Cj4gPiA+ICsKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ ID4gK30KCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==