From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 275A0C5475B for ; Tue, 20 Feb 2024 15:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JRPK5GQnuKQRF3fGcfQ9pXvC16I4/aEroasfzr8/Opw=; b=2vj1RvdNql85EJ Ddn4Jpn6eEwoVuipP1VORn2J/LTVBEre+J3WUxaXwPemIGVsKlo6xXfiq2lz+RK7G58WjvUFJo9M7 fzwXDEdGp0aBbBDdlnHx3TB3NEAW8bmqRoeotFKDfaSsYGpFh53pCKHWHmo8+4G4oPj8KebztvDTh /fe3iVF8wYjQu7kzO7dU5fcxQuGsUJxApcppBiF129iU9rbQiYOR/7v6VUCsU4Ur4RsZpbYmaChgx F9sUsWL8paDkotCVqaqPVWRIhmCh7zI0p+jSPEt9fBpB6DJjKQJykBhMxdPiozWZzDm/5xjV1tOvk MUXwUNuMalf+DcioM9Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcRcX-0000000FBDk-01H6; Tue, 20 Feb 2024 15:01:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcRc8-0000000FB0z-0K47 for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 15:01:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 581D16118C; Tue, 20 Feb 2024 15:00:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5071AC433F1; Tue, 20 Feb 2024 15:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708441255; bh=t0kh6fT7xYxfjYlEKpkM6AOETmzHo7MjScDoq365xG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xl5Xrye8FtH7cnrdC7jAssSPoehu+/m2GxRMNDtkrhAkjT+5dEsCWjtUhaWDXmvMI ruOmg+0SePgiidCxNnbMVP3k/v453nd3uTMajSeeusA/xwk2fJUgeRld0JRTX37n/Y +tIB0MaarLeH+F8D17aEFyTVerbDAvvbRdxEM03VLlawukPs5MrB+iom2/dlZcpl+h bpTW2KEokm1pmKvgJWPly6i5jF++JwOa9KeU6KHBge2OuemX686I90JYK6czEPyNwK Dw+xr+GxacmF9F3UfLcOnTkxyrijFi6RirbNhn2SxZYj8fO7g+tD2fI+jhCeB3e56R MhoOppnCs/qgA== Date: Tue, 20 Feb 2024 15:00:50 +0000 From: Simon Horman To: Siddharth Vadapalli Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xiaoning.wang@nxp.com, wei.fang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH net] net: phy: realtek: Fix rtl8211f_config_init() for RTL8211F(D)(I)-VD-CG PHY Message-ID: <20240220150050.GO40273@kernel.org> References: <20240220070007.968762-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240220070007.968762-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_070056_634845_EFEFDB48 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 20, 2024 at 12:30:07PM +0530, Siddharth Vadapalli wrote: > Commit bb726b753f75 ("net: phy: realtek: add support for > RTL8211F(D)(I)-VD-CG") extended support of the driver from the existing > support for RTL8211F(D)(I)-CG PHY to the newer RTL8211F(D)(I)-VD-CG PHY. > > While that commit indicated that the RTL8211F_PHYCR2 register is not > supported by the "VD-CG" PHY model and therefore updated the corresponding > section in rtl8211f_config_init() to be invoked conditionally, the call to > "genphy_soft_reset()" was left as-is, when it should have also been invoked > conditionally. This is because the call to "genphy_soft_reset()" was first > introduced by the commit 0a4355c2b7f8 ("net: phy: realtek: add dt property > to disable CLKOUT clock") since the RTL8211F guide indicates that a PHY > reset should be issued after setting bits in the PHYCR2 register. > > As the PHYCR2 register is not applicable to the "VD-CG" PHY model, fix the > rtl8211f_config_init() function by invoking "genphy_soft_reset()" > conditionally based on the presence of the "PHYCR2" register. > > Fixes: bb726b753f75 ("net: phy: realtek: add support for RTL8211F(D)(I)-VD-CG") > Signed-off-by: Siddharth Vadapalli Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel