From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48FE0C48BC3 for ; Wed, 21 Feb 2024 06:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w9eRAV6+pO7wfOUCyCExdJgZCFqBk5v3E2u7V7WrFkg=; b=S/7TSzNlLTb+lT 0bDyooTU4eXYYfiYmCJtHA6Jel+ehSLs89nLIJUSUQeZn2IY5UCu26vygLecZ11+r90ETLLV3cMY1 nyakjlRHKEpM2JKDCWXkIjpl3UB/KvcD5vtL7JhiY3BTK+iRM6/QKU4IfTrD28xeUwMCLw9Wyius1 ACT54gVxLNlH58gmT9Vlsqg91houFnZrXD84b1BTSPC64b2aCfA6qgsjqfWHylZOwPI0XT2wg4r7p oN5B48xKmHaOBOqRksci4EHxbS4hbBHL1BU0JNnfRNBsqjDQXNeXLoknj05AISgPHpIZ9aJs1HHzB 6WKbOrOh16xnnIfJqahw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcgGH-0000000HMJG-14Bb; Wed, 21 Feb 2024 06:39:21 +0000 Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcgGE-0000000HMIu-2uOt for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 06:39:20 +0000 Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-dc74435c428so5864234276.2 for ; Tue, 20 Feb 2024 22:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708497556; x=1709102356; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C/kx0MMgzpebCxflYE7VD+ZZKlLv7LbIjirao9DRCq0=; b=Md8/VjHFIbvd8Ni8Af93lop/J8MyceW2OZowD4AxgcbqzEx+px/o4sInMWxYAzprc8 wPNm57LJIs6B5IJnx66P3cOrYrgbXVkkD1VCNR3NALvX4M7rMYGng2S42DFoB+/NL9IK VpG/zVua+qSRL5OzpAxccfsYo1AQYopvVWjWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708497556; x=1709102356; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C/kx0MMgzpebCxflYE7VD+ZZKlLv7LbIjirao9DRCq0=; b=pXWA8unXRJj0vLCmt5plOiYtN5PfOzjV4zYg1sUPC0l1f6kfV+kar5QddKsTQgakWR L//+VBSkUw9VxA1KeCT8Y/crXGE+P3LeVMyzSK7/zHAPgtOQDMOY0aWiEJC7lZJ/tj36 Kdq1MoTKR7YFX5gs7v7CGve6stP6CKpq6lx3sNL8Dp/37GcxRu0lDtAr7238mSgfYUyO jQsuOul5TvTvb7NiHMA6Bmygnuu7zfaJRb3fbmFyBSBMp6LASxWwkeLN3dxLQONizdZ8 PZtM82Gcl4+SwJAa+H9Ncb9mspoyi+n9Uzr3wwa/X66yOVJaCCL+memhqzwdrq65SwwH EVxA== X-Forwarded-Encrypted: i=1; AJvYcCVCxx0Pw5kUoe2JY2X3OJ5HHwXho0/IOniDs8gFcRUdWoHL1bmjZJogMCOLTsggcAulfso+75YKDwWh+u+OUxjuRUcRGyggtvPWqgQey3ahYHz03Yg= X-Gm-Message-State: AOJu0Yy71crjZP+n22m2dKpmOjiVhK3xCa7wXCq3bvaeYVKAQCzy89ON /U/wmJ5hI6wgbZf4SX/cqZk8f1MqxaVAbN2pr0EDB6T9dQ7LpXXjh861A9fTyA== X-Google-Smtp-Source: AGHT+IEDBNlgi9fOUdqyWnl61n6BJWPOOAV7EQV0qVdwgnub+GBgpaz0jIe8FwPV8Mtvha7IwXR11Q== X-Received: by 2002:a25:ab27:0:b0:dcb:c0ea:6abc with SMTP id u36-20020a25ab27000000b00dcbc0ea6abcmr13836899ybi.64.1708497556402; Tue, 20 Feb 2024 22:39:16 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id i5-20020a639d05000000b005dc4829d0e1sm7729634pgd.85.2024.02.20.22.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:39:16 -0800 (PST) Date: Tue, 20 Feb 2024 22:39:15 -0800 From: Kees Cook To: Russell King Cc: Mark Brown , Ard Biesheuvel , Wang Kefeng , Andrew Morton , Ben Hutchings , linux-arm-kernel@lists.infradead.org, "Russell King (Oracle)" , Hugh Dickins , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed() Message-ID: <202402202235.A77C9AD@keescook> References: <20240123011238.work.301-kees@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240123011238.work.301-kees@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_223918_778801_572CCA15 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 22, 2024 at 05:12:38PM -0800, Kees Cook wrote: > Under PAN emulation when dumping backtraces from things like the > LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU) > would happen because of dump_instr() attempting to read a userspace > address. Make sure copy_from_kernel_nofault() does not attempt this > any more. > > Reported-by: Mark Brown > Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1] > Suggested-by: "Russell King (Oracle)" > Cc: Russell King > Cc: Ard Biesheuvel > Cc: Wang Kefeng > Cc: Andrew Morton > Cc: Ben Hutchings > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Kees Cook Russell, do you mind if I carry in my tree the 3 ARM patches I sent? They're mostly pretty trivial, and they've been in "Incoming"[1] for 2 weeks but haven't shown up in -next yet. I'd really like them to get some soak time, and for them to reach the v6.9 merge window in time. Please let me know what you think. :) Thanks! -Kees [1] https://www.arm.linux.org.uk/developer/patches/section.php?section=0 -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel