Re: [PATCH v5 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property

Conor Dooley
2024-02-09T17:42:19Z

[-- Attachment #1.1: Type: text/plain, Size: 2320 bytes --]

On Wed, Feb 07, 2024 at 12:22:48PM -0800, William Zhang wrote:
> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
> board boot strap for broadband board designs because they do not specify
> ecc setting in dts but rather using the strap setting.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>

If Miquel is happy with this, then I am too.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>
> ---
>
> Changes in v5:
> - Update the description for this ecc strap property
> - Add check to make sure brcm,nand-ecc-use-strap and
> nand-ecc-strength/brcm,nand-oob-sector-size can not be used at the
> same time
>
> Changes in v4:
> - Move ecc strap property to this separate patch and remove some
> non-binding related text from the description
>
> Changes in v3: None
> Changes in v2: None
>
> .../bindings/mtd/brcm,brcmnand.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> index 6a717bcedfd3..52a4c993b6f1 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -146,6 +146,13 @@ patternProperties:
> layout.
> $ref: /schemas/types.yaml#/definitions/uint32
>
> + brcm,nand-ecc-use-strap:
> + description:
> + This property requires the host system to get the ECC strength
> + and step size from the SoC NAND boot strap setting. This is a
> + common hardware design on BCMBCA based boards.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> unevaluatedProperties: false
>
> allOf:
> @@ -195,6 +202,18 @@ allOf:
> required:
> - interrupt-names
>
> + - if:
> + patternProperties:
> + "^nand@[a-f0-9]$":
> + required:
> + - brcm,nand-ecc-use-strap
> + then:
> + patternProperties:
> + "^nand@[a-f0-9]$":
> + properties:
> + nand-ecc-strength: false
> + brcm,nand-oob-sector-size: false
> +
> unevaluatedProperties: false
>
> required:
> --
> 2.37.3
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]