Re: [PATCH v5 11/12] mtd: rawnand: brcmnand: exec_op helper functions return type fixes

Dan Carpenter
2024-02-21T06:16:55Z

On Tue, Feb 20, 2024 at 11:02:40AM +0100, Miquel Raynal wrote:
>
> william.zhang@broadcom.com wrote on Wed, 7 Feb 2024 12:22:56 -0800:
>
> > From: David Regan <dregan@broadcom.com>
> >
> > fix return type for exec_op reset and status detect helper functions
> >
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Closes: http://lists.infradead.org/pipermail/linux-mtd/2023-December/102423.html
> > Fixes: 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op implementation")
> > Signed-off-by: David Regan <dregan@broadcom.com>
> > Signed-off-by: William Zhang <william.zhang@broadcom.com>
> > Reviewed-by: William Zhang <william.zhang@broadcom.com>
>
> By the way, a Cc: stable tag might be useful as otherwise you may leak
> an error code in a status value (which is a bug). And move this patch
> first in your series so we're sure it does not conflict with any of the
> other patches and can be backported more easily.

The original commit 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op
implementation") is not in stable so we should be okay on this.

regards,
dan carpenter