Re: [PATCH v5 11/12] mtd: rawnand: brcmnand: exec_op helper functions return type fixes

Florian Fainelli
2024-02-21T16:01:30Z

[-- Attachment #1.1: Type: text/plain, Size: 1825 bytes --]

On 2/21/2024 12:32 AM, 'Miquel Raynal' via BCM-KERNEL-FEEDBACK-LIST,PDL
wrote:
> Hi,
>
> dan.carpenter@linaro.org wrote on Wed, 21 Feb 2024 09:16:31 +0300:
>
>> On Tue, Feb 20, 2024 at 11:02:40AM +0100, Miquel Raynal wrote:
>>>
>>> william.zhang@broadcom.com wrote on Wed, 7 Feb 2024 12:22:56 -0800:
>>>
>>>> From: David Regan <dregan@broadcom.com>
>>>>
>>>> fix return type for exec_op reset and status detect helper functions
>>>>
>>>> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
>>>> Closes: http://lists.infradead.org/pipermail/linux-mtd/2023-December/102423.html
>>>> Fixes: 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op implementation")
>>>> Signed-off-by: David Regan <dregan@broadcom.com>
>>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>> Reviewed-by: William Zhang <william.zhang@broadcom.com>
>>>
>>> By the way, a Cc: stable tag might be useful as otherwise you may leak
>>> an error code in a status value (which is a bug). And move this patch
>>> first in your series so we're sure it does not conflict with any of the
>>> other patches and can be backported more easily.
>>
>> The original commit 3c8260ce7663 ("mtd: rawnand: brcmnand: exec_op
>> implementation") is not in stable so we should be okay on this.
>
> Right.
>
> However please send again this patch quickly so I can queue it up
> before the rest of the series.

Also just to be clear, please do not omit the Fixes: tag, even if the
commit being fixed is not yet in any released kernel, it is valuable to
have that information, for say, people who might consider backporting
features into specific kernel versions. The stable team's tooling should
be able to figure out that it is not required to pick up that fix since
the offending commit is not in a released kernel yet anyway.

Thanks!
--
Florian

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]