From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 998E9C48BEB for ; Thu, 22 Feb 2024 08:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PV9VYQS0K5I7rwVLGjRRXI9L2rzx3uRWa2+Ae/AWADQ=; b=a0RHesCovRqBBOgAQsEyf+j2Rc h1syQCqffEJpzPBQEbv+fZrhJg9Oq3Gb/VAMDbE6TqukYwLlxhMIzgafkJe/jueFiM8hEmvQu6Gho BtgN6MYS6dPCMagqoczWi6XkYa1SYAdXXjl3uMBrC1+z8IoqZ+iTMZZ6Lw9nzTcqxm54xI4kVABPL /4+L+OmGLBZX4iCuGnBtU+UFRFwKKhe5DBVe7C45Acp5FZxzfG8xxoRBF/geSmhzdMBDiodng17Tn k3d8p6aUwfUFUjdX4/7w3uh+uMGQagabphCfHE4W8LgNJQWlHCZ7as94HpNilK4Dsk6MuZ6lsKkZZ rqtc8+JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4sV-000000048IW-2jzG; Thu, 22 Feb 2024 08:56:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4sS-000000048H9-3khK for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 08:56:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E36576172A; Thu, 22 Feb 2024 08:56:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 299CFC433F1; Thu, 22 Feb 2024 08:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708592178; bh=AuwUkPFckUyTiGUSQ4l57RJbPEcUt9jkQMJMV60bK+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKwLzXgwnUQISRQN8b0HiG9097CDoF463ushTc7nbxWeS9jfqUeZHgzPJl+YLzmaX Ejt7GVR1OzTzk6rAkRvAP8C4uIGk94cARAMTsBDuXQGniOC04ZZvpCaJFRtld4LRz2 Hy3LffLQ3VRRjTsf7GNSPBZQpU66xKtrY1sdP6a33jg0mg6t9NQgCoat3ijnfhUJOR rC7m39ROxUNPH79PIhzw3f4YZX1qnq3e8gAm944pfHm7l6/WfaMp41MM69uNNwaaU4 lG6SSPykpCXwAepmR8FJeW+tyMBFnOL7QDk1+/f0HYDimJYpjs54LP9X5L0ZZlXQyQ ckODHMOawaI6A== Date: Thu, 22 Feb 2024 08:56:13 +0000 From: Conor Dooley To: Dharma Balasubiramani Subject: Re: [PATCH v3] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema Message-ID: <20240222-stiffly-squeeze-b4ec2b49a4fe@spud> References: <20240222035158.195265-1-dharma.b@microchip.com> MIME-Version: 1.0 In-Reply-To: <20240222035158.195265-1-dharma.b@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_005625_044218_71DCC28B X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, Conor Dooley , krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2515562607389743131==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2515562607389743131== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lHpyoJFoRpJTBuEw" Content-Disposition: inline --lHpyoJFoRpJTBuEw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > diff --git a/Documentation/devicetree/bindings/interrupt-controller/atmel= ,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/atmel,ai= c.yaml > new file mode 100644 > index 000000000000..0d51bd78bf2b > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.ya= ml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/atmel,aic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Advanced Interrupt Controller (AIC) > + > +maintainers: > + - Nicolas Ferre > + - Dharma balasubiramani > + > +description: > + The Advanced Interrupt Controller (AIC) is an 8-level priority, indivi= dually > + maskable, vectored interrupt controller providing handling of up to one > + hundred and twenty-eight interrupt sources. > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: atmel,at91rm9200-aic > + then: > + properties: > + atmel,external-irqs: > + minItems: 1 > + maxItems: 7 > + else: > + properties: > + atmel,external-irqs: > + minItems: 1 > + maxItems: 1 When there's property restrictions being applied, move the allof down to... > + > +properties: > + compatible: > + enum: > + - atmel,at91rm9200-aic > + - atmel,sama5d2-aic > + - atmel,sama5d3-aic > + - atmel,sama5d4-aic > + - microchip,sam9x60-aic > + > + reg: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 3 > + description: | > + The 1st cell is the IRQ number (Peripheral IDentifier on datasheet= ). > + The 2nd cell specifies flags: > + bits[3:0] trigger type and level flags: > + 1 =3D low-to-high edge triggered. > + 2 =3D high-to-low edge triggered. > + 4 =3D active high level-sensitive. > + 8 =3D active low level-sensitive. > + Valid combinations: 1, 2, 3, 4, 8. > + Default for internal sources: 4 (active high). > + The 3rd cell specifies irq priority from 0 (lowest) to 7 (highest). > + > + interrupts: > + maxItems: 1 > + > + atmel,external-irqs: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: u32 array of external irqs. =2E..here. Both work, but seeing the restrictions before you see any of the properties is not the most understandable. Cheers, Conor. > +required: > + - compatible > + - reg > + - interrupt-controller > + - "#interrupt-cells" > + - atmel,external-irqs > + > +unevaluatedProperties: false > + > +examples: > + - | > + interrupt-controller@fffff000 { > + compatible =3D "atmel,at91rm9200-aic"; > + reg =3D <0xfffff000 0x200>; > + interrupt-controller; > + #interrupt-cells =3D <3>; > + atmel,external-irqs =3D <31>; > + }; > +... >=20 > base-commit: 4f5e5092fdbf5cec6bedc19fbe69cce4f5f08372 > --=20 > 2.25.1 >=20 --lHpyoJFoRpJTBuEw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdcMLQAKCRB4tDGHoIJi 0iOsAP9m+bcNCJqOinLb0AteBdy7mXRGcB1XbQsicq2MgSjpjQD+MssNTCXfQ6vt gzfH0TbEBfWso1aovIY/r1JDSDcpoA8= =wd3E -----END PGP SIGNATURE----- --lHpyoJFoRpJTBuEw-- --===============2515562607389743131== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2515562607389743131==--