From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E2B1C48BF8 for ; Thu, 22 Feb 2024 08:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N4WUBMCM9QoRkCkeOAjPF03knv9dFJmEPN8rLkd1O1w=; b=h8HCG14uIBtayK jjHi2jzh8xGQ8Sym7W/hS/mQdUifPlBggKoku9XmvZvAPwGZwtKHZM2F0XsJD3fRxFsO3pvNn+btN dYS58wsjGZRN6z1k8h5AaiY3U3pqtX3uGBovPB/6EPBBVK2NVb4ffXoy1hTHrIpiAvW637wodDLM0 AWZ6zYuyadRxFusR4QPl6wIDyQGLyCy3LTLpvLlU2vWmisIWEgL6PmYXc+vsgxl0eIEw3U9DbFFFE 92HpfU7+95QrFXOaG/UMwSdGQbQP2Zp0ilkEpYCcngEL2E4aj4BoihVavx7fe8pd4aFTTWxuy0moS IDYIPe5ML1jjePBCiERw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4Ia-00000003ybO-1u1s; Thu, 22 Feb 2024 08:19:20 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4IW-00000003yag-3l7Y; Thu, 22 Feb 2024 08:19:19 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C1AA7240002; Thu, 22 Feb 2024 08:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708589952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SC+AXNTWiEuwN1cNmfVZqIbghyjFU4JFmVJRHzXCRxg=; b=kBRuk0xGHshBTSwtsfyEB3UzGAtnHGhhjHF7yXUTTHNfKcQ92o+uWXHcNhm7IOxK12n8KW Hkp6KV0izPKXCGL5kEUMlyZzWkOH+uAXK61frnJvQt78kry6/DLNKh8dJ6xQjbHuNZQG/Z npHWymGqlxRIVI/NFSBhF1cgX8WipJz7LP98TaHNqaX+yZT81B2n+LbFpMCZZkcV2PhjB4 3dFMpHWuNUEWvsYGeSp7g8X6dsNJECm1eI/mJKM/B7Oy7wnpc3ivRfAibD+Lg67aOEcBLP i73UdigSFwKrcbgcBiUohi0Gro+2KW3KQKCFuWJIg4UZ31zeUJ6raSx8wDLq1Q== Date: Thu, 22 Feb 2024 09:19:06 +0100 From: Luca Ceresoli To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, aford@beaconembedded.com, Lucas Stach , Marek Vasut , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 5/6] arm64: dts: imx8mp: add HDMI display pipeline Message-ID: <20240222091906.1bd13c03@booty> In-Reply-To: <20240218041649.1209173-6-aford173@gmail.com> References: <20240218041649.1209173-1-aford173@gmail.com> <20240218041649.1209173-6-aford173@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_001917_373894_2A419096 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adam, On Sat, 17 Feb 2024 22:16:43 -0600 Adam Ford wrote: > From: Lucas Stach > > This adds the DT nodes for all the peripherals that make up the > HDMI display pipeline. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > Tested-by: Marek Vasut > Tested-by: Luca Ceresoli > --- > V5: No change > > V3: Re-ordered the HDMI parts to properly come after irqstree_hdmi > inside AIPS4. Change size of LCDIF3 and PVI to match TRM sizes > of 4KB. > > V2: I took this from Lucas' original submission with the following: > Removed extra clock from HDMI-TX since it is now part of the > power domain > Added interrupt-parent to PVI > Changed the name of the HDMI tranmitter to fsl,imx8mp-hdmi-tx > Added ports to HDMI-tx > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 94 +++++++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index cbb15ded4a74..433ea4ae6a16 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1940,6 +1940,100 @@ irqsteer_hdmi: interrupt-controller@32fc2000 { > clock-names = "ipg"; > power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_IRQSTEER>; > }; > + > + hdmi_pvi: display-bridge@32fc4000 { > + compatible = "fsl,imx8mp-hdmi-pvi"; > + reg = <0x32fc4000 0x1000>; > + interrupt-parent = <&irqsteer_hdmi>; > + interrupts = <12>; > + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_PVI>; After a small annoyance in my testing I realized here there should be: status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + pvi_from_lcdif3: endpoint { > + remote-endpoint = <&lcdif3_to_pvi>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + pvi_to_hdmi_tx: endpoint { > + remote-endpoint = <&hdmi_tx_from_pvi>; > + }; > + }; > + }; > + }; > + > + lcdif3: display-controller@32fc6000 { > + compatible = "fsl,imx8mp-lcdif"; > + reg = <0x32fc6000 0x1000>; > + interrupt-parent = <&irqsteer_hdmi>; > + interrupts = <8>; > + clocks = <&hdmi_tx_phy>, > + <&clk IMX8MP_CLK_HDMI_APB>, > + <&clk IMX8MP_CLK_HDMI_ROOT>; > + clock-names = "pix", "axi", "disp_axi"; > + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_LCDIF>; Here as well: status = "disabled"; With those fixed you can add my: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel