From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43A7FC54788 for ; Thu, 22 Feb 2024 12:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KF2Dd0XX7l9uqU5fJhLHf3Aty04uqZk7oLx9m6RWaCo=; b=zTEW9CkVuQO9hG p3L3VXR6y2cOnqDDdMkWj8ZXPSt7Tpyq97OaAoJmU1NF0FmMWKqd10l7HenUuZOVkxWat8Bm5U4zV ShsCmsOsfCgqIvOk+A+R7vZ6X7ayrGD+cR4OYiqlc66fKJ8STbU9jojbckSSiE0XiuISb6kbl8D86 /KkMkXA9vrLr47fwLDwGH95wpw8d0rs44WpCcYhBtAiLR/nLk0o4eWLrxjB0rxwm6bU8lo7RiOBhN J4dFdaMQW9WAcSeHyeksU72n4SRFUjTOTmSQCXRVTmX3O3RMV2bdNeyyz81aFAY9YGGNvw4C5BEv5 b+dt+bSGKEpqeH9Vgtig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd87H-00000004nyZ-0mco; Thu, 22 Feb 2024 12:23:55 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd87E-00000004nws-2WU9 for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 12:23:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C3646CE2262; Thu, 22 Feb 2024 12:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52A4BC433F1; Thu, 22 Feb 2024 12:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708604630; bh=fXftZTVW/nwvXX0LAYCCLyy5b88uDduzlIcQF1WbDJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ToZBtbdGSt5Vu5AvcI1jj5zV/j6Cv4LyR63tG1ht77yAd8/7nBtOuYhrFZoowNset XR6fsxdpGY686h/Ib7I8JzOc01ZuZ9liV5MYVEZ3i74XO8wXRcRBUA6mHuqUz15+0I RSRjp52aH/vXUQbhiKZCZEzSGRUpDycGCfDawMu4qwDLSTHJX86Xjql2gHQWYDHvfJ NPJX5EivYXpndeL4eQ3Bpr/dS/PEkFanch1dzKVqIxgeoo+pxyGHzadKZKlFCN70BW 3+omj34h0/55eP2dddORjGu7nXruWkB38HF0bQmEzFN5UB2xcPydCwJp9h7nAN2mgE 4ru/raDSwju/A== Date: Thu, 22 Feb 2024 12:23:41 +0000 From: Will Deacon To: Xu Yang Cc: Frank.li@nxp.com, mark.rutland@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, linux-imx@nxp.com, mike.leach@linaro.org, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, adrian.hunter@intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v4 4/6] perf: imx_perf: add macro definitions for parsing config attr Message-ID: <20240222122341.GC8308@willie-the-truck> References: <20240131055811.3035741-1-xu.yang_2@nxp.com> <20240131055811.3035741-4-xu.yang_2@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131055811.3035741-4-xu.yang_2@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_042352_833382_37C89102 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 01:58:09PM +0800, Xu Yang wrote: > The user can set event and counter in cmdline and the driver need to parse > it using 'config' attr value. This will add macro definitions to avoid > hard-code in driver. > > Signed-off-by: Xu Yang > > --- > Changes in v4: > - new patch > --- > drivers/perf/fsl_imx9_ddr_perf.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c > index 85aaaef7212f..94041f06c152 100644 > --- a/drivers/perf/fsl_imx9_ddr_perf.c > +++ b/drivers/perf/fsl_imx9_ddr_perf.c > @@ -52,6 +52,11 @@ > #define NUM_COUNTERS 11 > #define CYCLES_COUNTER 0 > > +#define CONFIG_EVENT_MASK 0x00FF > +#define CONFIG_EVENT_OFFSET 0 > +#define CONFIG_COUNTER_MASK 0xFF00 > +#define CONFIG_COUNTER_OFFSET 8 Can you move this patch earlier, please, so that the imx95 support can use these new definitions immediately? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel