From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07AA3C48BF8 for ; Thu, 22 Feb 2024 15:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w4w4Tx+1l5MmJ7qVeymQ1B/i2uZPBAM4Y2NhTezUF7g=; b=oUVixywaVFcPUs VlmZOaCyQMSUSbYAJTEJZ+yXjsSnGwoLkCcNUi6WSRhOS6ckhlh0rR69/504r2R4OGtzm6YfA8xlD i1jFBNcTezbb6eW4l9Z/uWjTpAWZ7B7+cO7vhFasN5GyfDH+wIem7t2/pAyyiz0rqAxrjiPvVQjgf OpUu+a31tiBH1nBvBrezxyxwKLgjduoCR7IfSQgd500sPQhWYWuD0uheUeRFVkNw3bKOPfuz+n1iu iE//jiDbY6kXWQrFopzD36D0T788NNYk0XQA4dY6a4TqZ3PYnefdlGNS4nRhv8x8agvocw0M9lyK9 e0mbgOt8cDvtVdLMhChg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdBDw-00000005SRL-3hPx; Thu, 22 Feb 2024 15:43:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdBCt-00000005Rhe-01ZC for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 15:41:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 04360CE21A0; Thu, 22 Feb 2024 15:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC409C43390; Thu, 22 Feb 2024 15:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708616512; bh=nqgg4xZrpKp12QvERL+ahDDnpkHl69a5C+qcajcYEFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qk+5wVMZwcgL9wZU/PM2XA8D4i5s/MQ8EsK+MdEP0+gUzahW9vw3zydeagdg4t2IO YcyGJAZpPQ9mMM4AlW5EfYuZEjoIu7wcU4zyfXIedmQXcq8u49tRGFb3Fq4SJ2ZSuz 66qQK9SIRNCJqevPFxQUt84yUxi+k6aQe/Pmu9oRRX0WIFFotbeHGnBgM0KwgpGmx6 OLlU1VoAYHsRPauGQevhHCQCe6io1q2FPZ8ypI1P2m2KOHJy5N8JH5mRIRCJGK7ybv QSvu39MYUPdBnj0/Ak3NgW3zQqfmJcLJcbZMEUgtGSMWveI6DShDKUyxc9hJvc3WSz HD6fuDr4fX6Xw== Date: Thu, 22 Feb 2024 15:41:47 +0000 From: Will Deacon To: Anna-Maria Behnsen Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/10] arm64/vdso: Use generic union vdso_data_store Message-ID: <20240222154146.GA8949@willie-the-truck> References: <20240219153939.75719-1-anna-maria@linutronix.de> <20240219153939.75719-6-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240219153939.75719-6-anna-maria@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_074155_412679_78AB9352 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 19, 2024 at 04:39:34PM +0100, Anna-Maria Behnsen wrote: > There is already a generic union definition for vdso_data_store in vdso > datapage header. > > Use this definition to prevent code duplication. > > Signed-off-by: Anna-Maria Behnsen > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/kernel/vdso.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c > index 5562daf38a22..89b6e7840002 100644 > --- a/arch/arm64/kernel/vdso.c > +++ b/arch/arm64/kernel/vdso.c > @@ -69,10 +69,7 @@ static struct vdso_abi_info vdso_info[] __ro_after_init = { > /* > * The vDSO data page. > */ > -static union { > - struct vdso_data data[CS_BASES]; > - u8 page[PAGE_SIZE]; > -} vdso_data_store __page_aligned_data; > +static union vdso_data_store vdso_data_store __page_aligned_data; > struct vdso_data *vdso_data = vdso_data_store.data; > > static int vdso_mremap(const struct vm_special_mapping *sm, > -- > 2.39.2 Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel