From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0CD9C48BF8 for ; Thu, 22 Feb 2024 17:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6h3VDj5+pGnUf8wxovRkfYGcINBvjnMWEtWfdSDlboc=; b=B+BRpwRe4JBMke VAxEMwoPc8ltg1b5X5MgpD/+GBugfa/ccx8EJQiVQXj8ICp8P6H+6N9RlONKL66ZgZ0XQkcMsvlmM kU5SZgsS66pbFUoMe4AE0PXyXC70RpES/khapnL+dCGfyJG0jcHoQBjuacGnzknSBdVFWRJYJPmka VxsWBHVBM3FAOHmw9g9nyF7iR4fmFT9UlcoWwaT3hyVb+H6jhs7mcdcf02OBWgnrAy7lEwgO5oZtN pLMS7/bw6oDiwfYhAj7Zfr/ssDF4gTYxwhf2lVZAt3W7yKFbokyI7HpGu58fwu2o7wdxyeFzMQoBD UQNv0VaavVNZcnwNq83g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdD3v-00000005pvE-2yG2; Thu, 22 Feb 2024 17:40:47 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdD3i-00000005pn4-1nL0 for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 17:40:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 57E97CE2837; Thu, 22 Feb 2024 17:40:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEC5EC433F1; Thu, 22 Feb 2024 17:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708623629; bh=Lxy35IxJA9zLvTR8+MsDa6Dx8mvc1F85DmPcsyHp79k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tq5dStIU8qojXF82Ht4ZCLziIEYJ9yTyQ1u39dSPsT+i+TRzsjEJe6lp2jq94XOY7 SJ42lcAUkhry7M4q2cghFNZxC2j/A4Im2Y0Lbqpl+cWNp8/BhexwczuVMqqBUpYidd lCZiWZri4Xx/3qV7GGGOjG/IFHQmZ74GPBHwKa+jvB4BtUkMX0LR4DlsHIuXtxuVRS ZyKtK/HvaizyYhmSmife6wDceovrxEgliDdAjkxQmypLu3MZkPnnvteWfjpfTaRCmj Uo6m94srsPcqpRcXS7hTiKNB+8nPaVqWAE7scFyu3+sDmHNeXL9kkUTTYKfokgF6vq 4299yxf883fxw== Date: Thu, 22 Feb 2024 17:40:22 +0000 From: Will Deacon To: Robin Murphy Cc: Jason Gunthorpe , iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Lu Baolu , Jean-Philippe Brucker , Joerg Roedel , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Mostafa Saleh , Zhangfei Gao Subject: Re: [PATCH v5 02/17] iommu/arm-smmu-v3: Consolidate the STE generation for abort/bypass Message-ID: <20240222174022.GA9488@willie-the-truck> References: <2-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> <2ca7f64e-a9e3-4d47-b04f-726c86223fd6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2ca7f64e-a9e3-4d47-b04f-726c86223fd6@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_094034_806141_24B61CA0 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 05:27:09PM +0000, Robin Murphy wrote: > On 06/02/2024 3:12 pm, Jason Gunthorpe wrote: > > +/* > > + * This can safely directly manipulate the STE memory without a sync sequence > > + * because the STE table has not been installed in the SMMU yet. > > + */ > > static void arm_smmu_init_bypass_stes(struct arm_smmu_ste *strtab, > > This name is long out-of-date - if we're refreshing this area, please rename > to something relevant to what it actually does, e.g. s/bypass/initial/. > > Although frankly I also think that at this point we should just get rid of > the disable_bypass parameter altogether - it's been almost entirely > meaningless since default domain support was added, and any tenuous cases > for wanting inital STEs to be bypass should probably be using RMRs now > anyway. We probably can't drop it for SMMUv2, but I'd be more than happy to do so on SMMUv3. I think one of the reasons for keeping it in the new driver was that the Arm Fast Model used to need it for legacy virtio devices that were downsteam of the SMMU but couldn't advertise F_ACCESS_PLATFORM. Was that fixed? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel