From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BE51C54791 for ; Thu, 22 Feb 2024 18:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+x+H9KoMS8H41Sa+dEFKvyFPhvrCG2KLfFFsbgs/zBo=; b=nC4lmFzHau70PJ fpoCr1KcEJPprlYvEscTZvxAmS6/QNA4Xh/ar+Bvpmj6ppd0i1NDJGq7Mq9cvWbFctBJXbouqkB8l 6B5xRkuW0TATfb7LnFwFYxL5OaN5IIut0238BCGnLS6ikR+Wq4Q1HBEcJ/JKEFLOq2h19gkq/UiMJ kWIlhULIB2RsxK1eAOltipQET933XT0N2R87nqc8hAiMYVtHZwbQhv2XLn7Bcl38MDf89IKpzfPDZ ffxxJN+b0vGtb9c2pqADbDIsa327Hg7G8xct6oQERA2Hw3lesJO8WxTysg+Vt0n8I1Wb0UFNAOwYq /mHWH5AIFMROF5sEwFIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDUS-00000005vu4-1V3c; Thu, 22 Feb 2024 18:08:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdDU9-00000005vna-2BsC for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 18:07:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0AF63614E9; Thu, 22 Feb 2024 18:07:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65223C433F1; Thu, 22 Feb 2024 18:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708625270; bh=h1lolQG3CknY7raZfk8+CNEwZOWLkLis21EvkQNNH18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fQMEjuoO6gwmb3k8WiqH5UwzucSEhfh1r71oCRcNYrP6JbnL97B8L6P4QrT4YZ0U9 Ty5lQxNqtddENVrBQDlP9fUngFAJxg8iq4fP9uG9pFrW74gDOWK/oBqzplz1x3i8LK IxYzPmTRyA04u7www9yQGNfsuWAO4cKvqmEn6mmbuiV+mgNu5m1aPl/i6QmK3U5spg k7LM51yXpGR1g2TPQ/ivUw8dr6up7ISMvCdNt8symFKvdy9KB/VsySfIshn5hUn0vp jJZIduXQJWgHgXseTe4cQ5ZBkpxELAhBYArpZx4nYNGvm3aj+Yhu8fBVsHMTGX+4yo BBo5e5t2IW8pA== Date: Thu, 22 Feb 2024 11:07:47 -0700 From: Rob Herring To: Conor Dooley Cc: Dan Scally , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240222180747.GA3518860-robh@kernel.org> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240214142825.GA7873@pendragon.ideasonboard.com> <20240214-velcro-pushy-0cbd18b23361@spud> <20240215110205.GD7873@pendragon.ideasonboard.com> <20240216132755.GA20376@pendragon.ideasonboard.com> <20240216-caboose-poison-3052a4bb9eaf@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240216-caboose-poison-3052a4bb9eaf@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_100754_036274_E26D1F97 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 16, 2024 at 07:07:58PM +0000, Conor Dooley wrote: > On Fri, Feb 16, 2024 at 02:45:31PM +0000, Dan Scally wrote: > > > > > > > > > + - description: ISP AXI clock > > > > > > > > + - description: ISP AHB-lite clock > > > > > > > These two other clocks look good to me. > > > > > > > > > > > > > > > + > > > > > > > > + clock-names: > > > > > > > > + items: > > > > > > > > + - const: vclk > > > > > > > > + - const: aclk > > > > > > > > + - const: hclk > > > > > > Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the > > > > > > tree clock names you've provided - they're all clocks, so having "clk" > > > > > > in them is just noise :) > > > > > As far as I understand, the names proposed by Dan come directly from the > > > > > IP core documentation. > > > > This is the case, but I do take Conor's point that more descriptive names might be nicer - if I'm > > > > honest I just didn't think about it particularly given "Xclk" is such a common name for them > > > > already, but having been poked into thinking about it I do agree. > > > Isn't the usual practice in DT bindings is to name GPIOs, clocks and reset > > > signals based on the hardware documentation ? > > > > > > Ah - I don't know honestly. If that's so then yeah - these are the names the documentation prescribes. > > If a direct doc match is what you're going for, then sure, keep it. pclk, aclk, and hclk are generally the names used for APB, AXI, and AHB bus clocks, so I'd stick with them. Though we also have cases of the bus names used... Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel