From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BC41C54798 for ; Fri, 23 Feb 2024 14:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oSo5SeU8DtmVSzsF8ibpH11Kg5KSGAkDMbAyQjccKk0=; b=GIbpN9kYv6AQqu i7bGPBUNKVdrOYZUN8gm2TSMuw0RB3XX9kOFoX7/pGB6lpuXPV2l+JaTrngSn+fGzp8/LvVGCZxb4 s/YbMSHSZKknmtFR3HriBahFT2Imdl4lp0Vwyh4RM8kpasQslu7DVCWF0UoBlFn1Re/j5XkwklmmF PmJ1PC0WMR7Qj1lx2L2Y0WlrbkBmFEJtMA3MG2122xUzCCPFiCIUnWdBKSG47EHQfcM9q1k2mJrhR h5lfkgSZ5gnO6VaOWVG0/nUvizEw57H0d2h4h48D5RK9JhJlyy6nyMT4QgFQdpt3qVFPZLI3M0wP0 okCGuZv/+1YrKaRsmkcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdWMB-00000009ijL-3ayo; Fri, 23 Feb 2024 14:16:55 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdWLo-00000009iga-24pk for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 14:16:45 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C3679B6; Fri, 23 Feb 2024 15:16:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708697777; bh=TqXkdzLDVhLjmfkgDlfUzyaXzwUQa8U/VRQmUdvZQtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mCiJFOhcg1pDJeW8TqCLEovKv/psfDvLsKXVB9jlq6Ck4VK1tsU1gAvZu2N6AUvor Nn8xHsHJKke7lTArFiT7rgFdwUv4WsjyTcsSQ8LY9GPPNZGAMRLPYPdxRnmVKSjj48 2VeqZMrAw68xnHAUitgrPuqN9Vzo0TPwmEN0AgjM= Date: Fri, 23 Feb 2024 16:16:30 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port for single pipeline models Message-ID: <20240223141630.GA1313@pendragon.ideasonboard.com> References: <20240223140445.1885083-1-alexander.stein@ew.tq-group.com> <20240223140445.1885083-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240223140445.1885083-3-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_061639_207534_7D253056 X-CRM114-Status: GOOD ( 18.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote: > In case the hardware only supports just one pipeline, allow using a > single port node as well. This is frowned upon in DT bindings, as it makes them more complicated for little gain. The recommendation is to always use a ports node if a device can have multiple ports for at least one of its compatibles. > Signed-off-by: Alexander Stein > --- > .../devicetree/bindings/media/nxp,imx8-isi.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > index 4d5348d456a1f..f855f3cc91fea 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml > @@ -53,6 +53,12 @@ properties: > power-domains: > maxItems: 1 > > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: | > + Port representing the Pixel Link input to the ISI. Used for > + single-pipeline models. The port shall have a single endpoint. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > description: | > @@ -66,7 +72,6 @@ required: > - clocks > - clock-names > - fsl,blk-ctrl > - - ports > > allOf: > - if: > @@ -87,6 +92,11 @@ allOf: > port@1: false > required: > - port@0 > + oneOf: > + - required: > + - port > + - required: > + - ports > > - if: > properties: > @@ -106,6 +116,8 @@ allOf: > required: > - port@0 > - port@1 > + required: > + - ports > > additionalProperties: false > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel