From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31986C48BF6 for ; Sat, 24 Feb 2024 20:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kCj38JTO7hyKYWOsWjBZKyq0IW/LaCk7i2wup2g7iMQ=; b=KV7sl7oee8WMMEG1wZOwB52Ftm wB5spukX7SSTFFQJWw942dnsJVVniPz2MFxMwxOfEcI85+p8L2Qel7dQa+U2vWJIvnfULZely/o0j Zg49d5Y52FsAVbBlJpMDUy8y91UVZfCIPx/MD6aqJfvUI7j+YcgRYbzgUuV/9xCd6jhnxulZiFwr/ cGs7Xb8usnc5KidqTvRSODwU9xEdQATrQhfZgPhrRX5PDslT9HDiqaG9kJeZ+BndfbxWPJmNWYrkX RHK5lzA0ojcLBssgEgpbi9fXj76lnNveJ6aByihzH78blTBdjyeyk2khkzCI6Dujvi47dT2z8Xe/w roQXzJig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdyEI-0000000DYVg-0Han; Sat, 24 Feb 2024 20:02:38 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdyEF-0000000DYVG-13qX for linux-arm-kernel@lists.infradead.org; Sat, 24 Feb 2024 20:02:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 431EECE0C47; Sat, 24 Feb 2024 20:02:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 476DFC433F1; Sat, 24 Feb 2024 20:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708804952; bh=tpvjkEKYJLAWc8r/kFlJlpJPF2ji+9TFnmJFk47EZlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M4EJfrEukmXbwH6vbe4k1OZ9uAkIti2PK99vA7IODObK94M/+dWtj7ewfRKkVCzBe C07PLANm15udqZOyj0fM2A+5/64AqnNp3y7OEZ3m3qx2LWwmuSym2P3mmbLbMCEoKW ZkeTkEvJD+E0tqJ7Gei3Ggez2ugzAV+DBBYd++cVQBzLxvTkNqUIGzbRdGOQ571d/l K2ZCQTYsYFh6ibAlxc+Gnr56XzXoeytPVFeMjE8PDfI0+iAV7a/LICTWNMVF0McfNw LpwUA2ZTyv3N3EV5tpPt4xQ8FJJcAUG9iSwZPjoDy2T18+4IVkB1Mr/mckTL/hvbzv vljH/6Y+VYOZA== Date: Sat, 24 Feb 2024 20:02:26 +0000 From: Conor Dooley To: Varshini Rajendran Subject: Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7. Message-ID: <20240224-kimono-stress-898eae80abd3@spud> References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172559.672142-1-varshini.rajendran@microchip.com> MIME-Version: 1.0 In-Reply-To: <20240223172559.672142-1-varshini.rajendran@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240224_120235_746294_2E89CD12 X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, claudiu.beznea@tuxon.dev, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, linux-spi@vger.kernel.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="===============2652408509721901813==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2652408509721901813== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8c64jTTjW0j3INUS" Content-Disposition: inline --8c64jTTjW0j3INUS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote: > Add sam9x7 compatible to DT bindings documentation. >=20 > Signed-off-by: Varshini Rajendran > --- > Changes in v4: > - Fixed the wrong addition of compatible > - Added further compatibles that are possible correct (as per DT) > --- > .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.ya= ml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > index 65cb2e5c5eee..30af537e8e81 100644 > --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > @@ -23,11 +23,17 @@ properties: > - const: atmel,at91sam9260-dbgu > - const: atmel,at91sam9260-usart > - items: > - - const: microchip,sam9x60-usart > + - enum: > + - microchip,sam9x60-usart > + - microchip,sam9x7-usart > - const: atmel,at91sam9260-usart > - items: > - - const: microchip,sam9x60-dbgu > - - const: microchip,sam9x60-usart > + - enum: > + - microchip,sam9x60-dbgu > + - microchip,sam9x7-dbgu > + - enum: > + - microchip,sam9x60-usart > + - microchip,sam9x7-usart This doesn't make sense - this enum should be a const. I don't really understand the idea behind of the original binding here that allowed: "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbg= u", "atmel,at91sam9260-usart" Specifically, I don't get the purpose of the "microchip,sam9x60-usart". Either make it - items: - enum: - microchip,sam9x60-dbgu - microchip,sam9x7-dbgu - const: microchip,sam9x60-usart - const: atmel,at91sam9260-dbgu - const: atmel,at91sam9260-usart or add - items: - const: microchip,sam9x60-dbgu - const: atmel,at91sam9260-dbgu - const: atmel,at91sam9260-usart or explain exactly why this needs to be "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu" Thanks, Conor. --8c64jTTjW0j3INUS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdpLUgAKCRB4tDGHoIJi 0gcuAPwKJcQi8VunTtf+c2HxMwJnzd/VcSM1qfFZR7t6Y2RTxwD/UV6+lcP8ArXQ HqrqN+g0Ua0mQyRSLJa+cfksxbl88wY= =PXng -----END PGP SIGNATURE----- --8c64jTTjW0j3INUS-- --===============2652408509721901813== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2652408509721901813==--