From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4B87C48BF6 for ; Mon, 26 Feb 2024 11:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rvMw6cV0jhun54qLyjVBm6MFgF21whWllk6wJ19nyco=; b=qv45WGY34aEVWTLljA8pSo3IBR lvgLOgcKrhMtgXDV3PxiOjs4Y0F7bncCl4bjVntM6QUChRisRvf3+bWYGWP2GBZ/qfjKxWuDqmNnP Nu8YTNAPat3QWpBKPUKqhA/+sPCPLH3yZO0/mQxiKHMdt1xBEVCBcwsOLxonzyOtzahBMpT5rohWt +sjXLN8sj/sSv1+JUX7QbeOWLcbVODZk2X67D/PvzwMrnO5ZgB7FM4na+Ib6uPQe6qvEVHsPtXsSs VJI0dTFzXTvLORxUG8GAylOzmOnaKxwf4cHXJQMC2p2dLOaxbIjfeVvyJccQPaF67R+KV1/2rdRiS DKNwx50A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reZbv-00000000RaM-1Svj; Mon, 26 Feb 2024 11:57:31 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reZbl-00000000RWW-2gkV for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 11:57:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1708948641; x=1740484641; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LXxr0oCyAyi941LBQn7wpQyHhte7aRcvaiULQ0755YM=; b=00HDml6YJQspYnO29gWuCY4mckQN7RU9Nc9Q4jzsyDma5alNsnMG7j16 w94HQlqOVlie3ObE32MWLEYuCYzNGx4nNk4Vf2FcR14I3DkA4ESrG82t4 lLrxWCwE8nO8JIGGdeqrk8IU5cP8E9N9AI3+iW4SWAps4KM04lOmwduRh v2TfiwMXpRMpkRT6o7UMXRQ+PT7gJEhhQ/KUZkpT0kf00mrhKzabL5eaZ db29Iu7D49zefzvztlHpaDU0zrMezS64TaXw19LqQdHINAP2UijSlKQkE jp0QjBZEUzaBtGVuQWD++eh200SxTbO4TW/+fVYP0DsEcKVfUq+kzjsuq Q==; X-CSE-ConnectionGUID: Szb1mO22RbmH0OMhJ27Cfw== X-CSE-MsgGUID: vdi+E3YdQS6QNTLBV3VCmQ== X-IronPort-AV: E=Sophos;i="6.06,185,1705388400"; d="asc'?scan'208";a="184093811" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Feb 2024 04:57:14 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 26 Feb 2024 04:57:02 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 26 Feb 2024 04:56:59 -0700 Date: Mon, 26 Feb 2024 11:56:16 +0000 From: Conor Dooley To: =?iso-8859-1?Q?Th=E9o?= Lebrun CC: Conor Dooley , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Roger Quadros , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Thomas Petazzoni , =?iso-8859-1?Q?Gr=E9gory?= Clement , Kevin Hilman , Alan Stern , , , , Subject: Re: [PATCH v3 1/8] dt-bindings: usb: ti,j721e-usb: drop useless compatible list Message-ID: <20240226-portable-rockslide-e501667a0d9a@wendy> References: <20240223-j7200-usb-suspend-v3-0-b41c9893a130@bootlin.com> <20240223-j7200-usb-suspend-v3-1-b41c9893a130@bootlin.com> <20240223-clarity-variably-206b01b7276a@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_035721_950638_3279FEA2 X-CRM114-Status: GOOD ( 30.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5494011684616183753==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5494011684616183753== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y/81symxI7pz60lC" Content-Disposition: inline --y/81symxI7pz60lC Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024 at 11:33:06AM +0100, Th=E9o Lebrun wrote: > Hello Conor, >=20 > On Fri Feb 23, 2024 at 7:12 PM CET, Conor Dooley wrote: > > On Fri, Feb 23, 2024 at 05:05:25PM +0100, Th=E9o Lebrun wrote: > > > Compatible can be A or B, not A or B or A+B. Remove last option. > > > A=3Dti,j721e-usb and B=3Dti,am64-usb. > > >=20 > > > Signed-off-by: Th=E9o Lebrun > > > --- > > > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml = b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > index 95ff9791baea..949f45eb45c2 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > @@ -11,12 +11,9 @@ maintainers: > > > =20 > > > properties: > > > compatible: > > > - oneOf: > > > - - const: ti,j721e-usb > > > - - const: ti,am64-usb > > > - - items: > > > - - const: ti,j721e-usb > > > - - const: ti,am64-usb > > > > Correct, this makes no sense. The devices seem to be compatible though, > > so I would expect this to actually be: > > oneOf: > > - const: ti,j721e-usb > > - items: > > - const: ti,am64-usb > > - const: ti,j721e-usb >=20 > I need your help to grasp what that change is supposed to express? Would > you mind turning it into english sentences? > A=3Dti,j721e-usb and B=3Dti,am64-usb. My understanding of your proposal is > that a device can either be compat with A or B. But B is compatible > with A so you express it as a list of items. If B is compat with A then > A is compat with B. Does the order of items matter? The two devices are compatible with each other, based on an inspection of the driver and the existing "A+B" setup. If this was a newly submitted binding, "B" would not get approved because "A+B" allows support without software changes and all that jazz. Your patch says that allowing "A", "B" and "A+B" makes no sense and you suggest removing "A+B". I am agreeing that it makes no sense to allow all 3 of these situations. What I also noticed is other problems with the binding. What should have been "A+B" is actually documented as "B+A", but that doesn't make sense when the originally supported device is "A". Therefore my suggestion was to only allow "A" and "A+B", which is what we would (hopefully) tell you to do were you submitting the am64 support as a new patch today. > I've not applied your proposal to check for dtbs_check but I'd guess it > would throw warnings for the single existing upstream DTSI (as of > v6.8-rc6) that uses "ti,am64-usb"? See: > arch/arm64/boot/dts/ti/k3-am64-main.dtsi. Yeah, it would but it's not as if that cannot be changed. There's no concerns here about backwards compatibility here, right? --y/81symxI7pz60lC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdx8YAAKCRB4tDGHoIJi 0sCAAPwLF+i1FiXIYJ+rJDn2P1nOhyEPNbA2O5VrdxWhaSS8qgEA0qc5dIt6gFNG 4p7KsxNzS7FXx8EctGxE6ZdwAUiC5Qo= =QOfZ -----END PGP SIGNATURE----- --y/81symxI7pz60lC-- --===============5494011684616183753== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5494011684616183753==--