From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
haibo.chen@nxp.com, lars@metafoo.de, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
Date: Mon, 26 Feb 2024 21:17:06 +0000 [thread overview]
Message-ID: <20240226-rectangle-pacifist-633ae3b801c7@spud> (raw)
In-Reply-To: <20240226192055.54b4a6b1@jic23-huawei>
[-- Attachment #1.1: Type: text/plain, Size: 1650 bytes --]
On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > so drop it.
> >
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
>
> I'm missing something. See below...
> >
> > Thanks,
> > Conor.
> >
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > > - description: normal conversion, include EOC (End of Conversion),
> > > ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > JECH (End of injected Chain).
> > > - - description: Self-testing Interrupts.
>
> Eyes skipped over this maybe? The 4th interrupt is removed from binding here...
Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-26 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 13:08 [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Peng Fan (OSS)
2024-02-26 13:08 ` [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC Peng Fan (OSS)
2024-03-15 1:01 ` Peng Fan
2024-03-28 12:47 ` Shawn Guo
2024-02-26 16:24 ` [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Conor Dooley
2024-02-26 19:20 ` Jonathan Cameron
2024-02-26 21:17 ` Conor Dooley [this message]
2024-02-26 22:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226-rectangle-pacifist-633ae3b801c7@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox