From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40BD8C54E49 for ; Mon, 26 Feb 2024 12:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TlqPyI7oSYrD++kvyK+TVnY4+DW9Q+/HnZPedW0QeOY=; b=gxHJi0lQm62MIy TQlNF3MBEqMiCQs/ygVl5sW0mACinvYuQhsYyz9ktl5jAaRJlWup1AY9Sl4vd0Kqo7Jt8yiAod2JL wGDDStHJ7Mik+NsixndgD22FLGJtTrVNWYgyE/vClpSVsU1gcA6qubd6TSiU7BPnNfMZn5IfjQALd Ktudw91Vv2DG1wyTJzuE5xR8nPo3Qa/w5ce+MQGo30pQ5SE1hKsJWOrotQJH68zIr9R2aBQkfkjN4 t3YMb9ZMSqlKbynU/B1M802DSec4dsmuD2pY/X9ziHXHswb9F1OXkaKqkfkH/4Pfc8ZgJVemaE6Sy bSbm1/pYPaPBcY+ltROQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reaYu-00000000iXP-2NtW; Mon, 26 Feb 2024 12:58:28 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reaYk-00000000iTc-25sq for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 12:58:26 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F0E37CD1; Mon, 26 Feb 2024 13:58:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708952285; bh=nWeVNhQbpzGEzexd0Q9yFGms48MVeo78w5gEoRyrpr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FA2VPoDTsT76mAO4hlB105eus3JQOgAMyvmU17kpx2upKpRpUqzhMdawkKCYOfLT2 bThxBvxflzXfIeRjq0Q91JyY9gju6LwxeIifN+SgBC9sXCIcUbreil0dpnFqfhhxau Jx62n+VtA2GihTyER94wnzo6pmgUk7cgNU+QoZuQ= Date: Mon, 26 Feb 2024 14:58:18 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: Daniel Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com, robh+dt@kernel.org, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 2/5] dt-bindings: media: Add bindings for ARM mali-c55 Message-ID: <20240226125818.GA26163@pendragon.ideasonboard.com> References: <20240214141906.245685-1-dan.scally@ideasonboard.com> <20240214141906.245685-3-dan.scally@ideasonboard.com> <20240226120431.GA25561@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_045818_708127_F26D5D8E X-CRM114-Status: GOOD ( 26.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 26, 2024 at 12:20:15PM +0000, Sakari Ailus wrote: > On Mon, Feb 26, 2024 at 02:04:31PM +0200, Laurent Pinchart wrote: > > On Mon, Feb 26, 2024 at 11:54:22AM +0000, Sakari Ailus wrote: > > > On Wed, Feb 14, 2024 at 02:19:03PM +0000, Daniel Scally wrote: > > > > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > > > > > > > > Acked-by: Nayden Kanchev > > > > Signed-off-by: Daniel Scally > > > > --- > > > > Changes in v2: > > > > > > > > - Added clocks information > > > > - Fixed the warnings raised by Rob > > > > > > > > .../bindings/media/arm,mali-c55.yaml | 77 +++++++++++++++++++ > > > > 1 file changed, 77 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > > new file mode 100644 > > > > index 000000000000..30038cfec3a4 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml > > > > @@ -0,0 +1,77 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: ARM Mali-C55 Image Signal Processor > > > > + > > > > +maintainers: > > > > + - Daniel Scally > > > > + - Jacopo Mondi > > > > + > > > > +properties: > > > > + compatible: > > > > + const: arm,mali-c55 > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + interrupts: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + items: > > > > + - description: ISP video clock > > > > + - description: ISP AXI clock > > > > + - description: ISP AHB-lite clock > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: vclk > > > > + - const: aclk > > > > + - const: hclk > > > > + > > > > + ports: > > > > + $ref: /schemas/graph.yaml#/properties/ports > > > > + > > > > + properties: > > > > + port@0: > > > > + $ref: /schemas/graph.yaml#/properties/port Adding description: Input parallel video bus here would be useful. > > > > + > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/graph.yaml#/properties/endpoint > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - interrupts > > > > + - clocks > > > > + - clock-names > > > > + - ports > > > > + > > > > +additionalProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + mali_c55: isp@400000 { > > > > + compatible = "arm,mali-c55"; > > > > + reg = <0x400000 0x200000>; > > > > + clocks = <&clk 0>, <&clk 1>, <&clk 2>; > > > > + clock-names = "vclk", "aclk", "hclk"; > > > > + interrupts = <0>; > > > > + > > > > + ports { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + port@0 { > > > > + reg = <0>; > > > > + isp_in: endpoint { > > > > + remote-endpoint = <&mipi_out>; > > > > > > I suppose this is a CSI-2 interface with D-PHY? > > > > No, that's an internal parallel bus. Depending on the SoC integration, > > it can be connected to a CSI-2 receiver, a DMA engine, or a mux to > > select between different sources. > > The name suggests otherwise. Maybe change that to something more > descriptive? We could rename mipi_out to csi2_rx_out, sure. > > > How many lanes do you have and is lane remapping / polarity inversion > > > supported? > > > > > > This should be reflected in bindings. > > > > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > +... -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel