From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F719C5478C for ; Tue, 27 Feb 2024 09:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5mHKAePWUbSGlJ54L4+qLgzsIGvwlw48tVAJaU6Z4d4=; b=Q8xaA3fZZRVTCv TFmJGQ+M95ZqnVtYLuTJW6qyBgmXVPUUDB14Zf68XCQr5fU93JETTebpAMVro9EPom622EdYct3g/ m4waeknr5A6mKURhYQjPP0bcd8EVEBRw6CII7V7kRUOKguNypqrIyItih1lF2CP/4406+w4Nct9h6 LcpzS1vqrA4fuTyMp8E7m0LutNuItj+n0VWca2JaqSdTnE8SqXX9wWqOidKgWlpDsqdImRlY0exfa tbfZeqHJVDhq3Y96DBu9KQiq/88TJhilMh+GAJ2yp2WGiYSkSTrPVYsnfLsSFPuyX2mwQZ9IIDXsM L10tPy9PQNZJwbvmvahQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1retPC-00000004Rh9-2JBc; Tue, 27 Feb 2024 09:05:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1retP8-00000004RgS-2CKj for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 09:05:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7AB5B61484; Tue, 27 Feb 2024 09:05:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8B83C433F1; Tue, 27 Feb 2024 09:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709024735; bh=Am/D+g9bxO9RrGanC/9goSZgOkapPvJ6A17Yn9/q0p0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hg1EUzVZ7XOEM1hsgrqJ3KvddHqLBU06Z0qzqQRfePSMjFAmw1+GDfC0QOLNPMdPZ reR6lCFjjTSru4dEFU7h0YoMTbEnZJuBclSt2b8LOmZ7Tp5u0zglnQW2mMOv7YxAlG cNB0lTFgqQowkHWZWoGuC66YDGvgyk1TgYs2/2B7GWLRpeAtgYjere1/znwxFMSwTq y1NnkbYfNlxkD1IBk7SpKYkNQDV2hx3ZPBjocY0v0P5j9OVfDKcbvH7xjcsZIpGdrU mVNwwZ2IE5QqRs5UivGlT5e9p6Y5nQuns41rsOBPK/Cov3fWEIGzZJXs+QwsfSesmT lhLfrjZ/Ae4iQ== Date: Tue, 27 Feb 2024 09:05:30 +0000 From: Will Deacon To: Anshuman Khandual Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, broonie@kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/hw_breakpoint: Determine lengths from generic perf breakpoint macros Message-ID: <20240227090529.GA13359@willie-the-truck> References: <20240223113102.4027779-1-anshuman.khandual@arm.com> <20240223125224.GC10641@willie-the-truck> <1901fadb-1d71-4374-be8c-00935bb27854@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_010538_633929_1958A35E X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 27, 2024 at 11:01:54AM +0530, Anshuman Khandual wrote: > On 2/26/24 16:34, Mark Rutland wrote: > > I don't think this needs to change, and can be left as-is. > > Fair enough, but just wondering how about deriving len_in_bytes from > hweight_long(ARM_BREAKPOINT_LEN_*) instead ? This also drops the hard > coding using the platform macros itself, without going to user ABI. Please leave this code alone. It's fine like it is and there are plenty of other things that would actually benefit from your attention. The BRBE series, for example. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel