From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1338CC5478C for ; Tue, 27 Feb 2024 10:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0zuwvd/zQ+LDAJUpSoUFVoB2sq4LCs+vhl30jaQ7BkE=; b=HXcik8K4uhHl0h Tmw0hq3dImo5qCfa3cRDIOyX3I/KwjSLNOHiHzJMNKvJ3qHjTCwST3Vd3gJ8olEQbQT82pxure/Z3 gKiaqJw38V33uTxGZfyeLhiSIt0vOcMG3moTNSz899KV7nZzs9TEUf4rcl18OqkaNh8kkoyXuM3mx 8VaofeqFljAi33h9opW1NzfCTvgyggx1V6+azf6qu+HUzsuKzFa9urUhXXIX569DwXeH49ktS3AFF LnqBlj0BGhwPEBzWM88A/MheTnkjT28BGa/mOcMGeS3ATyvBrecNUSZF0llsOsva1kY336pRouAe6 Qp31SRK8c+D7M/+c0e3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rev2P-00000004pDq-3vcP; Tue, 27 Feb 2024 10:50:17 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rev2N-00000004pCo-1dcu for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 10:50:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BBF276152C; Tue, 27 Feb 2024 10:50:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FE34C433C7; Tue, 27 Feb 2024 10:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709031014; bh=h/XPnR9/Of74e57QRgQwK4utsjer1UJrLhZg11kJf9E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ArRbrzzkRv2DPl31GDKc2bQzlz9XV2Kd3q/cN28EQDl0wb7IzkqVYnFqoZoTOH0R9 6cTKAjWYxCnZw6gvXOHoOeHhbCq/ZYghidbOW06ryrO8KV4f/Yi4vJskd20OFf0utH GqzyNgqXtvcYh7sqsveTNby6WAa6VLT1nMxjkdvbid7p1xBBqQY7AizQQW8Zl1TER/ Qd01DP7+og2GkcmzD5HDreBYLD1DmCFGq8cdaS6N0o2/4HAzh2BiU+riEg311Rvr3h v0wNZ5UEzsDSwIG7K34Jsamx5tli3V72And1hL/IuskBJ1hsUkB7ooDt8O1Ks7F+7e mk/3N614ouRxw== Date: Tue, 27 Feb 2024 10:50:08 +0000 From: Will Deacon To: Jason Gunthorpe Cc: Robin Murphy , iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Lu Baolu , Jean-Philippe Brucker , Joerg Roedel , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Mostafa Saleh , Zhangfei Gao Subject: Re: [PATCH v5 02/17] iommu/arm-smmu-v3: Consolidate the STE generation for abort/bypass Message-ID: <20240227105007.GA13859@willie-the-truck> References: <2-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> <2ca7f64e-a9e3-4d47-b04f-726c86223fd6@arm.com> <20240223185358.GA791502@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240223185358.GA791502@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_025015_504945_2789AF19 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 23, 2024 at 02:53:58PM -0400, Jason Gunthorpe wrote: > On Thu, Feb 15, 2024 at 05:27:09PM +0000, Robin Murphy wrote: > > > @@ -1583,22 +1595,20 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_master *master, u32 sid, > > > arm_smmu_write_ste(master, sid, dst, &target); > > > } > > > +/* > > > + * This can safely directly manipulate the STE memory without a sync sequence > > > + * because the STE table has not been installed in the SMMU yet. > > > + */ > > > static void arm_smmu_init_bypass_stes(struct arm_smmu_ste *strtab, > > > > This name is long out-of-date - if we're refreshing this area, please rename > > to something relevant to what it actually does, e.g. s/bypass/initial/. > > Done > > > Although frankly I also think that at this point we should just get rid of > > the disable_bypass parameter altogether - it's been almost entirely > > meaningless since default domain support was added, and any tenuous cases > > for wanting inital STEs to be bypass should probably be using RMRs now > > anyway. > > I can write the patch for this if you and Will agree Yes, please! I'll be glad to see the back of that option. Since you just posted v6 of your "part 1", feel free to send a patch which applies on top of that (rather than having to rebase the whole shebang). Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel