From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A89BC5478C for ; Tue, 27 Feb 2024 17:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+POoV1/9vHPT8qpHTl2pjnfokGZBSzzjxoyv/DPDoUY=; b=MOFbA1BgEVAwx5 0wlRzKZxBIJktG/d+WMVVp1GexQZ6HeQVZyZWEcd+gscYDb2bNwy1YkVTp5RvcrU4n7Q4hUz76Afh xrgFieC0iCJIh6LKM7kyI3uc+OHREXKeAjZlSGzCSEuliigf0dMVd3Jsxx9qrZaSqXwtnXSTWemSC jQ/D/ziaEZnMcNPFmXVxe1hWdgT715ALBohzVEwPE5eknt+0clB4Om87gO3ZL2MvY5jPzSjWz/szm n0TVd6gHM4EyIG7cw8JWnIi4BYFxLTJopgYF61aFhY8P/E23UMbUUtTs5H1lKvvKcqW53OFGZE+ls JYmKcBQwqXwlPtFDCh9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1J0-00000006DaA-13px; Tue, 27 Feb 2024 17:31:50 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1Iv-00000006DXc-3CnT for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 17:31:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7C89DCE1D7F; Tue, 27 Feb 2024 17:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A41B4C433F1; Tue, 27 Feb 2024 17:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709055101; bh=Vh0Ez1JrBKiIyidqjd4EXVU+cnkiUF48ZPkt4g2S6n8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HY/hn0NF8tK8v5Wb0dzqt4bBlvBm1w1rbAy0uddtaJFqd+g36xlMIpccd2TvM6+TW dVtUaUXLptA5SvNmnTiN+MSUvthRwb0Sq6YT85w4nI0cjXr57MBizrjH+3AKQsZMQU STjOtvi3PfJs553kCYKDZOE+g5+WWBXz2xGGM9CHttjtwk32TjtByihUQS7JvoBihr gLD1mZDpE5gty3tGO98lINFTtimiWSVxDBOH5H6YVwdQ534kdU0y00uJbV7aedGfEL HgXmCV110uqjQGF5WFCsKa8y0xlpeL9jti71v83eM3ai+44j1JVQ/0RkZb1w0nULye IY+4Pmfby/I0A== Date: Tue, 27 Feb 2024 17:31:36 +0000 From: Simon Horman To: Diogo Ivo Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, danishanwar@ti.com, rogerq@kernel.org, vigneshr@ti.com, arnd@arndb.de, wsa+renesas@sang-engineering.com, vladimir.oltean@nxp.com, andrew@lunn.ch, dan.carpenter@linaro.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jan.kiszka@siemens.com Subject: Re: [PATCH net-next v3 10/10] net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms Message-ID: <20240227173136.GH277116@kernel.org> References: <20240221152421.112324-1-diogo.ivo@siemens.com> <20240221152421.112324-11-diogo.ivo@siemens.com> <20240222133103.GB960874@kernel.org> <39ca8e5f-7fba-4f8c-a0f7-59153382bcf3@siemens.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <39ca8e5f-7fba-4f8c-a0f7-59153382bcf3@siemens.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_093146_572147_AA54FD2B X-CRM114-Status: GOOD ( 26.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 27, 2024 at 12:05:14PM +0000, Diogo Ivo wrote: > On 2/22/24 13:31, Simon Horman wrote: > > On Wed, Feb 21, 2024 at 03:24:16PM +0000, Diogo Ivo wrote: > > > Add the PRUeth driver for the ICSSG subsystem found in AM65x SR1.0 devices. > > > The main differences that set SR1.0 and SR2.0 apart are the missing TXPRU > > > core in SR1.0, two extra DMA channels for management purposes and different > > > firmware that needs to be configured accordingly. > > > > > > Based on the work of Roger Quadros, Vignesh Raghavendra and > > > Grygorii Strashko in TI's 5.10 SDK [1]. > > > > > > [1]: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ti.com%2Fcgit%2Fti-linux-kernel%2Fti-linux-kernel%2Ftree%2F%3Fh%3Dti-linux-5.10.y&data=05%7C02%7Cdiogo.ivo%40siemens.com%7Cfebc5e0f6a1b476c366d08dc33aa89ee%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638442054773860177%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=YxcCwUMV7Zzyycb1Ss6xoCq9BK1vYsvuoF30XXA2tRI%3D&reserved=0 > > > > > > Co-developed-by: Jan Kiszka > > > Signed-off-by: Jan Kiszka > > > Signed-off-by: Diogo Ivo > > > > ... > > > > > diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c > > > > ... > > > > ... > > > > + config.rx_flow_id = emac->rx_flow_id_base; /* flow id for host port */ > > > + config.rx_mgr_flow_id = emac->rx_mgm_flow_id_base; /* for mgm ch */ > > > + config.rand_seed = get_random_u32(); > > > > Hi Diogo and Jan, > > > > The fields of config above are all __le32. > > However the last three lines above assign host byte-order values to these > > fields. This does not seem correct. > > > > This is flagged by Sparse along with some problems. > > Please ensure that new Sparse warnings are not introduced. > > > > You are correct, thank you for catching the inconsistency, this will be > fixed in v4. > > ... > > > > +static int emac_send_command_sr1(struct prueth_emac *emac, u32 cmd) > > > +{ > > > + dma_addr_t desc_dma, buf_dma; > > > + struct prueth_tx_chn *tx_chn; > > > + struct cppi5_host_desc_t *first_desc; > > > + u32 *data = emac->cmd_data; > > > + u32 pkt_len = sizeof(emac->cmd_data); > > > + void **swdata; > > > + int ret = 0; > > > + u32 *epib; > > > > In new Networking code please express local variables in reverse xmas tree > > order - longest line to shortest. > > Noted, will fix for v4. > > ... > > > There is also one such problem in Patch 06/10. > Here xmastree reported the same problem in patch 08/10 rather than 06/10, I > assumed you meant that one. Yes, probably. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel