Re: [PATCH v2 00/30] Rework Nomadik GPIO to add Mobileye EyeQ5 support

Théo Lebrun
2024-02-29T09:56:54Z

Hello,

On Thu Feb 29, 2024 at 10:44 AM CET, Linus Walleij wrote:
> On Wed, Feb 28, 2024 at 12:28 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:
>
> > This patch series reworks the Nomadik GPIO driver to bring it up to date
> > to current kernel standards. We then add Mobileye EyeQ5 support that
> > uses the same IP block but with limited functionality. We also add
> > features required by our newly supported platform:
> >
> > - Dynamic GPIO ID allocation;
> > - Make clock optional;
> > - Shared IRQ (usecase: EyeQ5 has two banks using the same IRQ);
> > - Handle variadic GPIO counts (usecase: EyeQ5 has <32 GPIOs per bank);
> > - Grab optional reset at probe (usecase: EyeQ5 has a shared GPIO reset).
> >
> > This GPIO platform driver was previously declared & registered inside
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c, side-by-side with the
> > pinctrl driver. Both are tightly integrated, mostly for muxing reasons.
> > Now that gpio-nomadik is used for another platform, we loosen the
> > relationship. The behavior should not change on already supported
> > hardware but I do not have Nomadik hardware to test for that.
>
> I have queued the relevant patches to an immutable branch in the
> pinctrl tree for testing and I can also pick up some ACKs if they arrive.
>
> When I'm confident in the branch, I will send an optional pull request
> to Bartosz for it!

That is all great news, thanks Linus! I'm staying available if you
encounter anything that needs action.

Have a nice day,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering