linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'
@ 2024-02-04 12:57 Masahiro Yamada
  2024-02-04 13:18 ` Masahiro Yamada
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2024-02-04 12:57 UTC (permalink / raw)
  To: Aaro Koskinen, Janusz Krzysztofik, Tony Lindgren, linux-omap
  Cc: Arnd Bergmann, Masahiro Yamada, Russell King, linux-arm-kernel,
	linux-kernel

Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
added one more 'select ARCH_OMAP'.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/arm/mach-omap1/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
index cbf703f0d850..a643b71e30a3 100644
--- a/arch/arm/mach-omap1/Kconfig
+++ b/arch/arm/mach-omap1/Kconfig
@@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
 	depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
 	depends on CPU_LITTLE_ENDIAN
 	depends on ATAGS
-	select ARCH_OMAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_OMAP
 	select CLKSRC_MMIO
-- 
2.40.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'
  2024-02-04 12:57 [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP' Masahiro Yamada
@ 2024-02-04 13:18 ` Masahiro Yamada
  2024-02-28  7:28   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2024-02-04 13:18 UTC (permalink / raw)
  To: Aaro Koskinen, Janusz Krzysztofik, Tony Lindgren, linux-omap
  Cc: Arnd Bergmann, Russell King, linux-arm-kernel, linux-kernel

Just a nit.

The commit subject "arm:" should be capitalized to "ARM:"
because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?


On Sun, Feb 4, 2024 at 9:57 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
> added one more 'select ARCH_OMAP'.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  arch/arm/mach-omap1/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
> index cbf703f0d850..a643b71e30a3 100644
> --- a/arch/arm/mach-omap1/Kconfig
> +++ b/arch/arm/mach-omap1/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
>         depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
>         depends on CPU_LITTLE_ENDIAN
>         depends on ATAGS
> -       select ARCH_OMAP
>         select ARCH_HAS_HOLES_MEMORYMODEL
>         select ARCH_OMAP
>         select CLKSRC_MMIO
> --
> 2.40.1
>


-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'
  2024-02-04 13:18 ` Masahiro Yamada
@ 2024-02-28  7:28   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2024-02-28  7:28 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Aaro Koskinen, Janusz Krzysztofik, linux-omap, Arnd Bergmann,
	Russell King, linux-arm-kernel, linux-kernel

* Masahiro Yamada <masahiroy@kernel.org> [240204 13:19]:
> Just a nit.
> 
> The commit subject "arm:" should be capitalized to "ARM:"
> because it is a convention for changes under arch/arm/.
> 
> Maybe, the maintainer can cater to it?

Thanks yes applying into omap-for-v6.9/omap1 with the prefix
changed.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-28  7:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 12:57 [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP' Masahiro Yamada
2024-02-04 13:18 ` Masahiro Yamada
2024-02-28  7:28   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).