* [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT
[not found] <20240228123850.3499024-1-arnd@kernel.org>
@ 2024-02-28 12:38 ` Arnd Bergmann
2024-02-28 18:32 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-02-28 12:38 UTC (permalink / raw)
To: Frederic Weisbecker, Thomas Gleixner, Ingo Molnar
Cc: Arnd Bergmann, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, linux-arm-kernel,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
ARCH_BCM_MOBILE is the only platform that selects CONFIG_TICK_ONESHOT,
the others stopped 12 years ago in commit 98fab064d321 ("ARM: Remove
unnecessary selection of TICK_ONESHOT").
This inconsistency caused a build regression after an otherwise
correct change to the timers subsystem:
kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying'
1599 | void tick_sched_timer_dying(int cpu)
| ^
kernel/time/tick-sched.h:111:20: note: previous definition is here
111 | static inline void tick_sched_timer_dying(int cpu) { }
Drop this dead select.
Fixes: 3aedb7fcd88a ("tick/sched: Remove useless oneshot ifdeffery")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-bcm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 8df4b23e2699..ed6415e7e3a4 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -93,7 +93,6 @@ config ARCH_BCM_MOBILE
select ARM_ERRATA_775420
select ARM_GIC
select GPIO_BCM_KONA
- select TICK_ONESHOT
select HAVE_ARM_ARCH_TIMER
select PINCTRL
select ARCH_BCM_MOBILE_SMP if SMP
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT
2024-02-28 12:38 ` [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT Arnd Bergmann
@ 2024-02-28 18:32 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2024-02-28 18:32 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Arnd Bergmann, Frederic Weisbecker,
Thomas Gleixner, Ingo Molnar
Cc: Florian Fainelli, Arnd Bergmann, Ray Jui, Scott Branden,
linux-arm-kernel, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
On Wed, 28 Feb 2024 13:38:42 +0100, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> ARCH_BCM_MOBILE is the only platform that selects CONFIG_TICK_ONESHOT,
> the others stopped 12 years ago in commit 98fab064d321 ("ARM: Remove
> unnecessary selection of TICK_ONESHOT").
>
> This inconsistency caused a build regression after an otherwise
> correct change to the timers subsystem:
>
> kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying'
> 1599 | void tick_sched_timer_dying(int cpu)
> | ^
> kernel/time/tick-sched.h:111:20: note: previous definition is here
> 111 | static inline void tick_sched_timer_dying(int cpu) { }
>
> Drop this dead select.
>
> Fixes: 3aedb7fcd88a ("tick/sched: Remove useless oneshot ifdeffery")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-28 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240228123850.3499024-1-arnd@kernel.org>
2024-02-28 12:38 ` [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT Arnd Bergmann
2024-02-28 18:32 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).