From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42922C5478C for ; Thu, 29 Feb 2024 01:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4plX58fUbohfeNEOmjY1XjRavdG9tU00JG+8wlUwCKM=; b=15TuoeYLUzN77l +8AWgaz/jqW8M4WfSehLj21LmxjquU1iu5pQIc/XCb3LpSR0GS/fYLJmF5blIl8BY3D+sZ4iAYf+F xMhfybxaRDa6Q1wuLqKfr3pMyb8Onf0RDM/ccY4t/EXTN/8AmvNv6WucbZ3KlxMMXc881iQyJiSme yQIxblXSPJadTPyz0z+mBv3wXk+HcREL8zTH0GnhB9brAhvAj7h9vQBI5BL6tlJzjcPfDbZxGJCvA vp/gDAXla53n+xlq5SZPRK/iTfIXkrRrwws5nLWJ28AIHdlwOBENbBdB2HF7i3YDn0tRlEdRwPArS NE7PtiU2t3wyKb5vJl1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfV12-0000000BaRp-3tyV; Thu, 29 Feb 2024 01:15:16 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfV10-0000000BaRF-0LFL for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 01:15:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BF588CE2375; Thu, 29 Feb 2024 01:15:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55633C433F1; Thu, 29 Feb 2024 01:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709169311; bh=z7f+Dbb4dDt0wPU1cnaBodq/Wil5VeJE1ycdq0aUaq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F2Xeh2RubzK3AW7IcsJ8JguT0FCtBPq8dwfnSFWlufbMmVlY2g3+MfMfEM01Bh2MK z5ccVI4tykZjoiO95oQ0dYg7GIlCTWyTi1Up81i0EuRKMYHvTR5n3W7fN8QXupphte kmZSklRhuYvDXiSRo1BgmiYdzVRKbBrx4t+PIIvHBN+xtBaQAxt7uzmGk7tFXnlgbQ 052q7dyS0vKRTmZlh2lrVMMEfladfdH9F25NkO8VShL0ha5ZC7/vJ16RoBIsVmThjH YyDT8eVuI7JTTNXRsjZH4swfQGnpZIb+u7GFjMp/lsSh4GmDwDnJwY36VOmwmY+KzH ictO3oxeNV89g== Date: Wed, 28 Feb 2024 17:15:09 -0800 From: Jakub Kicinski To: "Gustavo A. R. Silva" Cc: Kees Cook , Andy Shevchenko , Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: <20240228171509.4eeb5519@kernel.org> In-Reply-To: <49f55b02-ce21-40ac-a4cc-02894cd5eb8f@embeddedor.com> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> <20240228144148.5c227487@kernel.org> <202402281554.C1CEEF744@keescook> <653bbfe8-1b35-4f5e-b89d-9e374c64e46b@embeddedor.com> <20240228165730.3171d76c@kernel.org> <49f55b02-ce21-40ac-a4cc-02894cd5eb8f@embeddedor.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_171514_332889_5F25AD29 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Feb 2024 19:03:12 -0600 Gustavo A. R. Silva wrote: > On 2/28/24 18:57, Jakub Kicinski wrote: > > On Wed, 28 Feb 2024 18:49:25 -0600 Gustavo A. R. Silva wrote: > >> struct net_device { > >> struct_group_tagged(net_device_hdr, hdr, > >> ... > >> u32 priv_size; > >> ); > >> u8 priv_data[] __counted_by(priv_size) __aligned(NETDEV_ALIGN); > >> } > > > > No, no, that's not happening. > > Thanks, one less flex-struct to change. :) I like the flex struct. I don't like struct group around a 360LoC declaration just to avoid having to fix up a handful of users. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel