From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46A80C48BF6 for ; Thu, 29 Feb 2024 18:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IdMfcEt0Z9v3MEZk/TgDrXUDttereJA7Dx+O3abJ9jg=; b=D/emyudvfBxufPN+LQZMnumgmo +CbUrxLT7vD2wdfXl+cedJ6vLSNhkamykV10jGQmd469f/EtikzQdxzLRw5Yt/6ag/EzuqbhDN8jk QxaYJTIPGPn40lPb2EtXo5T0n/jVYLOaa+972lPcL2aE0gzLtZ4anvX82JaCSIVzWqJeM3MaEgu4t SnEa4ebb9aYPKK8VK5DG+JFOyG88CovFfGGK7mFD+pMbYMgaZGCF2ycgHeB9cHd//Ua7VpXxks0Cu W/+py1O74yoSvQ+ZV/umJ2hHVcf0aHEDy26L6wdSsVFbk/FQmxr7JSKqf3mNuYSl++Qpi0WrbqAR7 QvObxJEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflWe-0000000Emot-1u4f; Thu, 29 Feb 2024 18:53:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflWb-0000000EmoQ-3wD8 for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 18:52:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 459FCCE1D3E; Thu, 29 Feb 2024 18:52:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59734C433F1; Thu, 29 Feb 2024 18:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709232775; bh=iOuQ3NLogT9DUhHCagui9Zsqnob82CO/bZ+hAddHmV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tNvuM8+IbumeEEu2/usJApVNDKku+NSX689Gbx5KT0ldIbrE7CdXg/5HCMy5SuED1 gZQA+8iFyuieDIj9HkM5Eqn/5LxosMa6yq2udvAWMmZHx7yWofHDHav8SFCEpVg10i UPCzzxrBweoU5EPTG02X9+2x06wXfDr+AEYjLgGRCnHIpeqqKhQ8YqBYORtKQ0zzz6 WPke1aaNXmL9m2V5Q6Ado9e7F2dy3Ekarze0bKm6dmJ+YIJ63Je46maRWJPHLBv6ym fyBV3GLBn0q8HN1Y1SdHHMQsNVtzLEWeJSA6NZPTBkScrswa/doyBRJdGX3nxAD3Cn LkrU62uN9FgZw== Date: Thu, 29 Feb 2024 18:52:50 +0000 From: Conor Dooley To: Frank Li Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement Message-ID: <20240229-gladly-morse-28a3a06e8845@spud> References: <20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com> <20240227-asrc_8qxp-v2-1-521bcc7eb1c0@nxp.com> MIME-Version: 1.0 In-Reply-To: <20240227-asrc_8qxp-v2-1-521bcc7eb1c0@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_105258_367159_E18FAD5C X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1751447442644424619==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1751447442644424619== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xrZyC8VUYzqklLdV" Content-Disposition: inline --xrZyC8VUYzqklLdV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 03:54:09PM -0500, Frank Li wrote: > Add power-domains property for asrc and spdif. Is this valid for all compatibles documented in these bindings? Also, your $subject says "requirement", but you do not mark these as required. Why not? Cheers, Conor. >=20 > Signed-off-by: Frank Li > --- > Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml | 3 +++ > Documentation/devicetree/bindings/sound/fsl,spdif.yaml | 3 +++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/= Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml > index bfef2fcb75b14..98616507e3c10 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml > @@ -74,6 +74,9 @@ properties: > - const: asrck_f > - const: spba > =20 > + power-domains: > + maxItems: 1 > + > fsl,asrc-rate: > $ref: /schemas/types.yaml#/definitions/uint32 > description: The mutual sample rate used by DPCM Back Ends > diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Doc= umentation/devicetree/bindings/sound/fsl,spdif.yaml > index 1d64e8337aa4b..82430f1d5e5a2 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml > @@ -86,6 +86,9 @@ properties: > registers. Set this flag for HCDs with big endian descriptors and = big > endian registers. > =20 > + power-domains: > + maxItems: 1 > + > required: > - compatible > - reg >=20 > --=20 > 2.34.1 >=20 --xrZyC8VUYzqklLdV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeDSgQAKCRB4tDGHoIJi 0nEKAQC75ySPnVkmXzXAPanKzHsx8/8kj8yWlRUKAoJEv1oycwEAmDYO/yWZJvnA 5yDq517lBIAwBlPF//RY2lokX/YdJQQ= =xvu+ -----END PGP SIGNATURE----- --xrZyC8VUYzqklLdV-- --===============1751447442644424619== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1751447442644424619==--