From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F392C54798 for ; Thu, 29 Feb 2024 21:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vowFfK1Qk02HIECTd7JJiQVF7xpS4T9q9oE8sZvgTuk=; b=2mOfMw6lwyfZJV QIZwZB++7Cx4IFqFZrYql+6GE+SX/Dwy1zd/7TQ5uC3ds5CjcrnFMhYKrQUU3+PpQVuf0cqL7Z14Y dTpDn0qAWwfS45OSnouX2oa7g7vt4gnOw7oTZv6MEvxRd1eHjD3nE6X9HLpSZM1hL7XMEKtWszhF5 ktCOFga7TlRYO/ExAT24HCDXvnC11/dkQlrloswkicz9rMFAXcbFObYRplrlWkYcrmMtm+f+GmHSu qs47HBpHAXwGjcOghZKaG7LTdIW2j/uBTK4Wi0CZxdQ5yQYrj25d2/fr8WgABn4Y2bnz0qn8DZAmX 081lGyUnRQXRDNxply2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfo0K-0000000FL2e-1Igw; Thu, 29 Feb 2024 21:31:48 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfo0H-0000000FL2A-3nHI for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 21:31:47 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1dc0e5b223eso13742475ad.1 for ; Thu, 29 Feb 2024 13:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709242305; x=1709847105; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=LcG0MqxN66nbbXKankChvdF93usGVDlHuMztSVb3jJUxv/akEOFJ3DWAwHkhPBqjX5 8+Tv954KaSaiteBvYcnLESh1EpwQRN/Er7w1x2KWvwxEma4FueTEAYxI5CidZBVjNE20 1GsdIsWHQODtViRP/wFLMTgIylaVZ4yS7pV/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709242305; x=1709847105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=PoMzovzQAG3WBKsfFQwGoFSpYrrKDrPg9kAcZKPjz5FenDjsw7G04+IBj/scYLXtt1 lSXkjp318km1y9RH4StUp5TKn/e1F/ZCP8gHBeFlEKSLexU2Bkon+QFg6XH/oTlritv8 7GC3emt9KpucBUxfwx6SY3q8wkWOEKEq49HYnKP5okroD86J10HMgZL9YJnR/b/NYZU3 2shgp/RbPBZzsrYxYhLL+frRLonJJMxSyopEmo3htRsGdgsDBorKM0W4d8gEq7lXCgJS 9k78Mja8px4mLsBud1kuCethUrx8OV0Tt/ozyELFbr4vVmSz/YVB65EeTvczCxMHh3G9 0lEQ== X-Forwarded-Encrypted: i=1; AJvYcCVYKrdHS2QvzoeEXuIsiBEYIeGeU5fPhlqBzQ/KWsoagUwXbdhQn7r/wW17SZ1HXrHf1VAtUHz+kH7hSry2Yc30FQwjcGvWNMpIpL0r6058ODoi6ps= X-Gm-Message-State: AOJu0YxNDANF0N21NCsnA8xfFV/1MPnLskNvzSEiOmG4G123XCfFRlUh Fa4wIgquZ5xu20QF7fj6+xJNDkmIcL4CThiOYnEn+3HJzYk0F9PveKixuCsbGg== X-Google-Smtp-Source: AGHT+IE+DUv8Qdh0LZ32jo8m9iF3a01wivEsDDN/MHriPt719iWzbKIbR1Qbd56MoYjYqe7Ub9Claw== X-Received: by 2002:a17:902:654a:b0:1dc:ca72:8318 with SMTP id d10-20020a170902654a00b001dcca728318mr2807886pln.37.1709242304905; Thu, 29 Feb 2024 13:31:44 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id y9-20020a1709027c8900b001db717d2dbbsm1954387pll.210.2024.02.29.13.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:31:44 -0800 (PST) Date: Thu, 29 Feb 2024 13:31:43 -0800 From: Kees Cook To: Jakub Kicinski Cc: Andy Shevchenko , Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: <202402291330.0510946B67@keescook> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> <20240228144148.5c227487@kernel.org> <202402281554.C1CEEF744@keescook> <20240228165609.06f5254a@kernel.org> <202402291059.491B5E03@keescook> <20240229113706.42c877a1@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229113706.42c877a1@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_133145_962801_587CE3D1 X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 11:37:06AM -0800, Jakub Kicinski wrote: > On Thu, 29 Feb 2024 11:08:58 -0800 Kees Cook wrote: > > > And some seem to be cargo-culted from out-of-tree code and are unused :S > > > > Ah, which can I remove? > > The one in igc.h does not seem to be referenced by anything in the igc > directory. Pretty sure it's unused. I'll double check. After trying to do a few conversions I really hit stuff I didn't like, so I took a slightly different approach in the patch I sent. -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel