From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0677DC5475B for ; Fri, 1 Mar 2024 16:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HziKbyDBmdicYKxWyPyDXoT4py6JiVsNdWACx7UD+Is=; b=OqdopLuVKA57WezZloInYVKIVH 7s+JO9TSTlPhrMqKTgCElE+MVNlK7wj+ux625eLjw2pSKTcrgJ+wLe/X2YEm6lyX5WSlQkfrOYcIr ozim9j8ukIlhuLwW1AJzRCY72mVOkrbfVmY4UUOLzqJa6ocg0UOpgjHb48H/0fL115ls+cgVrI1Cy 9DVUyikvWxJzK46vPy5L6tiuG1JXKUBT0+L/rm+x3QKaB0Bhb4EGLP6xjQ8/31PBxb+P/0WGSCnik CTU+bkNzp0IzXYYqYX8FqCpJfEWsbsXG9mCNpHrNZzfgyfVd31g2MNo55ZkDDulAKJwo0TtjNfmEc hzu5GXQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg5OC-0000000115s-0vuZ; Fri, 01 Mar 2024 16:05:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg5O8-0000000112O-0K5N for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 16:05:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 15BC7616F1; Fri, 1 Mar 2024 16:05:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A74EC433C7; Fri, 1 Mar 2024 16:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709309130; bh=rVW9AEO5L6z97bsCb2BGNYw/xLkhAfUG8wSYzGdCvpI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QK6yF6U22HPa80VMPZAdA7clsYc9ldvaMPHwnU5+38ck6ghTDFZTooOQEeB8XCJZs kW7HIAMXb1aBdpmlDNYlNpXMaHrXb8WGYbRDCkEZ4P2VCIL66n2Mc/0WQxWdwepQZo 1SMRFqzIMYdySBoKVlUAckwRDxejhqFJFfvf0ErfsO2cB6eepTJPRKNW2v3sJABQDb EV6un8ZY706NeKCMb+Zk/xnbcqLyAbWNApVzoI1ub9muV9nHm7m6fnRtv2w9xSeOwk o7rTs79dzwurOW1hSiSAmcJGfEmZo+/JGuNOGMAZrZFAY6kgMXY4cHi+FYDXEgwaDM 1/+LzEuz/alOg== Date: Fri, 1 Mar 2024 16:05:25 +0000 From: Conor Dooley To: Frank Li Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Message-ID: <20240301-crudeness-resale-3c0a1228850d@spud> References: <20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com> <20240227-asrc_8qxp-v2-3-521bcc7eb1c0@nxp.com> <20240229-husband-penalty-8c1ab0f57f55@spud> <20240229-rundown-isotope-954ba9ea4c57@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_080532_462792_E257A570 X-CRM114-Status: GOOD ( 23.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0311761633647767685==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0311761633647767685== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zZCgftqPN9gmkuL1" Content-Disposition: inline --zZCgftqPN9gmkuL1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 29, 2024 at 02:38:24PM -0500, Frank Li wrote: > On Thu, Feb 29, 2024 at 06:57:29PM +0000, Conor Dooley wrote: > > On Thu, Feb 29, 2024 at 06:55:58PM +0000, Conor Dooley wrote: > > > On Tue, Feb 27, 2024 at 03:54:11PM -0500, Frank Li wrote: > > > > Some sai only connect one direction. So allow only "rx" or "tx" for > > > > dma-names. > > >=20 > > > Which sai? Can you restrict this per compatible please, so that someo= ne > > > cannot add 2 dmas for ones where only the tx is supported. > > >=20 > > > | dmas: > > > | minItems: 1 > > > | items: > > > | - description: DMA controller phandle and request line for RX > > > | - description: DMA controller phandle and request line for TX > > >=20 > > > The binding already allows only one, but it documents that the first = dma > > > is always the RX dma, and that doesn't change with this patch.. > >=20 > > I said "doesn't change" - but I don't think you can change this > > trivially, as something could rely on the first dma being the rx one. > > You'd have to check that there is nothing using these using indices > > rather than names before making any changes here. >=20 > Linux driver and dts with tx only work well. Only issue is dtb_check will > report error. I want to eliminate these DTB_CHECK warning. Linux is not the only user of these bindings, citing linux as your evidence here is only sufficient if no other users exist. Do they? > And it also reasonable, only rx or tx for a special SAI. >=20 > Can we remove 'description'? dmas should already descripted at common pla= ce > and 'RX' and 'TX' are listed at 'dma-names' Removing the description has the same problem. The existing binding has set a fixed order that you now want to make flexible. Thanks, Conor. --zZCgftqPN9gmkuL1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeH8xQAKCRB4tDGHoIJi 0jzLAQDD7qaiVIh5k+1icra1khOuagWcwolMz38Pf4nuzJIXjwEAnnqTFIXEW5NP EVc5LseIyIToZ1a+TcVfIdL4iMIvTwA= =0N5o -----END PGP SIGNATURE----- --zZCgftqPN9gmkuL1-- --===============0311761633647767685== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0311761633647767685==--