From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C0C7C5478C for ; Fri, 1 Mar 2024 12:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7LEKI5N2V3Cke+TGBZV/WQu4REQ5XKvxtPHjztCZnvQ=; b=qvaIhzS8tO4UEYNrBR5kzoybG0 uVXflA1I5tFgFkireWWFmQ5n/co5V6umXOrjSvt8+T+ejLZVGVKDvae71o59ZbnopmjWOzggm3i5Z 22lnfToUuj8n+4Zo/SyrtOf/AuxvW/W5teqrrUK367idQss2uXwmy8aqJJhYPXI0w3haD+CIAXiHm oQqiKjltIc8XqZt7wzjw6fZ2wtPyeM73LJ77BWHF+ttab9ot5Wrpzqvgi74s2WoOfYDkDLBbjZkZz 8acKEMfqG4lnkBKUYzBtJrWDksg1osvTAuvIi/ntWchixVLjhZdDcXXYcoKD9ROFvJqdvB4MVIW6W BLvh6t3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg1r5-0000000087p-0x6X; Fri, 01 Mar 2024 12:19:11 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg1r1-0000000086a-2h20; Fri, 01 Mar 2024 12:19:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709295542; bh=/JuogARoTSkexC999JDvQiVZli/6nhMtXRKfthwm9cw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S6lYDqXJrWXUDzPO1wTmvcUBucoziKYFzSnZOSZUEAB1QwwGMnwSj9RquoSAOkPJ/ ++HwlGFBlVjPES5nwc555SgdlGFrPN8PVYChSzRSTD7xQaR0O3JCCC1lIb2mLJtM31 kCyDlCATlHHcYdwBa3hsXYzOM8N8+FE3uUD0XkYXid7DYVxuw+Vpx628DAilTvjnk/ NcBvlpGOPQOxm8Hr2E+M0wtCChqfHXo/YJqFuJLjwaMF71knauhnn6nqVjoWOonb8K voWsn5IaQ7Cwlz4cnNjiGwOCUAVGjNT86uhYLgezNrfqseQxjy5zgS8lUHt8h3tkad 1uVuziX/wL+7w== Received: from eldfell (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pq) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BEAED378000E; Fri, 1 Mar 2024 12:19:01 +0000 (UTC) Date: Fri, 1 Mar 2024 14:19:00 +0200 From: Pekka Paalanen To: Maxime Ripard Cc: Sebastian Wick , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Ville =?UTF-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Dave Stevenson Subject: Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property Message-ID: <20240301141900.1ee1e2ef.pekka.paalanen@collabora.com> In-Reply-To: <20240301-loyal-cornflower-oxpecker-83ed59@houat> References: <20240222-kms-hdmi-connector-state-v7-0-8f4af575fce2@kernel.org> <20240222-kms-hdmi-connector-state-v7-21-8f4af575fce2@kernel.org> <20240229194726.GB166694@toolbox> <20240301-light-impressive-grasshopper-adabeb@houat> <20240301112941.GE166694@toolbox> <20240301-loyal-cornflower-oxpecker-83ed59@houat> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_041907_822536_18D71213 X-CRM114-Status: GOOD ( 27.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6216701156361237820==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6216701156361237820== Content-Type: multipart/signed; boundary="Sig_/yomWKOIfqdy35zj6dRjUbn_"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/yomWKOIfqdy35zj6dRjUbn_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 1 Mar 2024 13:12:02 +0100 Maxime Ripard wrote: > On Fri, Mar 01, 2024 at 12:29:41PM +0100, Sebastian Wick wrote: > > On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: =20 > > > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: =20 > > > > > @@ -1708,6 +1731,39 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subc= onnector_property); > > > > > /** > > > > > * DOC: HDMI connector properties > > > > > * > > > > > + * Broadcast RGB (HDMI specific) > > > > > + * Indicates the Quantization Range (Full vs Limited) used.= The color > > > > > + * processing pipeline will be adjusted to match the value = of the > > > > > + * property, and the Infoframes will be generated and sent = accordingly. > > > > > + * > > > > > + * This property is only relevant if the HDMI output format= is RGB. If > > > > > + * it's one of the YCbCr variant, it will be ignored and th= e output will > > > > > + * use a limited quantization range. =20 > > > >=20 > > > > Uh, maybe just say that the quantization range is selected automati= cally > > > > in case a YCbCr output format is in use. I'm not sure every YCbCr > > > > variant requires limited and even if it does, new formats could cha= nge > > > > this. =20 > > >=20 > > > I documented what i915 is doing: > > > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i915/d= isplay/intel_hdmi.c#L2143 =20 > >=20 > > Sure, this is one valid strategy for the automatic behavior of YCbCr. > > Drivers could also always send an InfoFrame to ensure full range where > > possible. The point here is that this property shall not affect YCbCr > > output formats! > >=20 > > Maybe it's even better to say "driver specific" instead of "automatic".= =20 >=20 > Honestly, I'm not sure what you want from me here. Ville and you > insisted on the previous version to document what i915 is doing and to > follow whatever the behaviour was, and that we shouldn't spend time > improving the property. Fine, I did that. >=20 > But now, you want me to ... improve the property? Just drop the "and the output will use a limited quantization range" part. Thanks, pq --Sig_/yomWKOIfqdy35zj6dRjUbn_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmXhx7QACgkQI1/ltBGq qqcFMhAApnw120yGkMTU78b9MLRYnIpCL8IVDkC74fOg134teNF3ZHRveBy91rEy yGr5TiB5iXahBTUIM8oSttIEu0IpqTauZISYsBOnVXqukbO2MktR8Nbec4YioVb0 HFLYbyzewiyTOkuF5Ud9C7icE2g65xEt/RxserG73jUAj6CTnhWRl8zbZQOo5ze7 1P8E2uWGehaZh8YRzbwIjXJYxj8gEUfj5vZy7HX+YmPYfls/lanw0XWU2ON+rs1f xFM2u6nDeQ30pGSG7I0ccD6oXFw4yesbSusecHexpByjwIyDMlz0uP5HkLuqeI9I mBZmvX4YEfyjQgq3H0Rnsm1OJIU3SC2pGQ9YLJxpmA/dSf3PZ2ktHsz3WQjRxbhr aJq1d8DroMft41SRdindTDUwg2lssg1MNWu3GRLee8vWxc8Paf/4eNEhbolfTFHB dXagpKniLK0Fk8BCpKv0M2TuKyiv5Hc5jCiwHtHX3ESIvhBC952k7UP4aHRPif5U Df9nQwfRKgOb9CYXPKZK+Ug6u9Ayxb1m47e2Z3K0duRyi4I7yMz9M8FAEguvMNsH YoghGtR4geDcBruuLIOI2yeORwOYorHRww9U+J9spCN1zEcbO+9aCxZ+EmEKABtw XXN/e3yaSp0gEqGOQfIFopUV3gYq7M1YcNFP4hMRzIro6qVwqUQ= =+Rkf -----END PGP SIGNATURE----- --Sig_/yomWKOIfqdy35zj6dRjUbn_-- --===============6216701156361237820== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6216701156361237820==--