From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD6BC5478C for ; Fri, 1 Mar 2024 15:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/XnX1H/UlGLp674Z+7tRxUAKotLkwI2JQge2aXFuxck=; b=Q1yMX0ccmaw4Jy vPj6gqmG3UHAX6aBe9LCAvuCAVQFBJ1S4jjglzn46WsaMygxwQupLG8MV8JKDGyaMlA4LxzzNmprC SLg0SkSDIb8T+nM0SiW/tb+Zqq023Bo5OejJN91pb2Pchw4Kk+dpWWN0N6/86qg3CQWE1572EXjnU qu8Puo1d+WB8GWzTUIJXYZdtz/AGD/TYLFFLAd/OYphZB0p4aSgulIwDfVqhMejLlP/0hroihK1hZ +S7HC37zrgteqDiwQkf+nlqWJpCVJbpePlza3STseqhzzvi7UxThIQzWtHygYfuMxxtImzH6UxIGv HW2yb8ybEVcc5LpQCDpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg4YG-00000000qUp-2bte; Fri, 01 Mar 2024 15:11:56 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg4YD-00000000qTq-0F9j for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 15:11:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 39AC6CE0909; Fri, 1 Mar 2024 15:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE22C433F1; Fri, 1 Mar 2024 15:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709305909; bh=yYWhC8o+k18yDFAE/PF3lPXCt5+FY+PFPMPV0qxvv6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rOvpOu8ShoCHhRTbOwgSdne2Nc8JrVDe/apVggW4vE+x9ZWPmsaHpLbwQs8k7iECK KDhJCQwsTHbOy15eco9mq4BYcuTkKiIy06RTezuC/KV1SMAA+kGqXw7G6xJlyIhCVF JlQT2p1DFVlCbLNV50n1UaKMYutdlGvdN8qJCNIb3gnFvKsDru6ROfg/qAmeXELm3w cXdJcY3yRGcM99GU7BGEtNhq3m6vJhD0oLaUxD+yS4LFVlcWnJCnSaMLbpBpatk3Kv HKiJ6BhC16aLH1HwewnvNNml2ttHCwXxUz0RmxbbQRsot4X+c8oJtkMBunR/pYmyd1 dMhgduJmYskcQ== Date: Fri, 1 Mar 2024 09:11:46 -0600 From: Rob Herring To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Linus Walleij , Andi Shyti , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v2 01/11] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example Message-ID: <20240301151146.GA2114576-robh@kernel.org> References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-1-b32ed18c098c@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229-mbly-i2c-v2-1-b32ed18c098c@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_071153_511270_FFC94537 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 07:10:49PM +0100, Th=E9o Lebrun wrote: > Add EyeQ5 bindings to the existing Nomadik I2C dt-bindings. Add the > EyeQ5-specific property behind a conditional. Add an example for this > compatible. > = > Signed-off-by: Th=E9o Lebrun > --- > .../devicetree/bindings/i2c/st,nomadik-i2c.yaml | 48 ++++++++++++++++= ++++-- > 1 file changed, 44 insertions(+), 4 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml b/= Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > index 16024415a4a7..2d9d5b276762 100644 > --- a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > @@ -14,9 +14,6 @@ description: The Nomadik I2C host controller began its = life in the ST > maintainers: > - Linus Walleij > = > -allOf: > - - $ref: /schemas/i2c/i2c-controller.yaml# > - > # Need a custom select here or 'arm,primecell' will match on lots of nod= es > select: > properties: > @@ -24,6 +21,7 @@ select: > contains: > enum: > - st,nomadik-i2c > + - mobileye,eyeq5-i2c > required: > - compatible > = > @@ -39,6 +37,10 @@ properties: > - const: stericsson,db8500-i2c > - const: st,nomadik-i2c > - const: arm,primecell > + # The variant found on Mobileye EyeQ5 Kind of obvious from the compatible string, but maybe you are keeping = the existing style... > + - items: > + - const: mobileye,eyeq5-i2c > + - const: arm,primecell > = > reg: > maxItems: 1 > @@ -55,7 +57,7 @@ properties: > - items: > - const: mclk > - const: apb_pclk > - # Clock name in DB8500 > + # Clock name in DB8500 or EyeQ5 > - items: > - const: i2cclk > - const: apb_pclk > @@ -70,6 +72,16 @@ properties: > minimum: 1 > maximum: 400000 > = > + mobileye,olb: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: Phandle to OLB system controller node. > + - description: Platform-wide controller ID (integer starting f= rom zero). Rather than a made up ID, just store the shift value you ultimately = need. These properties are fragile because they break if anything that's not = defined in DT changes whether that's register offset, bit offset, = bitfield size or values. Or also if there are additional fields to = access. = Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel