From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C34C54E49 for ; Sat, 2 Mar 2024 01:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ufO7Pr1ybJyA8kOuNZoBrBKoDQPltvjcDJHdCE/ulg4=; b=tGhEu6jh1aBGw8 njEWfw9Xr2ZXmeIi8NFB7gD52YD2FrVxpp7LBRbHBdeOvor/1BWH0dNKtaRvo/hgbrQMf19d0vWq3 m9uORC/9CHVKlVneGeoR4pYvECN6/K4kv12Ss9l5FZ4YTIMdmPCs1pgbP5cIFcwQy4f/vfWfMhwZQ uxdeFCbpGktUJp+O8ihq458ngxJj2iBK2P+Gdt9HJ0NwjFGM+fjX2iJ6TTeUL9slEQ7pRTL13a9EY d/PLOGxXH61g38jnghvF/r4Wk880hGyN0/PrPuXRY4cpv8TQkk4BhvE5XFg9BlPxGkUXmMUF/mW+m a+OmrSqJYam66dYxlqNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgEWw-00000002WyY-1WHP; Sat, 02 Mar 2024 01:51:14 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgEWt-00000002WwN-0Wr7 for linux-arm-kernel@lists.infradead.org; Sat, 02 Mar 2024 01:51:12 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e4560664b5so2302749b3a.1 for ; Fri, 01 Mar 2024 17:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709344269; x=1709949069; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1JOHRODJmattJBY3YtQ+51tfBSOEI55kux6+SckPNNk=; b=AM5w1ShjUu0L97c6wQZ075mwgMMDgzOFKatq+FiYlRDb3KGOAq1nP0XHgpyvGXgNtj CE8JqjEEWcSNhBM+PLiWeK4MHCis4r/b9SJHRcV1ebPAzrXm67R/s/v8OWtjsjBqfJ7y +UkVShTzLKBDqUzg25aU1XZN99nmXKyg2cFaA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709344269; x=1709949069; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1JOHRODJmattJBY3YtQ+51tfBSOEI55kux6+SckPNNk=; b=WIqT7ktEjKZjVpKYPrFHUy9LsPaJxgjgVMTHDaD/dsmgKyUvJUifoAaRy7mXuKAVru Ox6tc2tve816fN7f3HarJLR9AtzIxB+HwlgiMN06YuqxCtedG43xgsniJxcOyL02aobA uVCZjIq9/StEw5ALyEPxBjhOcZ0mFCsQ9GZk5w05S86T3CerQNnKj8E/Bvl41nqQvKAJ hBACys5N0FD2e8YVQvSOyArdjOzYtsRl6QqoKKtDpQe/BnVEvACNl0c67OHTWoIeHD/G PxMyaQuRG5SdvhA+tfWS+AMTEHWKXOINWciNqyeI7Shp9ne1E7hVMfTla62Ofzpmdjmq LBcw== X-Forwarded-Encrypted: i=1; AJvYcCWYtne7K7hLtaI0xrMUfgAhYXM+XsnGCR26nW2lSgMLOAQBOhk8JSevvfw0RrU4ec2DM6eZ0JiCL+92DyI8pydniIKoCVz6c+NbpvpNYwIVpNBHQFs= X-Gm-Message-State: AOJu0YxHuTh3G/2akXflls7DiSpuUaIx/h2x9RkPxFrnXkpZCaALqRVM yS2hIGnNmZ7NcnkWWlOG8ZGvzDn4V3rnhSCoC9I66yVfDndzX+3FKYPUiWDC+g== X-Google-Smtp-Source: AGHT+IHRDk8dRy87orC5sOO0fLYLW475IUp9U1sSARPtPvgR8uAOkuMFjfqikjpTM+PGmCnZ+zOW8Q== X-Received: by 2002:a05:6a20:e11f:b0:1a0:ef1e:a5a7 with SMTP id kr31-20020a056a20e11f00b001a0ef1ea5a7mr3447528pzb.4.1709344269211; Fri, 01 Mar 2024 17:51:09 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id rm12-20020a17090b3ecc00b002993f72ed02sm3845854pjb.34.2024.03.01.17.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 17:51:08 -0800 (PST) Date: Fri, 1 Mar 2024 17:51:08 -0800 From: Kees Cook To: "Edgecombe, Rick P" Cc: "christophe.leroy@csgroup.eu" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "debug@rivosinc.com" , "akpm@linux-foundation.org" , "linux-sh@vger.kernel.org" , "linux-csky@vger.kernel.org" , "mingo@redhat.com" , "kirill.shutemov@linux.intel.com" , "tglx@linutronix.de" , "linux-parisc@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-mm@kvack.org" , "linux-snps-arc@lists.infradead.org" , "Liam.Howlett@oracle.com" , "hpa@zytor.com" , "peterz@infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "bp@alien8.de" , "linux-s390@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "sparclinux@vger.kernel.org" , "broonie@kernel.org" Subject: Re: [PATCH v2 5/9] mm: Initialize struct vm_unmapped_area_info Message-ID: <202403011747.9ECFAD060B@keescook> References: <20240226190951.3240433-1-rick.p.edgecombe@intel.com> <20240226190951.3240433-6-rick.p.edgecombe@intel.com> <94a2b919-e03b-4ade-b13e-7774849dc02b@csgroup.eu> <202402271004.7145FDB53F@keescook> <8265f804-4540-4858-adc3-a09c11a677eb@csgroup.eu> <91384b505cb78b9d9b71ad58e037c1ed8dfb10d1.camel@intel.com> <202402280912.33AEE7A9CF@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_175111_201320_C5D35066 X-CRM114-Status: GOOD ( 30.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 02, 2024 at 12:47:08AM +0000, Edgecombe, Rick P wrote: > On Wed, 2024-02-28 at 09:21 -0800, Kees Cook wrote: > > I totally understand. If the "uninitialized" warnings were actually > > reliable, I would agree. I look at it this way: > > = > > - initializations can be missed either in static initializers or via > > =A0 run time initializers. (So the risk of mistake here is matched -- > > =A0 though I'd argue it's easier to *find* static initializers when > > adding > > =A0 new struct members.) > > - uninitialized warnings are inconsistent (this becomes an unknown > > risk) > > - when a run time initializer is missed, the contents are whatever > > was > > =A0 on the stack (high risk) > > - what a static initializer is missed, the content is 0 (low risk) > > = > > I think unambiguous state (always 0) is significantly more important > > for > > the safety of the system as a whole. Yes, individual cases maybe bad > > ("what uid should this be? root?!") but from a general memory safety > > perspective the value doesn't become potentially influenced by order > > of > > operations, leftover stack memory, etc. > > = > > I'd agree, lifting everything into a static initializer does seem > > cleanest of all the choices. > = > Hi Kees, > = > Well, I just gave this a try. It is giving me flashbacks of when I last > had to do a tree wide change that I couldn't fully test and the > breakage was caught by Linus. Yeah, testing isn't fun for these kinds of things. This is traditionally why the "obviously correct" changes tend to have an easier time landing (i.e. adding "=3D {}" to all of them). > Could you let me know if you think this is additionally worthwhile > cleanup outside of the guard gap improvements of this series? Because I > was thinking a more cowardly approach could be a new vm_unmapped_area() > variant that takes the new start gap member as a separate argument > outside of struct vm_unmapped_area_info. It would be kind of strange to > keep them separate, but it would be less likely to bump something. I think you want a new member -- AIUI, that's what that struct is for. Looking at this resulting set of patches, I do kinda think just adding the "=3D {}" in a single patch is more sensible. Having to split things that are know at the top of the function from the stuff known at the existing initialization time is rather awkward. Personally, I think a single patch that sets "=3D {}" for all of them and drop the all the "=3D 0" or "=3D NULL" assignments would be the cleanest way to go. -Kees -- = Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel