From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C4DBC5478C for ; Fri, 1 Mar 2024 18:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a0u1WdP9i3z7O2/36hic8UK+igSMb5fbinmFT99kvGY=; b=yAeMnkPq9WuFwG 6V1AYmfl1e6JB3C+ooJ1dpK75A6RKd7A/2WLMQGaaDP4jLhupbdLu+Co+hYAIxP8hlKYmYQMKBscC mCqCF6PQ59UykaakWM43sa/ykdFGMKwai30yfg0IGDWrT7hq8HzqsJ4Y7yGjVPtoiCz2cYDopNkx8 P5RlrS5nw1+UJLh30W7evvQs99/Gk7/KFNm/+Kli9QXiTPtcWwB5UoH8M0Pj9KzQll8c5A/NRaPTY EJnxytNEB/WiGB56MLnHR4hIsdeyOV0J9G8z2oHw/BUiVJ4DzMXCDon4IvE8c2ymq8bBuZVGhNgEr mDjPPSWnN2DwUSUMVx8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg7Km-00000001T8K-1y9q; Fri, 01 Mar 2024 18:10:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg7Kk-00000001T7i-2ISH for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 18:10:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DB8F761A09; Fri, 1 Mar 2024 18:10:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 524E8C433C7; Fri, 1 Mar 2024 18:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709316609; bh=oGgDYAMEcOek5vzs12UcoMNqw0pBRI+Tp6Tw2lcrknA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IK8N7CTxXCT+ZohlOgRwslhOwKmwn14JE//RO0B49dvzoU0LIQhX04JV9TqoA6xB3 kZH1ErLMAK+dq4z/Lne+YMOjfFwrtGAyeGR8QvXI2IyTdV7wrFEERyDKF29Lq6/xIQ z2Aal86VP39Ab2yob5tMqJ5CJLpBO6Nr/bhi5+oM4v2m+rdP+jy5IbmeNcDvj8HS3K S7C/BCRe4HE6QNg4pXYsrBGO7jlsdcqDho7ZRR65wFGKfRXi6SjxWewX+5ZiAEFCiL t1cUzHAxEKftKEJuTfm89UIrrIEMeMOO9zH2j//+g+54Uk4f8nRXg3lLRQVb+He3mV juJGoyCGAIgXw== Date: Fri, 1 Mar 2024 12:10:07 -0600 From: Rob Herring To: Dharma.B@microchip.com Subject: Re: [PATCH] dt-bindings: display: atmel,lcdc: convert to dtschema Message-ID: <20240301181007.GA2481641-robh@kernel.org> References: <20240223-lcdc-fb-v1-1-4c64cb6277df@microchip.com> <796652d5-af57-4aca-87c2-10a7b0b55959@linaro.org> <11c545e2-45df-4587-a5c7-12b05c2f01e0@microchip.com> <9bf7e492-891c-4d8f-b388-3b2ebae611c1@linaro.org> <34388175-7d5b-4f6b-b264-e85b84e98677@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_101010_694850_63A7F47A X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, tzimmermann@suse.de, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, claudiu.beznea@tuxon.dev, krzysztof.kozlowski@linaro.org, alexandre.belloni@bootlin.com, daniel@ffwll.ch, airlied@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 06:25:56AM +0000, Dharma.B@microchip.com wrote: > On 28/02/24 3:53 pm, Krzysztof Kozlowski wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 28/02/2024 11:18, Dharma.B@microchip.com wrote: > >> On 28/02/24 12:43 pm, Krzysztof Kozlowski wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> On 28/02/2024 07:59, Dharma.B@microchip.com wrote: > >>>> > >>>>> > >>>>> I don't know what's this exactly, but if embedded display then maybe > >>>>> could be part of this device node. If some other display, then maybe you > >>>>> need another schema, with compatible? But first I would check how others > >>>>> are doing this. > >>>> > >>>> Okay, then I think the driver also needs to be modified, currently the > >>>> driver parses the phandle and looks for these properties. Also the > >>>> corresponding dts files. > >>> > >>> Driver does not have to be modified in my proposal. You would still have > >>> phandle. > >> > >> If I understand correctly, I could define the dt bindings as below > >> > >> display: > >> $ref: /schemas/types.yaml#/definitions/phandle > >> description: A phandle pointing to the display node. > >> > >> panel: > >> $ref: panel/panel-common.yaml# > >> properties: > >> > > > > So these are standard panel bindings? Then the node should live outside > > of lcdc. If current driver needs to poke inside panel and panel could be > > anything, then probably you need peripheral-props-like approach. :/ > > Thank you so much, so can I use something like this > > display: > $ref: /schemas/types.yaml#/definitions/phandle > description: A phandle pointing to the display node. > > patternProperties: > "^panel": Just 'panel' and not a pattern. However, that's not what the original binding had. It was a separate node. If you want to preserve that, then you'll need a separate schema file and a special 'select'. Something like: select: anyOf: - required: [ atmel,dmacon ] - required: [ atmel,lcdcon2 ] - required: [ atmel,guard-time ] Up to you and at91 maintainers if you want to have to update your dts files or not. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel