From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CAD1C5475B for ; Fri, 1 Mar 2024 21:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4i3dkMP84QfCiLLHDGsGDiQ3D7xfUPvoHfk15PgAT6w=; b=B6ZnyAmyqN1g/W 6Vq/gn7FOenv3VL8ynruBiDE4gHGj4jHVIPPnVQuAa4H8Jhz2QO9wH4c4MupTCLXemrsBpuPAqTBF YuIB13qKfcwTr0/mAuZfv/FN8uyn7Mw4Th8XbNwOQKvw2FAn3bZLj2zsOQy7Z3T5y2w1Fq8ePrGoj mvrt2jRuTRcXtxxqk0bvOJtj2g8mg7QjVtA+Y33B4DDNxxOni8+x+JK/fMEob3LLL308J/MO3pyRH QXcQAQvJzdxP1y4kYGeVDolm900O3sehtdlQx3Oc9GBNng58AXGjUs5nJWPtjoz7u7BY/lUrPfPlj rH9K+4HA2sxuMOfrRtIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgA9y-00000001zNY-1Gj4; Fri, 01 Mar 2024 21:11:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgA9v-00000001zMq-1pv3 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 21:11:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D5F5661C43; Fri, 1 Mar 2024 21:11:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38681C433C7; Fri, 1 Mar 2024 21:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709327470; bh=PareT5Uh8qyKXVJmbXssDGNU+1BT0dFwAwAWmEQRgfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ke/foRsUxfyuNyennmryYOLtImZiHI/U9cBz9KR4XL5KcRw/J3ekb0E2Wsj2RsYof FESedK9y3YvMR/MhHPRE0N3iD8mB0cvI3Fo9sPvrcSDlGC38nEPOGUV0nmAeFD2ay/ L8oeCj+Z4vmhDmSnRNE/nTwKOFXsFmVbVHhDMlQ6RHNILq0ZTo/BmTZKbuVIJgqxqr gDuqaJvsSD9SS1T63uKw0ZnI0s5hk9/Bse6VdB8Czn9qAh1gALPXAAMtFwK7V73Evl EKpp8i9NFqjhEPgOHO9HabxpTHU/4uy6+8aEMuu8AB7ngJSf0MlFfFjDE/0DQFNk9e thFTy1aoc9ZiQ== Date: Fri, 1 Mar 2024 15:11:07 -0600 From: Rob Herring To: Laurent Pinchart Cc: Alexander Stein , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] media: dt-bindings: nxp,imx8-isi: Allow single port for single pipeline models Message-ID: <20240301211107.GA3037358-robh@kernel.org> References: <20240223140445.1885083-1-alexander.stein@ew.tq-group.com> <20240223140445.1885083-3-alexander.stein@ew.tq-group.com> <20240223141630.GA1313@pendragon.ideasonboard.com> <20240223141731.GB1313@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240223141731.GB1313@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_131111_538985_6413C220 X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 23, 2024 at 04:17:31PM +0200, Laurent Pinchart wrote: > On Fri, Feb 23, 2024 at 04:16:31PM +0200, Laurent Pinchart wrote: > > Hi Alexander, > > > > Thank you for the patch. > > > > On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote: > > > In case the hardware only supports just one pipeline, allow using a > > > single port node as well. > > > > This is frowned upon in DT bindings, as it makes them more complicated > > for little gain. The recommendation is to always use a ports node if a > > device can have multiple ports for at least one of its compatibles. > > And reading the cover letter, I see this causes warnings. I think we > need guidance from Rob on this. The warning is for: ports { port@0 {}; }; It should/could be changed like this to fix it: ports { port {}; }; But I've also said some warnings are guidance, not absolute. This is one of them. Some devices have optional port@1. In those cases, switching between 'port' and 'port@0' depending on 'port@1' makes little sense. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel