From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2D32C54798 for ; Sat, 2 Mar 2024 09:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CClf4IhUifYCq5LzzVBW4K2fisq9dPDUVJWG0GIPQPI=; b=fJFT9SP5+nHVy/ tEKcLwTDg1ZLEItlbb8829+46Gjaa3S+0UCa5Z352cGJg+fv0DUxulTxSF/+vtY32zlLA/xuNECW4 eGDFWmj7+hE36mvpTqDTEUjfqVAract8rpas/JXDs2sUFrghdu5I24/lkJZqVu3giaWue5W6dYLru F5Wd90TlgtJfNK5u466c5CgwF1mj44jAJwCMxBDeTqZR/aEYuAFKUBBP9UVodEyKBItJtjk9JnzFl OUl+jVRAkZnuFhIaXum4AEklMmRV6onCqVwGBNXnkDkqw5ytrQbAMrwlLtf68NUrOGL9pPWps4OqT O0YuteuKTa4nZ2HsTW/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgM55-00000003GbX-2nQX; Sat, 02 Mar 2024 09:54:59 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgM52-00000003Ga6-0b82; Sat, 02 Mar 2024 09:54:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709373292; x=1709978092; i=wahrenst@gmx.net; bh=pxvTbFrEhKnP34X+hqvpNu02JI9TDimz+eas9scR3aU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=mBDip5kDBI/j2foJXg/xgHdm/efhWcpXEZ2kr3zoJxm4YezrPEknQ2h9T7mcv2Jt RPWMc9L8EpZyovdOcQPr5Qbtc1nIYZHnERLCcYVpYvvm+Hm78Mgk//C4mkHfQcxvh iY7Ps7X1fOM+q7eDtz0Ae3UvnB+YU6kywHkzxhexA44aVK6phSkJt58N3XBMWkIp9 OenGC8G3csoRAtBdGbZ1u8gFeOOhfuWaKh5LDuKmr4Acd0xvydBNFoDrgWSOEKSBa dgcFS0pDILeKP6CuwNoLdqZOSl7Ep+5M3tA5LwCIN+5GK8/RI2+P54t3NtkxC72Jv EKgY9sdcheSojGJ2iA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MybKp-1qxJTN0zzZ-00yxq4; Sat, 02 Mar 2024 10:54:52 +0100 From: Stefan Wahren To: Linus Walleij , Florian Fainelli , Ray Jui , Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 2/2] pinctrl: bcm2835: Implement bcm2711_pinconf_get Date: Sat, 2 Mar 2024 10:54:30 +0100 Message-Id: <20240302095430.4871-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240302095430.4871-1-wahrenst@gmx.net> References: <20240302095430.4871-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:G3xIv53yPqofak8lVAYgqEtlc/bPM6Ubbnh330WxX92F8L4rkJR aW4QYQIsexT0YvdXG3nHjRQFOVGvguePsDWYw/QM1Cefxjk61x/8sRl757JuO4/w6EkzdLN Ip7J9K3eIJIMIfpVMc5n2hCfEgO+vyqmc4RHAgSEBloG762ImyxREWam8itdZI2d9QUP265 SZ4IxJrVHYp0Q6qT3/sOQ== UI-OutboundReport: notjunk:1;M01:P0:pn8wpvsTGE0=;jnMDqSrCSfR2yFDaPTrCTi5GGEC EGSBPcTAoGO10YoI8jkWR9M0a8vNZfUSfVQCsSrvNDtayNU6JZUfZtsYwGqG6xcCFMN67CFZy h9NcW81BZ9O1pn8h8q95bhVZtKkcaSM1wyrN8DxfTKWVqjQW65yV+NCaSPrF+45o0OKtUoEKa yF+y6UM8+xQB1e4eCGsxTjN3cMc6Qe2BvTjPJiFJnZ5k84g0wgV6Af0d4agRwj902O+PCGHvB htgrs9vhafjOkVtGf18t9W2KZngiiigQRMWJT5ONrq8JGmto6Y33b/DiWVQENzQrHM8ZBnyz9 ras/kyocUj/HuxDl74dD7LxQpXz1b8PG8TzCx6CZYuWDGg5fjvTEGNkYOVc/EdGHjgcn8r6kw /a+KyeK+wXQjgbuzabhsx9VtpH652VF+YmPSQuW4YZeLD0bmwEQ1lISlV/1Yf7jxxDEJPLUhp 30SYVKPYhV6xKaOS8YgncUtjk6r37tC5jSuVMGjPOk7f8qBL1O0IwnRYbVQD1FR00El8J/l6X PNj09yyxv8MxiFZL4vgDYhVO1Q2hFcly4hcm6YqWaS1fN8NVdNE4FurPcVlfdlL19AWlYZXOd nDW5FwaCtTKvtXB2nTTXlmsdWGLjNfsWFc3WlJVhvT8zKocLqIRNCMPo3jbLOsce7odJbSr1y wwNOLyWD2pxAjcfZWZBUXfhVuuh9a+Ly6gcyUyEAP7eijJywz303dQIYjBmG88r1wWDO3hkme oGibWaTPLat2JAZakvLD6TToMEQpNOptJu/SKBlvVHRSU1W0ollxJ0aAxSC06kxjCrIsV6kZx WeXtGwElymQOJS9rdoYpgPZDsRQuVquNHJMU18rAGHDq4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240302_015456_501535_87C226BD X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The BCM2711 allows to read the bias config. So implement pin_conf_get accordingly. The pull resistor values has been taken from the BCM2711/7211 datasheet. This implementation assumes that BCM7211 behaves the same way. Signed-off-by: Stefan Wahren --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 43 ++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index b37c86ec6915..fcb9ab6729c0 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -1112,6 +1112,47 @@ static const struct pinconf_ops bcm2835_pinconf_ops = { .pin_config_set = bcm2835_pinconf_set, }; +static int bcm2711_pinconf_get(struct pinctrl_dev *pctldev, unsigned pin, + unsigned long *config) +{ + struct bcm2835_pinctrl *pc = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param param = pinconf_to_config_param(*config); + u32 offset, shift, val; + + offset = PUD_2711_REG_OFFSET(pin); + shift = PUD_2711_REG_SHIFT(pin); + val = bcm2835_gpio_rd(pc, GP_GPIO_PUP_PDN_CNTRL_REG0 + (offset * 4)); + + switch (param) { + case PIN_CONFIG_BIAS_DISABLE: + if (((val >> shift) & PUD_2711_MASK) == BCM2711_PULL_NONE) + return 0; + else + return -EINVAL; + + case PIN_CONFIG_BIAS_PULL_UP: + if (((val >> shift) & PUD_2711_MASK) == BCM2711_PULL_UP) { + *config = pinconf_to_config_packed(param, 50000); + return 0; + } else { + return -EINVAL; + } + + case PIN_CONFIG_BIAS_PULL_DOWN: + if (((val >> shift) & PUD_2711_MASK) == BCM2711_PULL_DOWN) { + *config = pinconf_to_config_packed(param, 50000); + return 0; + } else { + return -EINVAL; + } + + default: + break; + } + + return bcm2835_pinconf_get(pctldev, pin, config); +} + static void bcm2711_pull_config_set(struct bcm2835_pinctrl *pc, unsigned int pin, unsigned int arg) { @@ -1179,7 +1220,7 @@ static int bcm2711_pinconf_set(struct pinctrl_dev *pctldev, static const struct pinconf_ops bcm2711_pinconf_ops = { .is_generic = true, - .pin_config_get = bcm2835_pinconf_get, + .pin_config_get = bcm2711_pinconf_get, .pin_config_set = bcm2711_pinconf_set, }; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel