From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9230C5478C for ; Mon, 4 Mar 2024 11:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vzZaioXjsPMr93yfPyu/YCFAty+L4gzj7I+pUcM1o7A=; b=XkGp1XvpuFkeuO VJ7G+9cbzM0W52tYdzcpbOgUHWRFIERNeXU7tMdlwOA1/c5htUxZ2Gq+mGpG7yB5hoL5DzaM8J3p6 sGKpz/YdHXjI1d0JmxnIIG6KZUeW9p9DYbtW1pZA2JI08JbfEihMmNHOteowQpUhHUvJI0smaCCxD Acy1fuMx5GbRros1bf9py91IfbYZHXUEMMIFgodFiwtp+YpwcMqQ9XryXdbQgooGy9EQx+lwbkc+L iPOcKcCs6qK+pkksuyl861cHSmF+vH8f0f1rYXKs5zP7Cn+zHl+Mj+KHv9jWVBPdukGoul3jY/Gtk 4PspHKYnIrr7etJtVHVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6RB-00000008oCC-0J1r; Mon, 04 Mar 2024 11:24:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6R7-00000008oAq-36vb for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 11:24:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFB081FB; Mon, 4 Mar 2024 03:25:21 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B65A23F738; Mon, 4 Mar 2024 03:24:43 -0800 (PST) Date: Mon, 4 Mar 2024 11:24:41 +0000 From: Andre Przywara To: "Arnd Bergmann" Cc: "Naresh Kamboju" , "open list" , "Linux ARM" , linux-sunxi@lists.linux.dev, dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org, "Maxime Ripard" , "Dave Airlie" , "Dan Carpenter" , "Ard Biesheuvel" Subject: Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! Message-ID: <20240304112441.707ded23@donnerap.manchester.arm.com> In-Reply-To: <338c89bb-a70b-4f35-b71b-f974e90e3383@app.fastmail.com> References: <338c89bb-a70b-4f35-b71b-f974e90e3383@app.fastmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_032449_836953_AE542D34 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 04 Mar 2024 12:11:36 +0100 "Arnd Bergmann" wrote: Hi, > On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju wrote: > > The arm defconfig builds failed on today's Linux next tag next-20240304. > > > > Build log: > > --------- > > ERROR: modpost: "__aeabi_uldivmod" > > [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! > > > > Apparently caused by the 64-bit division in 358e76fd613a > ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid"): > > > +static enum drm_mode_status > +sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector, > + const struct drm_display_mode *mode, > + unsigned long long clock) > { > - struct sun4i_hdmi *hdmi = drm_encoder_to_sun4i_hdmi(encoder); > - unsigned long rate = mode->clock * 1000; > - unsigned long diff = rate / 200; /* +-0.5% allowed by HDMI spec */ > + const struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector); > + unsigned long diff = clock / 200; /* +-0.5% allowed by HDMI spec */ Wouldn't "div_u64(clock, 200)" solve this problem? Cheers, Andre > long rounded_rate; > > This used to be a 32-bit division. If the rate is never more than > 4.2GHz, clock could be turned back into 'unsigned long' to avoid > the expensive div_u64(). > > Arnd > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel