From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90E6BC48BF6 for ; Mon, 4 Mar 2024 16:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2b7ImW21JIUnD5tzK4/1z1zCjE1xnSqnbRaytoW/muA=; b=M5wYHKROzC8+zv KW/mdYK+TLudp7nzfP8I1uHvqrewU9jUFkT0jf8kCSn1NwiH7Ge70NIpSggMPRXqIkCxxk51hnhxX FTFBnTMLdRvHDpvYrmqzp98cBO4cXXDubexp7QeabVo9lHAq3smGqgORe+PE5asdW6Wzn2yHBNG73 NlelRamvPWovISSgNr/NIsbDqaBOlfgw1x6fzgszyOg95+Tk9dKWmJXOlv6aq/25/U+2S3Sq6fKPm oOltOBcsmQswyP7k1QrnuWfl7hFZsQdCJDaerXwY3MU587exNeIx/jqXDM+DYmmWoD/ICdh8uetOP mMZoMM4+jg41H+Ri1p3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhB7R-00000009p2F-3NYS; Mon, 04 Mar 2024 16:24:49 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhB7P-00000009p1U-4A7r for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 16:24:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2DCA4CE1182; Mon, 4 Mar 2024 16:24:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44643C433F1; Mon, 4 Mar 2024 16:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709569485; bh=Yc4P1CIXlKDGFPR0/DVQiT/46JdWqiofdfkNDqPQVZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTeEzxHfNCuzklQWKn0MQXGpW9wqJ5wU7bMtXXE3fNVk9xkSNCPuSErh0dD0iaM66 Zf/idjm7pk9j+QcMsx+CiFy9KLc4DVT269NsV+fSYoAWP7T6MQZSNh+8Q8Z/guuzET fPgLI/JpW2VumWdtsZ9LYTzB2FhR8AKOkJ44dU0ewYkcxpbnA0Z/KHgTSA1xdAdBLy Ox3nmj1Me/PuiigdHF9L5hfYMUdMhWon/P14XnXBKzCzKmflmmQKwtTPwd4tMCMkmu japN0uyQHYOVfn+D5pfavzok/zAqZJSFByDy00IT9Rw2nVXfnL5vVst2ROwEp8Hn77 0ViJmGCCPQG6w== Date: Mon, 4 Mar 2024 10:24:43 -0600 From: Rob Herring To: Christophe Roullier Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Message-ID: <20240304162443.GA568211-robh@kernel.org> References: <20240229134724.1353903-1-christophe.roullier@foss.st.com> <20240229134724.1353903-3-christophe.roullier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229134724.1353903-3-christophe.roullier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_082448_226471_739D5122 X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 02:47:24PM +0100, Christophe Roullier wrote: > Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz > This property can be used with RMII phy without cristal 50Mhz and when we > want to select RCC clock instead of ETH_REF_CLK > Can be used also with RGMII phy with no cristal and we select RCC clock > instead of ETH_CLK125 > This new property replace st,eth-clk-sel and st,eth-ref-clk-sel That is obvious from the diff. What is not obvious is why we need a new property and what is the problem with the existing ones. > > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > index 80937b28fa046..fda23c07c1cad 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -85,12 +85,21 @@ properties: > phy-supply: > description: PHY regulator > > + st,ext-phyclk: > + description: > + set this property in RMII mode when you have PHY without crystal 50MHz and want to > + select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when you want to select > + RCC clock instead of ETH_CLK125. > + type: boolean > + > st,eth-clk-sel: > + deprecated: true > description: > set this property in RGMII PHY when you want to select RCC clock instead of ETH_CLK125. > type: boolean > > st,eth-ref-clk-sel: > + deprecated: true > description: > set this property in RMII mode when you have PHY without crystal 50MHz and want to > select RCC clock instead of ETH_REF_CLK. > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel