From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96584C5478C for ; Mon, 4 Mar 2024 18:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22dAI2UvOqgqWYN+8xZwl6YObN4cjrOPEkGgiYGY/JI=; b=hXnhisgtStvvka Zl/hzqFteW4Pri7yNN/aZMu9fX6YBOtpJeVx12uitiV2/0z9JguC4aoiEuFuwti3mbCQb9JzkUXQL Uejqt2IscM2f0HN/StJM6u5mbW5WcXgKjOwYo6eQUu0ZQ9bSy9F+iaF/OIYH2U1SKWchURND4Ktlz Nul6Cp5LiVaByrTSXAS7UEfsEyVP/yDfrTryaywMSR5k8a4ff/FgU551zG19MxC2iIlLyoCUJ6dd/ hKkwM6PA9PeVsUvh0HV4lSfJKBXO0Q6cjeWPEtYHQOtGjH8cr4SOv5XLMymru1jY3pz8vofXViddd T8vkRdYjrVlcAbZmf1gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDEu-0000000AE7A-1giz; Mon, 04 Mar 2024 18:40:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhDEq-0000000AE5K-1DgY for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 18:40:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 74FFF6119D; Mon, 4 Mar 2024 18:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE45C433C7; Mon, 4 Mar 2024 18:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709577635; bh=7vh4iyPXOaOgnr49RuHWi1jSWORQ0cB+J4ov6rz10CY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rahm3Kp4K15IbjidKWNlUNUEbKT1XAqkt9tB2YlZqVXTPrYMa7IrMt9UxN9cdRdNV SN11popSbGR9Ujlg49wTuKDZt+EamtXziRhi8KU/S+hDlGQnWrqVphkVFPEHUuGZPJ yPfDZ5aTeI8vOWndAXulFV010eWAwduB5upNgWONQ5GPHc4oKw0u1WAfh/2cq7pr5h Sl19wQvMPbJD1dPFmX0FBDRfoZJTSErer8kIc1ZA2gENu2NxMa5z5u8NZWb0SJEcyf URAMwAd5p/K/u7NZXL7FljcG9XsfE402zSdX00M4Z7mBWprpZ2NhNgtMYvqGk2Gscj a+Do5D6CO5Suw== Date: Mon, 4 Mar 2024 12:40:32 -0600 From: Rob Herring To: Raphael Gallais-Pou Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Krzysztof Kozlowski , Conor Dooley , Patrice Chotard , Lee Jones , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: thermal: convert st,stih407-thermal to DT schema Message-ID: <20240304184032.GA865748-robh@kernel.org> References: <20240301-thermal-v2-0-1b32752029ec@gmail.com> <20240301-thermal-v2-1-1b32752029ec@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240301-thermal-v2-1-1b32752029ec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_104036_594250_7D476A1D X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote: > 'st,passive_colling_temp' does not appear in the device-tree, and 'reg' > is missing in the device description. > > Convert st,stih407-thermal binding to DT schema format in order to clean > unused 'st,passive_cooling_temp' and add missing 'reg' property. > > Signed-off-by: Raphael Gallais-Pou > --- > Changes in v2: > - Change commit log to use imperative > - Drop description > - Drop 'clocks' description > - Add 'reg' property > - Add '#thermal-sensor-cells' > - Make node name generic in example > - Fix YAML style > --- > .../bindings/thermal/st,stih407-thermal.yaml | 56 ++++++++++++++++++++++ > .../devicetree/bindings/thermal/st-thermal.txt | 32 ------------- > 2 files changed, 56 insertions(+), 32 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml > new file mode 100644 > index 000000000000..68d7dd8b892f > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/st,stih407-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STi digital thermal sensor (DTS) > + > +maintainers: > + - Patrice Chotard > + - Lee Jones > + > +allOf: > + - $ref: thermal-sensor.yaml > + > +properties: > + compatible: > + const: st,stih407-thermal > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: thermal > + > + interrupts: > + description: > + For thermal sensors for which no interrupt has been defined, a polling > + delay of 1000ms will be used to read the temperature from device. maxItems: 1 > + > + '#thermal-sensor-cells': true const: 1 Also, not in the original binding, so please state in the commit msg why you are adding it. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + temperature-sensor@91a0000 { > + compatible = "st,stih407-thermal"; > + reg = <0x91a0000 0x28>; > + clock-names = "thermal"; > + clocks = <&CLK_SYSIN>; > + interrupts = ; > + #thermal-sensor-cells = <0>; > + }; > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel