From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD530C54E41 for ; Mon, 4 Mar 2024 22:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wtvSNBRvp06DRsdvsyC8nx5cvrYoNThui+FRLY4AIVw=; b=DnM33SJx6IlAYp 8IywP8xQtKPfBzR35Fx2vE5+yIyB/LyQgg2qhZcM8PQSPD/RMEGk3VrdpaDSZRpWYZJWTjodOumz6 FYk7i7MJ/q/IXRFXHpdytekqhvJFlSeVEEG3ADXIYDaop37YhshJuvMiTKD9p1w3cTupjWrg+ilPu dsP1FQzRvNRh5ZQYjk/yKBZPfg1i2ENpZlB/n67+By+eaOtP5z4/oawn/lvkHlpCoL03hhjcorOIL CQ1Kv0xdbGB2kGtJDyEKqvHb+/96/lMMvaPzVIQ75vyPHDbera4OVW0MPXKJJoQa6TTnnpRmkHWi2 /ZfqP112IQqnh++1hM+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhGNk-0000000AsEU-1RPS; Mon, 04 Mar 2024 22:02:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhGNh-0000000AsDz-3Blx for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 22:01:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 80F23611DE; Mon, 4 Mar 2024 22:01:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0715DC433C7; Mon, 4 Mar 2024 22:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709589716; bh=cqXMB5LaH1/xbA9ssgEQZjW69NwMDww1M1qLrr+EmDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kzwDgspQIO25NArRMwENJ9Lcj00WGdi2KhrHvwxCo7fsbV2LTA9bHtNHbfhvYoF65 o0E8Ccy9lQEJZB2GDGnvUvBfpSXFffA8u3NCkWeqpiRllSvP4R6t6DQbAcHi2Mqe3a BiI2jYmtfugdMRsHeeeIUriNJCJaT/rZBgM+tCz6t+hkbrYX7SnBjZ5B3O9qGV9VJc /HvYp6ur22G2Im0S0T39SDa4rsiUYQLooEGFoHWLsE99i8kOpMGmtIbUksbhbwltZd Rs3TR++2GxK/f3kGwAmAL/RE305D06Xtj4QdC9jjgICE1O3FTofrPr+4JkWuZIu97b c0inMgWAuyrgA== Date: Mon, 4 Mar 2024 16:01:54 -0600 From: Rob Herring To: Dharma Balasubiramani Subject: Re: [PATCH v3] dt-bindings: display: atmel,lcdc: convert to dtschema Message-ID: <20240304220154.GA1115739-robh@kernel.org> References: <20240304-lcdc-fb-v3-1-8b616fbb0199@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240304-lcdc-fb-v3-1-8b616fbb0199@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_140157_931147_F14340CB X-CRM114-Status: GOOD ( 24.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Alexandre Belloni , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , Claudiu Beznea , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2024 at 08:00:03PM +0530, Dharma Balasubiramani wrote: > Convert the atmel,lcdc bindings to DT schema. > Changes during conversion: add missing clocks and clock-names properties. > > Signed-off-by: Dharma Balasubiramani > --- > This patch converts the existing lcdc display text binding to JSON schema. > The binding is split into two namely > lcdc.yaml > - Holds the frame buffer properties > lcdc-display.yaml > - Holds the display panel properties which is a phandle to the display > property in lcdc fb node. > > These bindings are tested using the following command. > 'make DT_CHECKER_FLAGS=-m dt_binding_check' > --- > Changes in v3: > - Remove the generic property "bits-per-pixel" > - Link to v2: https://lore.kernel.org/r/20240304-lcdc-fb-v2-1-a14b463c157a@microchip.com > > Changes in v2: > - Run checkpatch and remove whitespace errors. > - Add the standard interrupt flags. > - Split the binding into two, namely lcdc.yaml and lcdc-display.yaml. > - Link to v1: https://lore.kernel.org/r/20240223-lcdc-fb-v1-1-4c64cb6277df@microchip.com > --- > .../bindings/display/atmel,lcdc-display.yaml | 97 ++++++++++++++++++++++ > .../devicetree/bindings/display/atmel,lcdc.txt | 87 ------------------- > .../devicetree/bindings/display/atmel,lcdc.yaml | 70 ++++++++++++++++ > 3 files changed, 167 insertions(+), 87 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/atmel,lcdc-display.yaml b/Documentation/devicetree/bindings/display/atmel,lcdc-display.yaml > new file mode 100644 > index 000000000000..5e0b706d695d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/atmel,lcdc-display.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/atmel,lcdc-display.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip's LCDC Display > + > +maintainers: > + - Nicolas Ferre > + - Dharma Balasubiramani > + > +description: > + The LCD Controller (LCDC) consists of logic for transferring LCD image data > + from an external display buffer to a TFT LCD panel. The LCDC has one display > + input buffer per layer that fetches pixels through the single bus host > + interface and a look-up table to allow palletized display configurations. The > + LCDC is programmable on a per layer basis, and supports different LCD > + resolutions, window sizes, image formats and pixel depths. > + > +# We need a select here since this schema is applicable only for nodes with the > +# following properties > + > +select: > + anyOf: > + - required: [ 'atmel,dmacon' ] > + - required: [ 'atmel,lcdcon2' ] > + - required: [ 'atmel,guard-time' ] > + > +properties: > + atmel,dmacon: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: dma controller configuration > + > + atmel,lcdcon2: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: lcd controller configuration > + > + atmel,guard-time: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: lcd guard time (Delay in frame periods) Is there a maximum? > + > + bits-per-pixel: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: lcd panel bit-depth. Constraints? > + > + atmel,lcdcon-backlight: > + $ref: /schemas/types.yaml#/definitions/flag > + description: enable backlight > + > + atmel,lcdcon-backlight-inverted: > + $ref: /schemas/types.yaml#/definitions/flag > + description: invert backlight PWM polarity > + > + atmel,lcd-wiring-mode: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array Isn't this just a single string rather than an array? > + description: lcd wiring mode "RGB" or "BRG" enum: - RGB - BRG No BGR? But wait, the example shows the value is '1'. That should fail testing. It didn't, but I've now fixed that. > + > + atmel,power-control-gpio: > + description: gpio to power on or off the LCD (as many as needed) maxItems: 1 > + > + display-timings: > + $ref: panel/display-timings.yaml# > + > +required: > + - atmel,dmacon > + - atmel,lcdcon2 > + - atmel,guard-time > + - bits-per-pixel > + > +additionalProperties: false > + > +examples: > + - | > + display: panel { > + bits-per-pixel = <32>; > + atmel,lcdcon-backlight; > + atmel,dmacon = <0x1>; > + atmel,lcdcon2 = <0x80008002>; > + atmel,guard-time = <9>; > + atmel,lcd-wiring-mode = <1>; > + > + display-timings { > + native-mode = <&timing0>; > + timing0: timing0 { > + clock-frequency = <9000000>; > + hactive = <480>; > + vactive = <272>; > + hback-porch = <1>; > + hfront-porch = <1>; > + vback-porch = <40>; > + vfront-porch = <1>; > + hsync-len = <45>; > + vsync-len = <1>; > + }; > + }; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel