From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02502C54E41 for ; Wed, 6 Mar 2024 18:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ahq6LJuHGLy3eakSvtAgZE45EOIlTJSY8pHjTSqE6qo=; b=CqKshx9EC2I6s1BrlSdm4IkpRn Sb5Ts07WqNhm3406FVX0+Kat/YQ3I0w9yCtJRoB9fFn3qF+S1y0d5/ezqapknwmoasqQQmx+5gmEQ WiUKt3vEGLu25TYdObPlfgzXudO7PZEg5MrCYmZZo0kM8KMRJWl+V25AqI5sUXevsCzKUhdPw5qKe EAExkkr2roA3vQ3h7RfBXwvrYxXfAWVXQtxbMduewdRcbTmNHxVBVDdZDdOsMcNvh9wKLMy/nEkB2 ziEhVW2Ytgf63XDo70mlkrOa0mwzO1m6tM75ypkMa4L5sD7w7jVvjLwm5s6XQtAHWJZL842H7L8Zs ajH6K15w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhwGa-00000001W5o-0nom; Wed, 06 Mar 2024 18:45:24 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhwGX-00000001W55-2K1q for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2024 18:45:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A68D0CE22D1; Wed, 6 Mar 2024 18:45:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBD37C433F1; Wed, 6 Mar 2024 18:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709750718; bh=7CP+A26tMm7Rg/McJFoxPIsRAv/dhgwhokRlKJJDh7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WYwSno0VcyP2eJcPt9fDzb7A1sk+TV/0ju9H33p/7aSBi8RntoPqX68fZvNOHstAr XfImv0tjdAICPJNdwMKFMoIEN0GfdQPErxzOvyRrpBOYvR6JhN3fWlPqiSbv4OkxAe 9c5dZ3dzsxHOfPQZmtgxqch3xwxrb/8pZZMztKjmM3Y1Xm94fe89qxFaQ6yZenKWIU 1t9k3xhkOkg3YPCgZoUu+JwS6XPT4/CVcHB/r/72RbINrIOUne9+6obnjJSGKEd5rE OxGaA8FY75l+Mbd//X4M2xXFO1D4wbd+l4bBkl6iNdRhurtL5hSHwfKQf8IxbnJAcV 9Tbqkyjk5V6bw== Date: Wed, 6 Mar 2024 18:45:13 +0000 From: Conor Dooley To: Frank Li Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Message-ID: <20240306-pebble-grope-88fdaa95a87c@spud> References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com> <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com> MIME-Version: 1.0 In-Reply-To: <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_104521_978680_F1597F5A X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7106931799569631176==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7106931799569631176== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3EPdioiMTrMIrN3t" Content-Disposition: inline --3EPdioiMTrMIrN3t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 05, 2024 at 12:33:04PM -0500, Frank Li wrote: > Some sai only connect one direction dma (rx/tx) in SOC. For example: > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx" > for dma-names. >=20 > Remove description under dmas because no user use index to get dma channe= l. > All user use 'dma-names' to get correct dma channel. dma-names already in > 'required' list. Acked-by: Conor Dooley > Signed-off-by: Frank Li > --- > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Docum= entation/devicetree/bindings/sound/fsl,sai.yaml > index 2456d958adeef..6f551c68d33db 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > @@ -81,15 +81,14 @@ properties: > =20 > dmas: > minItems: 1 > - items: > - - description: DMA controller phandle and request line for RX > - - description: DMA controller phandle and request line for TX > + maxItems: 2 > =20 > dma-names: > - minItems: 1 > - items: > - - const: rx > - - const: tx > + oneOf: > + - items: > + - const: rx > + - const: tx > + - enum: [ rx, tx ] I'm not entirely sure if this was Rob's suggestion, I got the impression he was suggesting that in the two items case we'd not care about the order. But while I think this is different to that suggestion it's also not wrong. Thanks, Conor. --3EPdioiMTrMIrN3t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZei5uQAKCRB4tDGHoIJi 0oGVAQC0WUWgje4xSZZqPzRwX4PZpsGdXdHoL3D6DvpnrN9/GgD/UgvXhmOyhVOO woy4Ab0tIG63oNAMuHs9RTTQly9j3gI= =3qdj -----END PGP SIGNATURE----- --3EPdioiMTrMIrN3t-- --===============7106931799569631176== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7106931799569631176==--