From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF4FDC5475B for ; Wed, 6 Mar 2024 19:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pikl/7SAaf15LjTEe6UiUQUmQq9Mcd2cBwAwg0RtlfA=; b=iybPJ0rF1Iie1SbMCHj7lAkDcd m1nX93c9/izLUcBZY2meW0rSWtgntDNCSmhODcCN0IoRpDnkc/8Kbb+ox/H/Rfjgw3ylFcnY0fKYB q9BpwUo93UgmwsTNnw5ByaO6M9CCta+7nN3ATGUEoWhE5+li+3N358suGYuHmp7vRhey+bYV/MT8m 844W1UuQ8gJ1x/JAFF0NKvvQSvbZEr4sXhK9A5CI/adPeIDsdxDKjZJsNFumzMd7N4XEUD96di5I9 FKPViRRBhoLgg84DkMCNh9Gcr3o91fcL/Q5B3y9stro7FlmIGxPPBqf1cdk1L01mFdVKBeWgL7Ts9 5ONxld6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhxCz-00000001gMV-0PVm; Wed, 06 Mar 2024 19:45:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhxCv-00000001gKX-2qb0 for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2024 19:45:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E80B61B06; Wed, 6 Mar 2024 19:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0CC3C433C7; Wed, 6 Mar 2024 19:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709754340; bh=5G1J0BhLc6CdOxwigI/ctXSY559sZ3EGEXyuCpYSgf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DEETAeIJJSkUQUzPDySpQ9hhYT2x0WxKI6ArF+euMpwJjwUqo2ESLn0WA22TE5j7K R36pHhm1XakM0l0MMl8oJg+XQV/ZMguoi4lKGDzUDb3GGj3HVakhMYnTO3NC6iGvGr 5Uua+soh+cdMV1VIPtwOX1TIf6lXef/7TWhr8/6D9qmif+9JMIEbZ2eZ5m+AprvbOc vCaQjDrZ8L+ZelJA9gr/DIso2OwLiSH1SoPWKvBWeX7FIqhM7uOaVUm2UxjAPQEDqq h7PxMikDG1u9yjzzjHrkOGmf47FsEmNCbxf3ItXW7YBIG87bp1fgOqUgFVzQBlFcBp rcG8N5FNlw1vw== Date: Wed, 6 Mar 2024 19:45:34 +0000 From: Conor Dooley To: Frank Li Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Message-ID: <20240306-petticoat-womb-a61cad7d788d@spud> References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com> <20240305-asrc_8qxp-v4-3-c61b98046591@nxp.com> <20240306-pebble-grope-88fdaa95a87c@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_114541_935093_952CFF9E X-CRM114-Status: GOOD ( 24.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1362491009033888666==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1362491009033888666== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="trxU1T+09Y67XLwE" Content-Disposition: inline --trxU1T+09Y67XLwE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 06, 2024 at 02:25:53PM -0500, Frank Li wrote: > On Wed, Mar 06, 2024 at 06:45:13PM +0000, Conor Dooley wrote: > > On Tue, Mar 05, 2024 at 12:33:04PM -0500, Frank Li wrote: > > > Some sai only connect one direction dma (rx/tx) in SOC. For example: > > > imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "= tx" > > > for dma-names. > > >=20 > > > Remove description under dmas because no user use index to get dma ch= annel. > > > All user use 'dma-names' to get correct dma channel. dma-names alread= y in > > > 'required' list. > >=20 > > Acked-by: Conor Dooley > >=20 > > > Signed-off-by: Frank Li > > > --- > > > Documentation/devicetree/bindings/sound/fsl,sai.yaml | 13 ++++++----= --- > > > 1 file changed, 6 insertions(+), 7 deletions(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/D= ocumentation/devicetree/bindings/sound/fsl,sai.yaml > > > index 2456d958adeef..6f551c68d33db 100644 > > > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml > > > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml > > > @@ -81,15 +81,14 @@ properties: > > > =20 > > > dmas: > > > minItems: 1 > > > - items: > > > - - description: DMA controller phandle and request line for RX > > > - - description: DMA controller phandle and request line for TX > > > + maxItems: 2 > > > =20 > > > dma-names: > > > - minItems: 1 > > > - items: > > > - - const: rx > > > - - const: tx > > > + oneOf: > > > + - items: > > > + - const: rx > > > + - const: tx > > > + - enum: [ rx, tx ] > >=20 > > I'm not entirely sure if this was Rob's suggestion, I got the impression > > he was suggesting that in the two items case we'd not care about the > > order. But while I think this is different to that suggestion it's also > > not wrong. >=20 > I log this at cover-letter. b4 can't support write change log at every > patch yet. Rob's suggest was not work. dt-binding check complain too long > if there are two dma-names =3D "rx", "tx".=20 Yeh, that is what happens if you just have dma-names: enum: [ rx, tx ] since that only allows one entry. Take a look at st,stm32-uart.yaml instead, for example. --trxU1T+09Y67XLwE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZejH3gAKCRB4tDGHoIJi 0o5ZAQC0bEJLk2rMmNg1h6oK0puBl8tnJqZX4qRtU8t6hz4KlAEAmuy73tHPP4vO iIc7yezGXRzST2Kg4QHm/imuO9iUSAs= =u4Ht -----END PGP SIGNATURE----- --trxU1T+09Y67XLwE-- --===============1362491009033888666== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1362491009033888666==--