From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBD52C54E41 for ; Wed, 6 Mar 2024 21:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X9tJ87aTUC9uqv5cmvwqwQv0YSWnTZMCRgNedET8KFQ=; b=OLcaZJUJhZ3x3o jUYc91Dq9aDuWBR/D/F8fMv+KdgNVm/G1//LwWd3CKiFEOXJ6wqNflEYMp04DL1QuBjx36UMvF3y1 pV0SOLScHS5xNaD1/Va1YGZrG07NqpOhKrGxsNRJ9qGZIVZQS5JRzZk/IZrYML7cyjyTeHR/Nraub et3becFskQ4gXzH4TRbYNZnbZqPlsQc6gA6JOdQQWIADRohRFk20yiCxGPX2DRifl14rlq8y6mO1o eiuqc/YeCq6si2X7FEqzjvs2xKZtvwR+L8AxloTpsPJYZlTz2unaqEmEaVipduREI7GdhUsId99Kz M7ZsCDJE2+K8IgS0mPAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhz5g-00000001z0a-1BXt; Wed, 06 Mar 2024 21:46:20 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhz5d-00000001z07-0Rqq for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2024 21:46:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0D7D661B44; Wed, 6 Mar 2024 21:46:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64B47C433F1; Wed, 6 Mar 2024 21:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709761575; bh=4MyjM4R7gGubu4ceSP37ZkH/7N5C3TSIAZ8zo4h/0Sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPylgsJDAzIegkEEAyd+DFggB7J4gMWakaazASs3Dz2VBnyF5rhZ9Sv52yVxGKrDO URQTLq+bBIb5RijGuDnFuDLCcufQ0uYnbZrAzyj603LNsLE/07gKyW1l0xvKbO3L2x AND8Uz2EwiiLB99eAf+ccDhsVHl8cObFRU1Y3T4S/n1ZEkOfBp4/d14R3XOozE0J56 zaGXQ32AJ6YJOT7mM9bVMuRjxRUx8YIKgxkFudZBC2Zqa6M6PcxGZGHbzbS6dcoDeM 9MyeWKKyaBkusY+xReT3ELXYSWjLzkOgdukKnYMxGtvJgsecLB+p1MF3KeFZFbuvK3 H2D5UzRqdHi9A== Date: Wed, 6 Mar 2024 15:46:13 -0600 From: Rob Herring To: "JiaLong.Yang" Cc: Will Deacon , Mark Rutland , Krzysztof Kozlowski , Conor Dooley , shenghui.qu@shingroup.cn, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: perf: Support uncore NI-700 PMU Message-ID: <20240306214613.GA716904-robh@kernel.org> References: <7f2576291e51043b33296a2cd9e21263d16ca077.1709694173.git.jialong.yang@shingroup.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7f2576291e51043b33296a2cd9e21263d16ca077.1709694173.git.jialong.yang@shingroup.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_134617_275769_9656D6E5 X-CRM114-Status: GOOD ( 23.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 06, 2024 at 02:16:02PM +0800, JiaLong.Yang wrote: > Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU > driver for HX. > > Signed-off-by: JiaLong.Yang > --- > v1 --> v2: > 1. Submit dt-bindings file Seperately. > 2. Do some check: > ~ #: make dt_binding_check DT_SCHEMA_FILES=perf > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTEX Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.example.dts > DTC_CHK Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.example.dtb > > v2 --> v3: > 1. Change vendor from hx to hexin. > 2. Submit driver and dt-bindings files together. > 3. Delete pccs-id property. Use alias-id to do this. > 4. There are at least one interrupt line for the hardware and driver > for handling counter overflow. > 5. Use 4 spaces for example indentation in yaml file. > > .../bindings/perf/hexin,c2000-arm-ni.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/hexin,c2000-arm-ni.yaml > > diff --git a/Documentation/devicetree/bindings/perf/hexin,c2000-arm-ni.yaml b/Documentation/devicetree/bindings/perf/hexin,c2000-arm-ni.yaml > new file mode 100644 > index 000000000000..b2641ee84d60 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/hexin,c2000-arm-ni.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/hexin,c2000-arm-ni.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HX-C2000 NI (Network-on-chip Interconnect) Performance Monitors > + > +maintainers: > + - Jialong Yang > + > +properties: > + compatible: > + enum: > + - hexin,c2000-arm-ni As this seems to be Arm IP, I'd expect arm,ni-700-pmu or something. Are there Hexin modifications to it? > + > + reg: > + items: > + - description: Physical address of the base (PERIPHBASE) and > + size of the whole NI configuration address space. Just 'maxItems: 1' if there is only 1 entry. > + > + interrupts: > + minItems: 1 > + items: > + - description: Overflow interrupt for clock domain 0 > + - description: Overflow interrupt for clock domain 1 > + - description: Overflow interrupt for clock domain 2 > + - description: Generally, one interrupt line for one PMU. But this also > + support one interrupt line for a NI if merged. I don't understand this last entry. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + aliases { > + ni-pmu0 = &nipmu0; Drop. Please don't make up your own alias names. > + }; > + > + nipmu0: pmu@23ff0000 { > + compatible = "hexin,c2000-arm-ni"; > + reg = <0x2b420000 0x10000>; > + interrupts = ; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 4f298c4187fb..4b664cec98a7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18890,6 +18890,12 @@ L: linux-riscv@lists.infradead.org > S: Maintained > F: arch/riscv/boot/dts/thead/ > > +HX ARM-NI-700 PMU DRIVERS > +M: Jialong Yang > +S: Supported > +F: Documentation/devicetree/bindings/perf/hexin,c2000-arm-ni.yaml > +F: drivers/perf/hx_arm_ni.c > + > RNBD BLOCK DRIVERS > M: Md. Haris Iqbal > M: Jack Wang > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel